Nathan Sobo
be7d093a4a
Merge remote-tracking branch 'origin/master' into ns-workspace-custom-elements
...
Conflicts:
package.json
2014-09-29 11:13:45 -06:00
Ben Ogle
b958286d22
Click to expand stack traces
2014-09-26 17:31:09 -07:00
Nathan Sobo
b5fc4aec84
Re-render component when EditorView is reattached
...
Fixes #3640
2014-09-26 15:15:23 -06:00
Nathan Sobo
0ebedeec3a
Merge remote-tracking branch 'origin/master' into ns-workspace-custom-elements
...
Conflicts:
package.json
src/workspace.coffee
2014-09-26 14:49:28 -06:00
Ben Ogle
1f2fc4bf00
Merge pull request #3619 from lee-dohm/scroll-past-end
...
Add ability to scroll past the end of the file
2014-09-26 11:47:58 -07:00
Ben Ogle
3601d113ad
Deactivate and unload all packages
2014-09-26 11:21:42 -07:00
Lee Dohm
00baedbdf9
Add specs for editor.scrollPastEnd behavior
2014-09-25 23:05:47 -07:00
Nathan Sobo
aa1eb94fa7
Ignore redundant calls to $::attachToDom
2014-09-25 22:17:26 -06:00
Nathan Sobo
5a72d12026
Don’t use jQuery to attach window listeners in spec-helper
...
This prevents the command palette spec from failing because it’s
explicitly asserting that no listener registered on the window without
a description should show up in the palette, but core:close is also
registered on the workspace.
2014-09-25 20:57:09 -06:00
Nathan Sobo
3442157e16
Fix command-installer-spec
2014-09-25 20:39:04 -06:00
Ben Ogle
c5fa8fdf11
Fix spec
2014-09-25 15:15:50 -07:00
Ben Ogle
e060e08f93
Deactivate and unload lang packages after use
2014-09-25 15:14:30 -07:00
Ben Ogle
039afff1de
Unload the coffee grammar after using
2014-09-25 15:14:29 -07:00
Ben Ogle
d33bd291dd
Deactivate / unload packages after use
...
This was messing with other specs!
2014-09-25 15:14:29 -07:00
Ben Ogle
0bc2b45200
Rename spec files
2014-09-25 15:14:29 -07:00
Ben Ogle
683d0d1b16
Editor -> TextEditor
2014-09-25 15:14:29 -07:00
Ben Ogle
82c53b539a
editor.coffee -> text-editor.coffee
2014-09-25 15:14:29 -07:00
Ben Ogle
c2f44efe31
editor-view -> text-editor-view
2014-09-25 15:14:29 -07:00
Ben Ogle
b3038eb968
editor-component -> text-editor-component
2014-09-25 15:14:29 -07:00
Nathan Sobo
442223f97b
💄 spec language
2014-09-25 12:44:53 -06:00
Nathan Sobo
eaa90e6158
Clean up debugging
2014-09-25 12:33:05 -06:00
Nathan Sobo
670f3e4946
Add WorkspaceElement
2014-09-25 11:41:09 -06:00
Nathan Sobo
ae488fc7fe
Update document edited status in workspace model
...
This also fixes a previous oversight where the status wasn’t updated
when switching between pane items with different modified status.
2014-09-24 17:00:25 -06:00
Nathan Sobo
28deb9dec5
Maintain document.title in the workspace model, not the view
2014-09-24 16:26:54 -06:00
Nathan Sobo
186335d619
Mock out document.title with Object.defineProperty
...
Previously the WorkspaceView::setTitle was mocked in specs to prevent
the title from changing. But I would like to move the title update logic
without breaking assertions, so now we can assert directly on
document.title.
2014-09-24 15:56:50 -06:00
Nathan Sobo
1c58438124
Move PaneContainerView::confirmClose to the model layer
2014-09-24 15:46:01 -06:00
Nathan Sobo
465d2afd95
Remove the old root view properly
2014-09-24 15:28:34 -06:00
Nathan Sobo
47f8f7eb11
Switch specs to use activationCommands instead of activationEvents
...
The activationEvents are converted to the same format as
activationCommands, and that property will be deprecated.
2014-09-24 14:34:29 -06:00
Nathan Sobo
63181a17c8
Support activationCommands field in package.json
...
This field mandates selectors in its structure and closely matches the
API of `atom.commands.add`. It will supplant `activationEvents` moving
forward.
2014-09-24 14:34:28 -06:00
Nathan Sobo
7d31b17273
Use the CommandRegistry to register activation event listeners
...
Commands registered with the command registry will always be handled
first, so as long as we disable any listeners in the registry that were
already invoked for the current command, we don’t need to disable jQuery
methods before replaying the command after activating the package.
This commit adds the ability to call .disableInvokedListeners on the
event passed to the command listeners. This returns a function which
can be called to reenable them.
2014-09-24 14:34:28 -06:00
Nathan Sobo
066f6bf03c
Forward stop[Immediate]Propagation to original event in CommandRegistry
...
Previously, stopping propagation would work on the synthetic bubbling
phase of the command registry itself, but the original event would
continue to propagate which is counterintuitive.
2014-09-24 14:34:28 -06:00
Nathan Sobo
a492596f7f
Allow atom.commands to participate in activationEvents
...
* Activation events can be handled via atom.commands
* Pre-existing listeners registered via atom.commands are disabled when
replaying events for the activated package.
2014-09-24 14:34:28 -06:00
Nathan Sobo
2df5957f9b
Restore commands after each spec
...
This commit adds the ability to get and restore snapshots of command
listeners. Whatever commands are installed before specs begin are
preserved, but commands added during specs are always cleared away.
2014-09-24 14:34:28 -06:00
Nathan Sobo
a7196ec906
Dispatch activation commands with native DOM apis in specs
2014-09-24 14:34:28 -06:00
Nathan Sobo
c094b7a0ef
Extract package-manager-specs from atom-specs
2014-09-24 14:34:28 -06:00
Nathan Sobo
09b5ac887a
Return whether a dispatched command matched a listener
2014-09-24 14:34:28 -06:00
Nathan Sobo
67ff8f4382
Don’t clear commands after specs
...
Commands are typically registered once at eval time. Clearing them
means that commands aren’t available except in the first spec.
2014-09-24 14:34:27 -06:00
Nathan Sobo
0c9fd46030
Add CommandRegistry::dispatch for tests
2014-09-24 14:34:27 -06:00
Nathan Sobo
3dbaa0679b
Merge pull request #3587 from atom/ns-workspace-view-providers
...
Add view provider API to Workspace
2014-09-23 13:08:00 -06:00
Ben Ogle
3bc115a7a0
Merge pull request #3606 from atom/bo-model-placeholder-text
...
Model EditorView::setPlaceholderText
2014-09-23 11:20:23 -07:00
Ben Ogle
169a5de6a3
not.toBeDefined -> toBeUndefined
2014-09-23 10:38:38 -07:00
Ben Ogle
4606ce2d50
Model setPlaceholderText
...
Less dependence on the editorView!
2014-09-22 17:21:42 -07:00
Ben Ogle
c62fb26001
onDidChangeSelectionRange emits object with ranges + selection
2014-09-22 16:08:12 -07:00
Ben Ogle
5083c18c84
Add cursor to onDidChangeCursorPosition event object
2014-09-22 15:37:41 -07:00
Kevin Sawicki
dc3a3225b3
Remove logging from specs
2014-09-22 15:00:06 -07:00
Ben Ogle
6e8cfba440
nof
2014-09-22 11:07:53 -07:00
Ben Ogle
7a429b024e
Use GitRepository rather than Git
2014-09-22 11:07:41 -07:00
Nathan Sobo
ddb85abe77
Don’t add the same editor to two different panes in spec
2014-09-19 16:30:37 -06:00
Nathan Sobo
55cce48af1
Throw an exception if the same pane item is added twice in the workspace
2014-09-19 16:24:13 -06:00
Nathan Sobo
d344adc21e
Allow view providers to specify a createView factory method
...
If present, it will be called with the model object instead of
instantiating the view constructor directly and assigning a model on it.
This gives users more flexibility when constructing views.
2014-09-19 16:24:13 -06:00
