Commit Graph

14898 Commits

Author SHA1 Message Date
Antonio Scandurra
2246072ac9 Restore line order in TokenizedBufferIterator.prototype.seek 2016-10-12 12:20:32 +02:00
Antonio Scandurra
633e68f4d5 Remove null guard in scopeDescriptorForPosition 2016-10-12 12:18:58 +02:00
Antonio Scandurra
ea80483cbe Delete TokenizedBuffer.prototype.buildPlaceholderTokenizedLinesForRows 2016-10-12 12:16:17 +02:00
Antonio Scandurra
d3882c165f 🎨 2016-10-12 12:09:28 +02:00
Antonio Scandurra
00f4c7b282 Use TokenizedBuffer.prototype.tokenizedLineForRow conservatively
Since this method will now construct a placeholder line, we want to use
it only where necessary to keep memory footprint to a minimum.
2016-10-12 09:04:41 +02:00
Antonio Scandurra
66510ae545 Handle null grammars consistently, building placeholder lines on-demand
Previously we were treating the local `NullGrammar` differently from
`atom.grammars.nullGrammar`. These two grammars are conceptually the
same, as the former was created to support editors creation without a
grammar registry.

To keep backwards-compatibility, we also build placeholder lines
on-demand when calling `TokenizedBuffer.prototype.tokenizedLineForRow`.
This ensure that packages relying on the internals of `TokenizedBuffer`
to retrieve syntactic boundaries won't break when the null grammar is
used or large file mode is on.
2016-10-12 09:04:41 +02:00
Max Brunsfeld
d20372a35f Start on removing placeholder lines in TokenizedBuffer 2016-10-12 09:04:41 +02:00
Nathan Sobo
72c5fcad82 Eliminate selector option in tooltip manager API
No packages use it currently, and it's really complex to support so
we should kill it while we have the chance. When it comes time to
rewrite the tooltip code or add features, not worrying about selectors
will make it easier.
2016-10-10 14:08:51 -06:00
Nathan Sobo
0c7fdea695 Document tooltip API directly instead of referring to Bootstrap docs
I want to eliminate the selector option and open the door to diverging from
the lesser used parts of that API in the future by only documenting a subset.
2016-10-10 14:08:51 -06:00
Nathan Sobo
e71e1f4ed1 Test custom class option 2016-10-10 14:08:51 -06:00
Nathan Sobo
718cc017e6 Hide click-triggered tooltips when clicking anywhere outside of tooltip
Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-10-10 14:08:51 -06:00
Nathan Sobo
253917f007 Make tooltip accept an item option instead of tooltipElement
...and use view registry to resolve it to a view when showing the tooltip.

Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-10-10 14:08:51 -06:00
Nathan Sobo
e9200e5bc0 WIP: Add ability to use custom elements inside tooltips 2016-10-10 14:08:51 -06:00
Antonio Scandurra
cccbde02fe Merge branch 'master' into as-export-text-editor-ctor 2016-10-10 10:39:38 +02:00
Antonio Scandurra
3d2e18747f Prefer using new TextEditor to Workspace.prototype.buildTextEditor 2016-10-10 09:28:36 +02:00
Antonio Scandurra
dbd7817823 Make TextEditor.prototype.scrollPastEnd false by default 2016-10-10 09:26:52 +02:00
Antonio Scandurra
18ddcf902b Statically assign a clipboard instance to the TextEditor class 2016-10-07 18:21:09 +02:00
Matthew Dapena-Tretter
f1be4f057e Add methods for checking if initial packages have been loaded/activated
This will allow packages to observe the state without having to worry
about subscribing to the events after they've already fired.

Originally suggested in #10839
2016-10-06 15:36:28 -07:00
Max Brunsfeld
26abbbd7cb Merge pull request #12883 from atom/mb-fix-maintain-grammar-return-value
Always return Disposable from maintain{Config,Grammar}
2016-10-05 12:49:02 -07:00
Max Brunsfeld
e6cac10a23 Always return Disposable from maintain{Config,Grammar} 2016-10-05 12:03:53 -07:00
Damien Guard
1a97f97a54 Specs runner dev tools should also be ctrl-shift-i on Linux/Windows 2016-10-04 15:26:24 -07:00
Indrek Ardel
fd1e060592 Use inline source maps for coffeescript 2016-09-30 15:03:04 +03:00
Max Brunsfeld
d79690e2d5 Merge pull request #12823 from atom/mb-as-guard-tab-length
Guard against null tab length value
2016-09-29 14:21:54 -07:00
Wliu
0e99232615 Merge pull request #12782 from Ingramz/remove-unused-variables-obvious
Remove unused variables (obvious ones)
2016-09-29 16:58:06 -04:00
Max Brunsfeld
28975fba81 Merge pull request #12780 from Ingramz/update-coffee-script
Update coffee-script to 1.11.0
2016-09-29 13:53:02 -07:00
Max Brunsfeld
814817ae4f Merge pull request #12824 from atom/mb-as-fix-window-method-calls-in-specs
Fix uses of `call-window-method` IPC channel in specs
2016-09-29 13:15:10 -07:00
Damien Guard
04b4c3ac9f Merge pull request #12821 from atom/dg-win-allow-multiple-user-instances
Allow Atom on Windows to run multiple instances e.g. on Windows server
2016-09-29 12:39:39 -07:00
Max Brunsfeld
51a2360a9b Fix uses of call-window-method IPC channel in specs 2016-09-29 12:13:24 -07:00
Damien Guard
8f7f812988 Merge pull request #10748 from atom/ld-glob-link
Add link to article on glob patterns
2016-09-29 12:10:51 -07:00
Max Brunsfeld
556d79b544 Guard against null tab length value
Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-09-29 12:01:39 -07:00
Wliu
85cc4e1312 Merge pull request #12822 from philschatz/documentation-for-indentationForBufferRow
Fixes documentation for TextEditor::indentationForBufferRow()
2016-09-29 14:56:21 -04:00
Philip Schatz
a7d30abdcf 🐛 documentation for TextEditor::indentLevelForLine
[ci skip]
2016-09-29 14:47:29 -04:00
Philip Schatz
3d22829104 🐛 documentation for TextEditor::indentationForBufferRow() 2016-09-29 14:23:17 -04:00
Philip Schatz
72110ed40f fixup! 🐛 support variable terminal widths 2016-09-29 13:58:47 -04:00
Damien Guard
2cf2dcca57 Allow Atom on Windows to run multiple instances e.g. on Windows server/Citrix etc 2016-09-29 09:55:34 -07:00
Philip Schatz
7bbc0d12eb 🐛 support variable terminal widths 2016-09-27 14:25:45 -04:00
Indrek Ardel
55f3311c01 Remove unused variables 2016-09-26 20:52:13 +03:00
Indrek Ardel
f7bd0d451f Update coffee-script to 1.11.0 2016-09-26 17:24:49 +03:00
Nathan Sobo
15a475889c Merge pull request #12762 from atom/ns-mb-minimize-main
Make main-process/main.js as minimal as possible
2016-09-23 09:41:40 -07:00
Max Brunsfeld
3a69e5bcb2 Merge pull request #12761 from atom/ns-mb-fix-dock-icon-click
Use app 'activate' event instead of defunct 'activate-with-no-open-windows'
2016-09-22 16:31:10 -07:00
Nathan Sobo
880e75ff18 Make main-process/main.js as minimal as possible
In order to test changes to main.js, we need to rebuild the application.
For this reason, it makes sense to do as little work as possible here.
In this commit, we change main to just determine the resourcePath, then
use that path to require a start function which can be iterated on in
dev mode.

Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2016-09-22 17:30:52 -06:00
Nathan Sobo
6535c64995 Merge pull request #12760 from atom/mb-ns-better-user-bindings
Make it easier to define user key bindings
2016-09-22 15:16:34 -07:00
Nathan Sobo
85efc08d13 Merge pull request #12753 from lgeiger/tildify-path
Tildify path in title bar
2016-09-22 15:07:50 -07:00
Nathan Sobo
f14587d3cc Use app activate event instead of defunct activate-with-no-open-windows
This restores the ability to open a Window by single-clicking the dock
icon on macOS.

Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2016-09-22 15:54:44 -06:00
Max Brunsfeld
db781dd54f Disallow duplicate keys when loading package keymaps
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-09-22 14:21:36 -07:00
Nathan Sobo
19a4f1ab89 Null guard AtomWindow instance in window-method ipc handler
Since things are async, I think the window could potentially disappear
before we can handle the message.
2016-09-22 14:14:37 -06:00
Nathan Sobo
b7126aff4c Don't serialize packages in deactivatePackages
Serialization still occurs when deactivating a single package via the
API. Otherwise, when the window is closed or reloaded we will serialize
all packages as a result of saving the window state.

Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2016-09-22 12:39:06 -06:00
Nathan Sobo
3a4ae04f74 Use call/respondTo helpers to return a promise from window method ipcs
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2016-09-22 12:18:09 -06:00
Nathan Sobo
50128949d4 Call window methods on AtomWindow when ipc'ing from render process
This enables saveState to be called when requesting a window reload from the render process.

Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2016-09-22 11:41:57 -06:00
Nathan Sobo
9ace7b899c Bind promptForRestart since it calls a method now
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2016-09-22 11:29:39 -06:00