Commit Graph

12184 Commits

Author SHA1 Message Date
Luke Pommersheim
c67f98febb if there are multiple cursors and you click a cursor, it is removed, otherwise new cursor is added. Cannot remove if there is only one cursor and you click on it 2015-06-11 13:26:09 +02:00
Luke Pommersheim
5822eb11f1 function that returns the first matched Cursor at a given screen position Point if it exists in that location 2015-06-11 13:02:14 +02:00
herkyl
b3687265bb Fixed 'setBufferRange' documentation parameter name 2015-06-11 10:37:38 +03:00
Kevin Sawicki
0edce07446 Use folder name when metadata name is empty string or non-string 2015-06-10 16:46:35 -07:00
Kevin Sawicki
4d76e607f0 Use dirname for forwarding atom/apm commands
Refs #7141
2015-06-10 16:30:54 -07:00
Max Brunsfeld
48ca93261f Merge pull request #7219 from atom/bf-revert-the-revert-of-pr-7022
Re-introduce atom.directory-searcher service v0.1.0.
2015-06-10 15:51:19 -07:00
Kevin Sawicki
3b6015954b Merge pull request #7176 from atom/mq-package-name-metadata
Only use package directory name as fallback
2015-06-10 15:38:31 -07:00
Michael Bolin
ad46b37cfe In workspace-spec.coffee, updated FakeSearch to match the spec, which
helped uncover a bug.
2015-06-10 23:30:42 +01:00
Michael Bolin
3c44bc06f4 Revert "Revert "Introduce atom.directory-searcher service v0.1.0.""
This reverts commit 262d41c306.
2015-06-10 23:30:25 +01:00
Kevin Sawicki
c3953dbbd4 Don't focus when opening locations 2015-06-10 09:27:20 -07:00
Kevin Sawicki
7d7b2375e1 Focus right after showing 2015-06-10 09:27:20 -07:00
Max Brunsfeld
6bccfcd0a3 Guard for atom windows w/ no webContents 2015-06-09 16:45:27 -07:00
Max Brunsfeld
f2851ac11d Merge pull request #7192 from atom/as-fix-empty-partially-off-screen-markers
Delete partially off-screen markers which are empty
2015-06-09 15:04:52 -07:00
Antonio Scandurra
f73435e053 🐛 Delete partially off-screen markers which are empty
* 🔥 Delete old code which was used to support some non-batched
methods in a previous version;
*  Cover “partially off-screen markers which are
empty” scenario, since that code path was not hit by previous specs

Fixes #7183
2015-06-09 21:35:01 +02:00
Max Brunsfeld
262d41c306 Revert "Introduce atom.directory-searcher service v0.1.0." 2015-06-09 11:51:30 -07:00
Max Brunsfeld
f830623512 Merge pull request #7022 from atom/bf-directory-searcher
Introduce atom.directory-searcher service v0.1.0.
2015-06-09 09:40:06 -07:00
Kevin Sawicki
fb48b38aa7 Guard against no resizing with no siblings
Closes #7091
2015-06-09 09:36:58 -07:00
Michael Bolin
535c0e2f34 Fix documentation bug. 2015-06-09 15:34:10 +01:00
Michael Bolin
1a6c542b45 Update comment. 2015-06-09 15:34:10 +01:00
Michael Bolin
6b1b57c89c Rename a variable to reflect a change in the previous commit. 2015-06-09 15:34:10 +01:00
Michael Bolin
0630bce95c Two things:
* Removed the `Directory` argument to `didSearchPaths`.
Now each searcher gets its own instance of `didSearchPaths` that is parameterized by provider.
* Simplified `DefaultDirectorySearcher.search()` so it creates one `DirectorySearch`
rather than one per `Directory` passed to `search()`.
2015-06-09 15:34:10 +01:00
Michael Bolin
18ac7d0cbc Comment excised, as recommended by @maxbrunsfeld. 2015-06-09 15:34:09 +01:00
Michael Bolin
028ac79836 Changed the behavior so that if a searcher rejects,
then the thenable returned by `atom.workspace.scan()` rejects.
2015-06-09 15:34:09 +01:00
Michael Bolin
7dc3d07f8a Changed the contract of DefaultDirectorySearcher in two significant ways:
* `search()` takes an array of `Directory` objects rather than an individual object.
* `options.didSearchPaths` now takes the `Directory` in addition to the `count` as an argument.
2015-06-09 15:34:09 +01:00
Michael Bolin
36123faf5d Changed DefaultDirectorySearcher to take multiple directories.
Still need to update `workspace.coffee` to make better use of this.
2015-06-09 15:34:09 +01:00
Michael Bolin
318498464a Responded to all of @maxbrunsfeld's comments except for:
* The effect of a failed search.
* Letting `DirectorySearcher::search` take multiple directories.

I'm working on those now.
2015-06-09 15:34:09 +01:00
Michael Bolin
5fc9d9e01a Document and test the cancel() method on the object returned by atom.workspace.scan(). 2015-06-09 15:34:09 +01:00
Michael Bolin
f7e822d41f Make delegate method names more delegate-like. 2015-06-09 15:34:09 +01:00
Michael Bolin
4eb30f3925 Switch to the delegate pattern,
eliminating a nasty race condition and deleting a lot of code.
2015-06-09 15:34:09 +01:00
Michael Bolin
fa3fd9c50c Remove empty param lists as per the linter. 2015-06-09 15:34:08 +01:00
Michael Bolin
735bdcca08 Two things:
1. Update documentation for `default-directory-search.coffee`.
2. Ensure that multiple `DirectorySearch` searches are run in series rather than in parallel to conserve resources.
2015-06-09 15:34:08 +01:00
Michael Bolin
fd670a4dd4 Remove myResolve local variable that I was using for debugging. 2015-06-09 15:34:08 +01:00
Michael Bolin
4330c3a181 Fix some nits I found during my self-review. 2015-06-09 15:34:08 +01:00
Michael Bolin
7294e0cda4 Change DirectorySearcher to return a DirectorySearch. 2015-06-09 15:34:08 +01:00
Michael Bolin
986640f670 Respond to comments from @maxbrunsfeld and @kevinsawicki. 2015-06-09 15:34:08 +01:00
Michael Bolin
7781e34ba2 Introduce atom.directory-searcher service v0.1.0.
The contract for a provider for the `atom.directory-searcher` service
is defined by the spec of the `DefaultDirectorySearcher`.

This modifies `Workspace::scan()` to use the appropriate `DirectorySearcher`
for each member of `atom.project.getDirectories()` when scanning the workspace
for files that match the specified regex.
2015-06-09 15:34:08 +01:00
Machiste Quintana
f9c612d1c8 Use an empty object if metadata is ~null 2015-06-08 21:33:07 -04:00
Machiste Quintana
07da68c95e Don't reassign metadata.name 2015-06-08 21:18:21 -04:00
Machiste Quintana
d78bc3f234 🎨 2015-06-08 21:14:11 -04:00
Machiste Quintana
0f876a73cc Only use package directory name as fallback
Fixes https://github.com/atom/atom/issues/7174
2015-06-08 20:45:41 -04:00
Nikhil Narula
50f4fe5b6c Correct isMaximixed misspelling to isMaximized 2015-06-08 20:43:13 -04:00
Kevin Sawicki
efb2ea544f Merge pull request #7158 from atom/wl-downloading-update
Enable "Downloading Update" context menu entry
2015-06-08 15:36:31 -07:00
Kevin Sawicki
6859a2924a Keep upgrading deprecated selectors until 1.0 2015-06-08 15:35:22 -07:00
Nathan Sobo
36d55c9384 Don’t break out soft tabs that are interrupted by a scope boundary 2015-06-08 22:56:32 +02:00
Antonio Scandurra
29ab1af2bf Merge pull request #7127 from atom/as-opaque-tiles
Bring Subpixel Anti-Aliasing Back
2015-06-08 20:51:02 +02:00
Antonio Scandurra
cec6959e08 Extend highlights to the full editor width 2015-06-08 18:58:04 +02:00
Kevin Sawicki
89de8cd185 Merge pull request #7169 from atom/mq-docs-get-repositories
Update Project::getRepositories() example
2015-06-08 09:31:07 -07:00
Machisté N. Quintana
0db3b70177 📝 Update Project::getRepositories() example 2015-06-08 10:59:34 -04:00
Wliu
9e6e05a5a6 Put 'update-available' in @downloadUpdate instead
So that it only shows up when there's an actual update
2015-06-07 11:33:26 -04:00
Wliu
ca72b802ac Enable "Downloading Update" context menu entry
Previously 'update-downloaded' would get emitted right after 'update-available' which would suppress the "Downloading Update" menu entry
2015-06-07 11:23:42 -04:00