Nathan Sobo
562a047b9e
Only requestUpdate when scrolling stops if component is still mounted
...
Fixes #2566
2014-06-10 12:13:57 -06:00
Ben Ogle
5db163a328
💄
2014-06-09 16:01:29 -07:00
Ben Ogle
756347a716
Add has-selection class to the editor div when there is a selection
2014-06-09 15:45:32 -07:00
Ben Ogle
6c609cb7d2
Revert "Move setImmediate into requestUpdate; Batch updates"
...
This reverts commit ad522e6ab1
2014-06-09 14:45:43 -07:00
Ben Ogle
ad522e6ab1
Move setImmediate into requestUpdate; Batch updates
2014-06-09 14:40:59 -07:00
Ben Ogle
e59f242f19
Move click gutter into the GutterComponent
2014-06-09 14:11:41 -07:00
Ben Ogle
31b4b7a372
Speed up decoration removal and use less temp objects.
2014-06-09 14:04:24 -07:00
Ben Ogle
1a1ed56419
Oh man. Render only once!
2014-06-09 14:04:24 -07:00
Ben Ogle
13be8d5139
Add a cursor-line decoration to the gutter
2014-06-09 14:04:24 -07:00
Ben Ogle
312901ff68
Use decorations for folds.
...
They are more efficient when re-rendering.
2014-06-09 14:04:24 -07:00
Ben Ogle
346b6007ca
Allow for typeless decorations that apply to everything
...
If you are querying for `type: ‘gutter’` it will return the typeless
decorations as well.
2014-06-09 14:04:24 -07:00
Ben Ogle
f30641da44
💄 Remove log line.
2014-06-09 14:04:23 -07:00
Ben Ogle
049531e495
Add comment
2014-06-09 14:04:23 -07:00
Ben Ogle
e8594ccec4
💄 Change var names for consistency
2014-06-09 14:04:23 -07:00
Ben Ogle
65ab436da2
API docs
2014-06-09 14:04:23 -07:00
Ben Ogle
e7bd8026d2
Deprecate old class functions
2014-06-09 14:04:23 -07:00
Ben Ogle
8e1e5a3760
Add ability to click the fold icons
2014-06-09 14:04:23 -07:00
Ben Ogle
02594e3f7a
💄 Use for loops
2014-06-09 14:04:23 -07:00
Ben Ogle
da5bf6c74c
Defensive on the decorations
2014-06-09 14:04:23 -07:00
Ben Ogle
5cd8f5952f
Make editor push decorator updates to the gutter
2014-06-09 14:04:23 -07:00
Ben Ogle
1b8be75a76
Add specs for the editor interface
...
for decorations in ranges and associated with markers
2014-06-09 14:04:23 -07:00
Ben Ogle
a13990155f
Use setImmediate rather than setTimeout
2014-06-09 14:04:23 -07:00
Ben Ogle
a72f11594d
💄 remove decoratorType instance var
2014-06-09 14:04:23 -07:00
Ben Ogle
86d7a45a78
Remove the comment about overlap
...
Turns out it’s already dealing with overlap by not emitting events
when there is an overlap.
2014-06-09 14:04:22 -07:00
Ben Ogle
a229d696d5
Add addDecorationForBufferRowRange and related remove
2014-06-09 14:04:22 -07:00
Ben Ogle
ef6ca3853d
💄
2014-06-09 14:04:22 -07:00
Ben Ogle
9e86d5f5f1
💄 Clean up based on feedback
2014-06-09 14:04:22 -07:00
Ben Ogle
3ef91c61d9
Add api for getStartBufferPosition and related fns
2014-06-09 14:04:22 -07:00
Ben Ogle
6ce859774a
Name changes
2014-06-09 14:04:22 -07:00
Ben Ogle
9ee54801a2
Implement removeDecorationsForMarker
2014-06-09 14:04:22 -07:00
Ben Ogle
732e23b8ea
Add initial addDecorationForMarker()
2014-06-09 14:04:22 -07:00
Ben Ogle
d51894103d
Debounce the rendering of decorations
2014-06-09 14:04:22 -07:00
Ben Ogle
eb59196c02
Rendering decorations works well.
...
Also specs.
2014-06-09 14:04:22 -07:00
Ben Ogle
142eedd705
Renders decoration changes.
2014-06-09 14:04:22 -07:00
Ben Ogle
77d269c6d9
Beginning of decorations
2014-06-09 14:04:22 -07:00
Ben Ogle
b23009a8f3
fold classes work
2014-06-09 14:04:21 -07:00
Nathan Sobo
8cf9e1990b
Add ReactEditorView::getModel shim
2014-06-09 13:47:36 -06:00
Nathan Sobo
fe3ea229a2
Prevent focus loss on double click without breaking single click focus
...
Previously, we stopped propagation on mousedown events to prevent
certain cases where focus was being lost after double clicking to select
a word.
Unfortunately, this also broke the ability to focus the editor by
clicking it. When investigating this, I noticed that whenever we lost
focus, the target of the mousedown event was always the cursor. So I
tried setting `pointer-events: none` on cursors and can no longer
reproduce the double-click issue.
/cc @probablycorey
2014-06-07 12:37:40 +09:00
Corey Johnson
776e8a308c
Merge pull request #2522 from atom/cj-fix-react-double-click-bug
...
Fix unresponsive text input after double-clicking
2014-06-06 08:54:44 -07:00
probablycorey
e0b54d8501
Use proper variable name
2014-06-06 08:06:16 -07:00
Nathan Sobo
cae5cdc81c
Put the .editor class on the wrapper, not the component
...
Things depend on the react editor wrapper having the .editor class,
but inside the editor, we can control the style. I changed the
component's div to be .editor-contents for now. We can eliminate this
extra style when we eliminate the wrapper.
2014-06-06 23:52:35 +09:00
probablycorey
7afb25cead
Remove semicolons
2014-06-05 17:57:25 -07:00
probablycorey
b0ddab842b
Stop mouseDown event from propagating.
...
Closes #2459
2014-06-05 17:22:12 -07:00
Kevin Sawicki
68964f1ca1
🏁 Don't crash when closing spec window
...
Focusing the window during the blur event that fires when the
window is closed currently crashes the app on Windows.
Closes #2485
2014-06-04 14:33:39 -07:00
Kevin Sawicki
c1ebbf36be
Add missing l to global
2014-06-04 09:52:20 -07:00
Kevin Sawicki
8717547db4
Normalize resource path in remaining locations
2014-06-04 09:45:27 -07:00
Kevin Sawicki
7c4a32fffa
Normalize resource path in AtomWindow constructor
2014-06-04 08:46:40 -07:00
Kevin Sawicki
b5703ff57a
Normalize resource path before creating app
...
This ensures the drive letter case is consistent with the format
used by require.
2014-06-03 17:40:08 -07:00
Kevin Sawicki
41ab48bc6e
Use path.join instead of path.resolve
...
This ensures the case of the path is consistent with how require resolves
paths.
Closes #2486
2014-06-03 17:19:00 -07:00
Corey Johnson
8e095d7b5b
Merge pull request #2164 from steffengy/fix-indent
...
Fix indenting of HTML tags for instance. Fix #1294
2014-06-03 12:01:44 -07:00
