github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-10 22:55:09 -05:00
Code Issues Packages Projects Releases Wiki Activity
31,553 Commits 140 Branches 571 Tags
2d3b7e82bd0bc2a3dcb7d05d217cfd3ffc5fc99e
Commit Graph

68 Commits

Author SHA1 Message Date
Nathan Sobo
1711d10af2 Aggregate onDidStopChangingActivePaneItem events across all containers 2017-04-06 16:35:25 -06:00
Nathan Sobo
ec576b12bc Remove PaneContainer.monitorActivePaneItem 
Call didChangeActiveItemOnPane directly from panes and when the active
pane changes instead.
 2017-04-06 13:18:18 -06:00
Max Brunsfeld
caafa41f6f Open docks when activating their panes, but not when adding items 2017-04-05 12:00:38 -07:00
Matthew Dapena-Tretter
3b23ab44bc Add getLocation() to PaneContainer class 
This allows the location to be inspected without having to jump to the
DOM and searching for a dock element.
 2017-03-27 17:45:21 -07:00
Matthew Dapena-Tretter
d9e1fcc70b Merge branch 'master' into HEAD 
* master: (43 commits)
  If one arch fails, kill the other for perf on appveyor
  ⬆️ dalek@0.2.1
  Revert "⬆️ all packages that use atom-select-list"
  ⬆️ atom-keymap
  ⬆️ status-bar
  ⬆️ all packages that use atom-select-list
  ⬆️ language-ruby@0.71.0
  ⬆️ autocomplete-css@0.16.1
  Ensure `packagesCache` exists before accessing it
  🎨
  ⬆️ less-cache
  Use `core/` instead of `<embedded>` for keymaps loaded during snapshot
  Set also defaultSettings.core.projectHome when initializing Config
  Fix tests
  ⬆️ atom-keymap
  Replace CommandRegistry.addBundled with a boolean param in .add
  Delete unused build scripts
  🔥 Remove parserlib
  Resolve style sheets paths during `script/build` for bundled packages
  Don't use cached less sources and imported files in dev mode
  ...
 2017-03-23 18:47:46 -07:00
Matthew Dapena-Tretter
98e7fcc505 Prefer getElement() to view registry for Docks, PaneContainer & Pane 2017-03-20 22:39:23 -07:00
Antonio Scandurra
b1704ee7e6 Fix Workspace specs 2017-03-11 19:20:16 +01:00
Matthew Dapena-Tretter
283a573ce5 Test that destroyed panes aren't included in PaneContainer::getPanes() 2016-09-12 18:03:40 -07:00
Nathan Sobo
e313bbe89c Ensure pane is added to container before invoking onDidAddPane listeners 
Fixes #12654
 2016-09-12 11:00:26 -06:00
Aaron Contreras
ee86cee4e0 ✅ Add specs for new commands, update old specs 2016-02-09 00:36:37 +01:00
Nathan Sobo
bd199545c0 In PaneContainer.prototype.saveAll, only save modified items 2015-10-21 20:22:20 -06:00
Nathan Sobo
84aa8471b4 Pass AppDelegate to Workspace, Pane instead of bound functions 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-13 18:54:48 -06:00
Nathan Sobo
d4c88cc7fd Merge branch 'master' into ns-alternative-test-env 2015-10-12 15:55:28 -06:00
Ross Allen
41984a2317 Add onDidStopChangingActivePaneItem for async callbacks 
`onDidChangeActivePaneItem` is called synchronously when the active pane
item changes, and several non-critical actions preform work on that
event. Critical UI feedback, like changing the active tab, needs to
happen synchronously, but most other functionality should be run
asynchronously.
 2015-10-12 10:24:07 -07:00
Max Brunsfeld
369f3d2648 Don't use atom.{notifications,config,deserializers,confirm} in Pane 
Still need to get rid of one use of showSaveDialogSync
 2015-10-09 17:18:26 -07:00
Nathan Sobo
4808c9f9e8 Eliminate config and confirm global references in Pane 2015-10-07 16:32:47 -05:00
Nathan Sobo
fd7fbbfea5 Move PaneContainer.deserialize to an instance method 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2015-10-07 15:24:55 -05:00
Nathan Sobo
17b4725b44 Don’t use Serializable mixin in PaneContainer 2015-09-22 10:46:30 -06:00
Nathan Sobo
2b75244240 Move pane container saveAll specs to model layer 2015-09-18 20:48:44 -06:00
Nathan Sobo
8d0207e82b Move pane container serialization specs to model layer 2015-09-18 20:48:44 -06:00
George Ogata
45694dcda0 Fire event before a pane is destroyed. 2015-07-23 18:47:38 -04:00
Nathan Sobo
7f8ab72f53 Capitalize initialisms 
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2015-01-12 22:00:24 -08:00
Nathan Sobo
fbc9c05096 Add Workspace::onDidDestroyPane 
This helps with the background-tips conversion
 2014-12-02 11:57:38 -07:00
Nathan Sobo
cfca6ecc86 Add specs for PaneContainer::onDidAddPane 2014-12-02 11:57:38 -07:00
Nathan Sobo
7dc9d0c8ce Add Workspace::onWillDestroyPaneItem 
It is needed by the autosave package which previously relied on DOM
bubbling to coalesce events from various panes.
 2014-12-01 10:39:29 -07:00
Nathan Sobo
6934b83acc Fall back to first pane if activePaneId is invalid 
When deserializing PaneContainer.

Fixes #4069

Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2014-11-07 15:44:59 -07:00
Nathan Sobo
442223f97b 💄 spec language 2014-09-25 12:44:53 -06:00
Nathan Sobo
1c58438124 Move PaneContainerView::confirmClose to the model layer 2014-09-24 15:46:01 -06:00
Nathan Sobo
a33706ddbc Add PaneContainer::onDidAddPaneItem and ::observePaneItems 2014-08-28 17:42:12 -06:00
Nathan Sobo
877fa40a49 Activate next pane on before invoking onDidDestroy observers 2014-08-28 17:23:49 -06:00
Nathan Sobo
cee7539e35 Add PaneContainer::observePanes and ::onDidAddPane 2014-08-28 17:22:28 -06:00
Nathan Sobo
b34367ad44 💄 pane-container-spec 2014-08-28 14:42:12 -06:00
Nathan Sobo
74b2f26540 Add PaneContainer::onDidChangeActivePaneItem 2014-08-28 14:41:56 -06:00
Nathan Sobo
9487609f0c 💄 pane-container-spec 2014-08-28 14:41:56 -06:00
Nathan Sobo
8521114c08 Fix failures associated with not passing focused: true on pane splits 2014-06-09 17:09:02 +09:00
Nathan Sobo
9af4b14716 Never allow PaneContainer::root to be null 2014-01-15 16:07:47 -07:00
Nathan Sobo
6ef6fb77f9 Rename pane-*-model specs 2014-01-13 17:22:02 -07:00
Nathan Sobo
918c31905f Rename PaneContainer to PaneContainerView 2014-01-13 13:46:28 -07:00
Nathan Sobo
4f604ced3c Rename Pane to PaneView 2014-01-13 13:46:22 -07:00
Nathan Sobo
3fc3d48def Destroy empty panes after deserializing 
Fixes #1399
 2014-01-12 17:53:25 -07:00
Nathan Sobo
b438b311f3 Rename showItem methods to activateItem 
These methods set the *active* item, so the verb activate provides a
clearer correspondence. We could change the noun to "shown" item, but
that's awkward and having both active panes and active items is a nice
correspondence in terminology.
 2014-01-12 17:40:57 -07:00
Nathan Sobo
561e31c0c5 Remove ::removeItemAtIndex and make ::removeItem private 
Call ::destroyItem or just destroy the item directly (it should emit the
'destroyed' event)
 2014-01-12 17:25:51 -07:00
Nathan Sobo
28b085be1c Rename ::makeActive to ::activate and focus panes when they're activated 2014-01-11 20:48:01 -07:00
Nathan Sobo
72fe586101 Remove the concept of focus from the model 2014-01-10 17:27:28 -07:00
Nathan Sobo
23e805fe9e Remove assertion for impossible situation 
We were testing the behavior of returning the active pane by removing
the active class from its view. But "active" is a model-level concept
now, so this assertion makes no sense.
 2014-01-10 15:28:55 -07:00
Nathan Sobo
e87b8dc463 Remove focusNext/PreviousPane methods from PaneContainer view 2014-01-09 18:35:01 -07:00
probablycorey
196942d126 Rename .row and .column in pane specs 2014-01-08 16:31:56 -08:00
Corey Johnson & Nathan Sobo
25c099f3a2 Serialize the items and activeItem via PaneModel 
This necessitates setting the ::activeView based on the model's
::activeItem instead of doing it in ::showItem.
 2014-01-07 17:23:29 -07:00
Nathan Sobo
18a712a1f7 Reopen closed pane items in workspace – by uri instead of deserializing 
Serializing and deserializing closed pane items was turning into a pain
with the new telepath changes that are phasing out this kind of on the
fly serialization. Reopening by uri saves memory and simplifies panes
enormously. If we want non-uri reopening we can revisit it later when
telepath models are better integrated.
 2013-12-10 17:19:44 -08:00
Kevin Sawicki
7f039b3383 Update confirmSync references in specs 2013-11-22 15:09:47 -08:00