Antonio Scandurra
2dd944f3ee
Trigger ::onWillMeasure before measuring anything
2015-09-16 12:07:57 +02:00
Antonio Scandurra
2750a384ac
💚 Fix TextEditorPresenter specs
...
...so that they play nicely with LinesYardstick
2015-09-16 11:33:51 +02:00
Antonio Scandurra
29846d0a51
Add LinesYardstick
...
...and create a MockLineNodesProvider for testing purposes
2015-09-15 18:41:41 +02:00
Antonio Scandurra
398fb1f62d
🔥 Avoid mounting the container in ctor
...
...as it will be mounted anyways when updateSync gets called
2015-09-15 17:50:21 +02:00
Antonio Scandurra
346c7d9b37
Defer state building in TextEditorPresenter
2015-09-15 17:44:31 +02:00
Antonio Scandurra
1cdc7ae5a0
Decouple horizontal dimensions computation from vertical ones
...
The former needs measurement and, therefore, depends on the latter.
2015-09-15 17:30:47 +02:00
Antonio Scandurra
578b157da0
Differentiate between gutter and lines tiles
...
...and fix specs as well. 💚
2015-09-15 17:22:22 +02:00
Antonio Scandurra
a6c13d097a
Render the longest screen row without painting it
2015-09-15 16:53:55 +02:00
Antonio Scandurra
8e06e06899
Compute the state for the longest line on screen
2015-09-15 16:32:42 +02:00
Antonio Scandurra
4c5101a7e1
🎨 Refactor ::updateTilesState to a composed method
2015-09-15 15:44:06 +02:00
Antonio Scandurra
c7d4871453
Merge pull request #8730 from atom/as-faster-style-recalculation
...
Faster Style Recalculations
2015-09-15 11:25:10 +02:00
Antonio Scandurra
de0b61393c
Minimize allocations
2015-09-14 10:57:59 +02:00
Nathan Sobo
c0a4987e66
🎨
2015-09-10 10:16:38 -07:00
Nathan Sobo
eaeed3c892
🙈 Actually push scopeName
2015-09-10 10:16:38 -07:00
Nathan Sobo
c1d4f3f1a0
🎨 Only pop from scopeStarts if top of stack matches ending scope
2015-09-10 10:16:38 -07:00
Indrek Ardel
bb11d13fe3
Fix typo
2015-09-10 10:16:37 -07:00
Indrek Ardel
e1b984820d
Pop scope from the top of scopeStarts directly
2015-09-10 10:16:37 -07:00
Antonio Scandurra
9a431a5c97
💚
2015-09-10 18:06:18 +02:00
Lee Dohm
cd1134bd3e
Merge pull request #8672 from fedorov/clarify-addOpener-usage
...
Add a clarification about the usage of addOpener
2015-09-10 07:59:07 -07:00
Antonio Scandurra
326a035835
🐎 Decrease tile size to make finer grained updates
2015-09-10 16:19:33 +02:00
Max Brunsfeld
f56dde9c91
Setup browser-process exception handler before requiring anything
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-09-09 11:57:54 -07:00
Antonio Scandurra
493df95294
Merge branch 'master' into as-faster-style-recalculation
2015-09-09 20:53:58 +02:00
Antonio Scandurra
6c69f430f3
🔥 Remove z-index
2015-09-09 16:12:09 +02:00
Antonio Scandurra
47fb48b514
🐛 Correct boolean logic
2015-09-09 14:29:57 +02:00
Antonio Scandurra
246476f759
🎨
2015-09-09 14:26:47 +02:00
Antonio Scandurra
fe039a0f3c
💚
2015-09-09 13:31:34 +02:00
Antonio Scandurra
86815f5be4
🐎 Remove inline styles for line numbers
2015-09-08 19:30:44 +02:00
Antonio Scandurra
b997b8c189
🔥 Remove line node style.top
2015-09-08 18:52:25 +02:00
Antonio Scandurra
8713f215c1
🐎 Remove unused class
2015-09-08 18:40:27 +02:00
Antonio Scandurra
c7fb8bc293
Merge branch 'master' into as-order-line-nodes
2015-09-08 18:11:17 +02:00
Nathan Sobo
7e0b0a4427
Cache incompatible packages based on electron version
...
This will cause us to re-check all packages when upgrading the version
of Electron.
2015-09-08 09:53:45 -06:00
Nathan Sobo
f5a591f6b3
Disable colored output from apm rebuild
2015-09-08 09:53:45 -06:00
Nathan Sobo
ea5b12d69c
Clear build failures, cached incompatible modules after rebuild
2015-09-08 09:53:45 -06:00
Nathan Sobo
f571ee7baf
Add Package::rebuild
2015-09-08 09:53:45 -06:00
Antonio Scandurra
1d1fb4caef
🎨
2015-09-08 17:23:41 +02:00
Antonio Scandurra
23cb2740cd
🐎 Remove class from tiles
2015-09-08 16:44:44 +02:00
Antonio Scandurra
848b4ed564
Order line nodes by screen row
2015-09-07 19:47:45 +02:00
Thomas Johansen
919445cf8a
🐛 Fix undefined reference to syntheticEvent
2015-09-06 10:27:26 +02:00
Nathan Sobo
aed785924d
Continue to dispatch CustomEvent instances in CommandRegistry
...
This changes the approach used to synthesize an event to dispatch. Since
we can no longer point to the original event as our prototype, we build
a new CustomEvent instance and override select properties with
Object.defineProperty. This preserves the contract with event handlers
by giving them a true CustomEvent instance.
2015-09-06 10:27:25 +02:00
Thomas Johansen
6294bc22d7
Simplify workaround, and describe issue with Object.create + CustomEvent
2015-09-06 10:27:25 +02:00
Paul Betts
b483fc6805
Set App User Model ID on Win32
2015-09-06 10:27:25 +02:00
Thomas Johansen
405eaf14d1
🙈 Add temporary hack to work around issue with CustomEvent
...
Since it's no longer possible to "properly" extend CustomEvent, we will need to
figure out a way to shadow the prototype chain, or some such.
See https://code.google.com/p/chromium/issues/detail?id=495437 for more details.
2015-09-06 10:27:24 +02:00
Cheng Zhao
e3f9074f4a
Object.create doesn't work well with CustomEvent in Chrome 43
2015-09-06 10:27:24 +02:00
Andrey Fedorov
f2a1b69a34
Add backticks around URLs for style consistency
2015-09-05 14:24:07 -04:00
Andrey Fedorov
2c7be877c6
Update note explaining the usage of the protocol
2015-09-04 13:28:19 -04:00
Andrey Fedorov
136a30f180
Add a clarification about the usage of addOpener
...
Documentation augmented with a note about the need of using fake protocol in
order to invoke opener on a file already opened.
See discussion at
https://discuss.atom.io/t/difficulties-using-atom-workspace-addopener/20444
2015-09-04 10:23:40 -04:00
Max Brunsfeld
c4fc8e55fa
Use correct executedFrom value for subsequent invocations
2015-09-03 16:03:02 -07:00
Max Brunsfeld
8993ed1da6
Merge pull request #8661 from atom/mb-fix-opening-files-with-line-numbers
...
Fix handling of filename:line:column command-line arguments
2015-09-03 12:19:46 -07:00
Nathan Sobo
d6c0e8f8c8
Merge pull request #8660 from atom/as-null-bytes-paired-char
...
Avoid pairing null byte characters
2015-09-03 13:17:37 -06:00
Max Brunsfeld
e5da009cdc
Strip colon-number suffixes from args before parsing them as URLs
2015-09-03 11:31:01 -07:00
