Max Brunsfeld
3039024d17
Go back to using promise based on window:loaded event in main process tests
2016-09-21 11:37:24 -07:00
Max Brunsfeld
833b3b0ab0
Save state when reloading AtomWindow
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2016-09-20 16:10:11 -07:00
Max Brunsfeld
30fdb70dfd
Initialize app-started promise before reloading AtomWindow
2016-09-20 09:53:54 -07:00
Nathan Sobo
7bba3e86b2
Try this on travis
2016-09-16 16:47:33 -06:00
Nathan Sobo
212cb0df34
Resolve AtomWindow.reload promise once window fully starts
2016-09-16 14:33:30 -06:00
Nathan Sobo
5fad2bdbf9
Return a promise from AtomWindow.reload that resolves on window:loaded
2016-09-16 14:10:34 -06:00
Nathan Sobo
0ff0b269b1
Don't wait for spec windows to save state
...
Since spec windows don't register handlers for the IPC messages requested window state to be saved, the promise never resolves and the close button needs to be clicked twice. To avoid this, we'll just resolve the promise immediately in a spec window so we can proceed to close it.
2016-09-12 10:26:40 -06:00
Antonio Scandurra
34a99f9c82
Write tests to ensure quitting the application works as expected
2016-09-07 14:18:52 +02:00
Antonio Scandurra
0f6eadcfce
Wait for windows' state to be saved before closing the app or any window
...
Previously, we used to save the window's state in the renderer process
`beforeunload` event handler: because of the synchronous nature of event
handlers and the asynchronous design of IndexedDB, this could
potentially not save anything if windows close fast enough to prevent
IndexedDB from committing the pending transaction containing the state.
(Ref.: https://mzl.la/2bXCXDn )
With this commit, we will intercept the `before-quit` events on
`electron.app` and the `close` event on `BrowserWindow` (which will fire
respectively before quitting the application and before closing a
window), and prevent them from performing the default action. We will
then ask each renderer process to save its state and, finally, close the
window and/or the app.
2016-09-07 13:03:33 +02:00
Nathan Sobo
dbfd0cc605
Move integration test of window persistence to main process tests
2016-08-11 15:28:11 -06:00
Nathan Sobo
6994060e72
Use fat arrow where it is needed
2016-08-11 14:31:23 -06:00
Nathan Sobo
502339b830
Replace chromedriver test of window offset with main process mocha test
...
Signed-off-by: Antonio Scandurra <as-cii@github.com >
2016-08-11 10:33:12 -06:00
Nathan Sobo
c1b2042bcc
🎨
2016-08-02 16:19:38 -06:00
Philipp Brumm
76357473ad
call setSheetOffset on onDidChangeActiveThemes
2016-07-13 14:59:37 +02:00
Philipp Brumm
08a358228b
move title bar setting check into method and check for isSpec as well
2016-07-06 14:22:17 +02:00
Philipp Brumm
29dab2e5b2
setSheetOffset to height of titlebar
2016-07-02 13:01:14 +02:00
Philipp Brumm
faa1f935f8
make custom titlebar user-configurable and prompt for relaunch on change
2016-07-02 12:28:14 +02:00
Philipp Brumm
a357228876
explicitly check for platform being darwin before applying titleBarStyle
2016-07-02 12:28:14 +02:00
Philipp Brumm
4897f4db26
replace OSX window title bar with custom title-bar
2016-07-02 12:28:14 +02:00
Sam Hunter
2d68c49274
Only spec window's web view should force focus
2016-06-12 23:20:43 -07:00
Sam Hunter
2daa8d60f4
Fix WebView focus
...
This code is needed to automatically focus the webview when it is blurred
2016-06-12 23:16:26 -07:00
Sam Hunter
0f673ea884
Remove workaround for old Windows bug
...
The code removed is no longer needed as it was fixed in this issue of atom-shell
https://github.com/electron/electron/issues/380
2016-06-10 23:49:14 -07:00
Antonio Scandurra
3f8f3c95a8
🔥 Remove extra comma
2016-05-25 15:55:36 +02:00
Antonio Scandurra
49a603a873
Show also a message box when recovery is not successful
2016-05-25 15:54:39 +02:00
Antonio Scandurra
c2b01d54b8
Make coupling looser between the recovery service and the windows
2016-05-25 15:46:37 +02:00
Antonio Scandurra
3ce7d0a974
Merge branch 'master' into as-file-recovery-service
2016-05-25 14:04:16 +02:00
Antonio Scandurra
5e3f343e41
Merge branch 'master' into as-main-process-test-runner
2016-05-25 11:03:10 +02:00
Antonio Scandurra
df0b3dedd7
browser -> main-process
2016-05-25 11:02:29 +02:00
