Kevin Sawicki
32353a31eb
Only restore window when it is minimized
...
Restoring a maximized windows on Windows unmaximizes it.
Closes #3381
2014-08-26 09:55:22 -07:00
Nathan Sobo
2a94e4a33c
Pass tokenizedLines to LinesComponent so measuring stays in sync
...
Fixes #3318
2014-08-25 18:16:45 -06:00
Nathan Sobo
070ca1a4bb
Call checkForVisibilityChange when showing editors via EditorView::show/hide
2014-08-25 18:16:29 -06:00
Nathan Sobo
0849f1ea84
Perform a sync update after editor becomes visible
...
This pauses updates during measurements. If any updates were requested
while measuring, we force an update synchronously to prevent flicker.
This commit also removes the visibility check before updating, because
we can't force an update from this spot in the lifecycle. This shouldn't
be needed anyway because we are polling for visibility changes.
2014-08-25 17:31:29 -06:00
Nathan Sobo
c4f5a3516b
Assign atom.lastUncaughtError in window.onerror handler
2014-08-25 16:36:14 -06:00
Kevin Sawicki
69aa34954f
Remove call to no-op EditorView method
2014-08-25 15:31:39 -07:00
Ben Ogle
abadc9805c
Add _all_ the defaults in from editorView
2014-08-25 14:46:48 -07:00
Ben Ogle
ad269357b7
Ugh. No @mini. @mini is a prop.
2014-08-25 14:34:19 -07:00
Ben Ogle
ae323d2083
Use @mini
2014-08-25 12:24:19 -07:00
Ben Ogle
cef24a3979
Remove the react editor options
2014-08-25 12:15:34 -07:00
Ben Ogle
d37bd14a62
Deprecate getEditor() at a later date…
2014-08-25 12:07:48 -07:00
Ben Ogle
3d2d8c491f
rename react-editor-view -> editor-view
2014-08-25 12:07:48 -07:00
Ben Ogle
b05a83a6ce
move getEditor fn
2014-08-25 12:07:48 -07:00
Ben Ogle
0d68430bb8
Deprecate gutter api
2014-08-25 12:07:48 -07:00
Ben Ogle
d75485a2d8
Deprecate no-op’d things
2014-08-25 12:07:48 -07:00
Ben Ogle
e54bc0fbaa
Remove toggle soft wrap and toggle soft tabs
...
No one uses them in packages, and we don’t use them internally
2014-08-25 12:07:17 -07:00
Ben Ogle
cf9208bc02
Deprecate pageUp / pageDown
2014-08-25 12:07:16 -07:00
Ben Ogle
35fd19f3ef
📝 Add docs for current public methods
2014-08-25 12:07:16 -07:00
Ben Ogle
97bcdcc9b0
Rename ReactEditorView -> EditorView
2014-08-25 12:05:55 -07:00
Ben Ogle
fc441ef5e2
📝 fix return doc
2014-08-25 12:05:55 -07:00
Ben Ogle
431fab1a43
Remove the editor-view
2014-08-25 12:05:10 -07:00
Ben Ogle
0e62c98768
Fix the mini-editor test
2014-08-25 12:02:38 -07:00
Ben Ogle
f8026bb005
Require the react-editor-view where we require the editor-view
2014-08-25 12:02:38 -07:00
Ben Ogle
c3c91ae6c3
Only emit the marker-created event when the marker exists
...
This caused problems in the case of find-and-replace:select-all with
multiple editors into the same file.
* a marker is created on the TextBuffer capturing the selection
* DisplayBuffer:create-marker is fired from the first DisplayBuffer.
The marker is turned into a selection which is merged into the current
selection, deleting the marker that was created.
* DisplayBuffer::handleBufferMarkerCreated is called on the second
DisplayBuffer. The marker has been destroyed at this point, so it emits
DisplayBuffer:create-marker with undefined.
* ERROR>
Closes #3364
2014-08-25 11:42:44 -07:00
Ben Ogle
c073d042b8
Merge pull request #3371 from atom/iz-fix-context-menu-again
...
Dont handle ctrl+click mouse events on OSX
2014-08-25 10:44:11 -07:00
Kevin Sawicki
4b8fd222f1
Merge pull request #2996 from thomasjo/editorview-grammarscopes
...
Add grammar scope to EditorView
2014-08-25 10:14:46 -07:00
Kevin Sawicki
fb53f85573
Rename topWindow to lastFocusedWindow
2014-08-25 09:21:27 -07:00
Kevin Sawicki
6610447e09
📝 Clarify safeMode description
2014-08-25 09:21:27 -07:00
Kevin Sawicki
9f7560bb89
📝 Doc other atom.open options
2014-08-25 09:21:27 -07:00
Kevin Sawicki
a853a27857
Open folder in current untitled window
...
Untitled windows will now have their project path set when a folder
is opened.
2014-08-25 09:21:27 -07:00
Kevin Sawicki
154fe4006f
📝 Doc file/folder path behavior in usage message
2014-08-25 09:21:27 -07:00
Kevin Sawicki
17feb91876
📝 Move comment above isFile check
2014-08-25 09:21:27 -07:00
Kevin Sawicki
5bdf8a14a7
Use once for closed event
2014-08-25 09:21:27 -07:00
Kevin Sawicki
1196e5a264
📝 Doc dev mode case
2014-08-25 09:21:27 -07:00
Kevin Sawicki
a4ae314b00
💄
2014-08-25 09:21:27 -07:00
Kevin Sawicki
c9390b61de
Track AtomWindow from ipc open event
...
This ensures the window where the file is dropped is used to open
that file into even when that window does not have focus.
2014-08-25 09:21:27 -07:00
Kevin Sawicki
2811663177
Open file paths in focused window
2014-08-25 09:21:26 -07:00
Ivan Zuzak
b0a9eefa04
Dont handle ctrl+click mouse events on OSX
...
Ctrl+click on OSX brings up the context menu. In that case, handling the click
event deselects any selection, and that shouldn't happen. See
https://github.com/atom/atom/issues/3308 .
2014-08-24 13:33:30 +02:00
Thomas Johansen
d3b06542a5
Change attribute name to data-grammar
2014-08-24 10:17:25 +02:00
Thomas Johansen
9c154a2f5a
Implement support for React Editor
2014-08-24 10:17:25 +02:00
Thomas Johansen
6b1868efd5
Make sure the scope data attribute is always set
2014-08-24 10:17:25 +02:00
Thomas Johansen
e50887aab8
Use data attribute instead of CSS classes
2014-08-24 10:17:25 +02:00
Thomas Johansen
c6ca03fa49
Add grammar scope to EditorView
...
Only works when the `grammar-changed` event has been triggered,
and only implemented for Space Pen views.
2014-08-24 10:17:25 +02:00
Nathan Sobo
9164b0ea3b
Don't remeasure char widths until we've performed initial measurement
2014-08-22 11:37:04 -06:00
Nathan Sobo
59a80dcd60
Don't use guard clauses in short measurement methods
2014-08-22 11:36:17 -06:00
Nathan Sobo
72354ebf32
Check for visibility change when mounting instead of polling DOM
2014-08-22 11:35:51 -06:00
Nathan Sobo
a71a524ec7
Rework DOM measurement to try to prevent measurement errors
...
* Simplify scrollbar refresh and measurement by using imperative DOM
manipulation instead of React to hide/show scrollbars.
* Rename `::performInitialMeasurement` to `::becameVisible`
* Break `::checkForVisibilityChange` out of `::pollDOM` and use it in
to check for the element becoming visible in `componentWillUpdate`.
* Don't rely on stored visibility state anywhere. Always check again.
This could potentially be cached for an update cycle but being wrong
about this is disastrous so I'm being conservative.
2014-08-21 17:50:46 -06:00
Ben Ogle
26d696a93d
Add classes to the workspace for themes
...
Fixes #3097
2014-08-21 11:53:10 -07:00
Ben Ogle
30aa47026d
Do not move cursor when interacting with horiz scrollbar
...
Fix #3284
2014-08-21 10:40:16 -07:00
Aaron Shafovaloff
d986ab0293
Removed unnecessary comma
2014-08-21 10:09:32 -06:00
