Commit Graph

258 Commits

Author SHA1 Message Date
Nathan Sobo
c901417a19 When lines are added, remove any that get pushed down to exceed the max allowed row
This fixes issues where unfolding or pasting caused rendering artifacts below the last visible row.
2012-05-31 12:06:00 -06:00
Corey Johnson
17c0526bc3 Add test for gutter rendering of fold lines 2012-05-31 10:26:34 -07:00
Nathan Sobo
39fb14e5f5 Add a spec for line number updates after folding/unfolding 2012-05-31 10:57:04 -06:00
Nathan Sobo
6c64d2a13b spec 💄 2012-05-31 10:46:00 -06:00
Corey Johnson
17b50ee8dc Folds include their first line 2012-05-30 16:55:15 -07:00
Corey Johnson
42e743f44a Renderer.toggleFold works for folded, foldable and non-foldable lines
When a line is not foldable, we search upward for a suggested fold that contains it and apply that fold instead. If called with a row that is already folded, it unfolds it.
2012-05-30 16:29:45 -07:00
Corey Johnson
76f5d35eb9 Add toggle-fold event to editor 2012-05-30 15:43:21 -07:00
Nathan Sobo
0ef4c7e172 Only re-render the gutter when we render new lines 2012-05-29 15:12:11 -06:00
Nathan Sobo
3e26386f98 Always re-render gutter from the first rendered to the last rendered screen row 2012-05-29 14:51:19 -06:00
Nathan Sobo
0700aba67f All specs pass again with overdraw 2012-05-29 13:39:13 -06:00
Nathan Sobo
6e34124f12 Overdraw gutter line numbers in addition to editor lines 2012-05-29 13:07:24 -06:00
Nathan Sobo
a9c9a854ac Only truncate change ranges to the last visible row if the last rendered row is smaller
This happens, for example, when the entire buffer is shorter than the number of rows on screen. In this case, the last rendered row is not smaller than the last possible visible row.
2012-05-29 13:03:29 -06:00
Nathan Sobo
c00c3317f0 Down to 2 failures by truncating change ranges to the range of the current rendered lines 2012-05-29 12:52:39 -06:00
Nathan Sobo
e9a67208e6 Adjust otherwise-passing spec for overflow 2012-05-29 11:50:54 -06:00
Nathan Sobo
8fba4ff935 Fix some off by one errors in the overdraw calculations 2012-05-26 13:52:48 -07:00
Nathan Sobo
328aa3ba6b WIP: Redoing overdraw code… it's broken 2012-05-26 13:05:25 -07:00
Nathan Sobo
351c283ed6 Merge branch 'master' into overdraw 2012-05-25 13:13:06 -07:00
Nathan Sobo
e2ca3814a9 Hide the cursor when it is on a fold line 2012-05-25 12:35:32 -07:00
Corey Johnson & Nathan Sobo
f8c3d89e60 When folds are selected they are highlighted 2012-05-24 16:39:14 -07:00
Corey Johnson & Nathan Sobo
f97912c160 💄 2012-05-24 11:43:09 -07:00
Corey Johnson & Nathan Sobo
9b83ce6545 renderer tells editor when the gutter needs to be updated 2012-05-24 11:17:37 -07:00
Corey Johnson
a7d43c2cca meta-alt-u unfolds lines at cursor 2012-05-22 09:38:14 -07:00
Nathan Sobo
3f4c7deb30 Nuke stray call to Editor.logLines 2012-05-21 19:00:02 -07:00
Nathan Sobo
581998f94b Oh, un-F 2012-05-21 18:35:51 -07:00
Nathan Sobo
f39891b912 Folds are destroyed when their placeholder line is clicked 2012-05-21 17:55:58 -07:00
Nathan Sobo
7ad5830521 Convert failing specs to linewise code folding 2012-05-21 14:18:00 -07:00
Nathan Sobo
4f60135d81 Remove random indent that was causing editor spec not to run 2012-05-21 13:35:54 -07:00
Nathan Sobo
03ae0bbbb6 Guts on the floor, but 2 line-wise fold specs are passing and the renderer is getting there 2012-05-18 19:22:56 -06:00
Corey Johnson & Nathan Sobo
39e02bbf9f wip: what nathan and corey did 2012-05-18 15:15:44 -07:00
Corey Johnson & Nathan Sobo
4c92be669e Remove non-passing unneeded spec 2012-05-18 14:12:41 -07:00
Corey Johnson & Nathan Sobo
8e9db80b58 wip: another failing fold test 2012-05-18 11:59:54 -07:00
Corey Johnson & Nathan Sobo
20c9b61b91 Fix issue where creating a second fold on a wrapped line fragment caused a duplicate line to be rendered 2012-05-18 12:22:40 -06:00
Corey Johnson & Nathan Sobo
06d1f8a718 Create a failing fold spec 2012-05-17 17:20:17 -07:00
Corey Johnson & Nathan Sobo
608ccc38e8 Update rendered lines when buffer changes occur outside/straddling rendered region 2012-05-17 16:06:39 -07:00
Corey Johnson
857486bcf1 After buffer changes, remove any lines that are beyond the current last rendered screen row. 2012-05-17 10:34:54 -07:00
Corey Johnson
52fe580cf6 Test that inserting lines re-renders the gutter 2012-05-17 10:17:05 -07:00
Corey Johnson
0e09659d79 Gutter adjusts its width to account for the width of the last line number 2012-05-17 10:16:20 -07:00
Corey Johnson
7a82bf2679 💄 2012-05-17 08:49:03 -07:00
Nathan Sobo
0d093c3014 2012-05-16 17:28:07 -06:00
Nathan Sobo
5045d68be2 2012-05-16 14:47:09 -06:00
Nathan Sobo
a7b5f0c249 Un-F 2012-05-16 14:12:11 -06:00
Nathan Sobo
92395a9cfb Merge branch 'master' of github.com:github/atom
Conflicts:
	src/app/editor.coffee
2012-05-16 14:07:44 -06:00
Nathan Sobo
2d8ba3b1ee Use translate3d to scroll lines / gutter in attempt to improve repaint.
Also: Add custom scrollTop method to editor that manages all the custom optimizations we are doing around scrolling.
2012-05-16 13:47:59 -06:00
Corey Johnson
2c508f5a31 Fix tests
Certain tests resize the editor and expect the number of lines to adjust, this forces the test to meet that expectation.
2012-05-16 11:30:25 -07:00
Corey Johnson
3614ad6e76 Update lines when the font size changes 2012-05-16 10:58:19 -07:00
Corey Johnson
399fc71b3c Make Atom SpacePen view's default to empty object (where needed) 2012-05-16 10:35:50 -07:00
Corey Johnson
484b55800a Call updateLines when lines are removed from buffer 2012-05-15 14:27:22 -07:00
Corey Johnson
54a3823606 Buffer change events update the @lastRenderedScreenRow 2012-05-15 12:29:59 -07:00
Corey Johnson
6b3664a040 Vertical scrollbar height is updated when switching buffers 2012-05-15 10:02:56 -07:00
Corey Johnson & Nathan Sobo
9079bcb103 Meta-a selects everything 2012-05-14 16:18:37 -06:00