Commit Graph

16838 Commits

Author SHA1 Message Date
Max Brunsfeld
3548abe541 Fix bug w/ empty node handling, comment TreeSitterHighlightIterator 2018-05-23 08:11:54 -07:00
Max Brunsfeld
f6d2d57299 Reparse again if there were changes since the last parse started 2018-05-23 08:11:54 -07:00
Max Brunsfeld
aced30da1f Start work on async parsing 2018-05-23 08:11:54 -07:00
hansonw
d646f70f12 Handle cases where the item may be destroyed 2018-05-15 11:32:31 -07:00
hansonw
1f685768d5 Ensure grammar activation hooks are called after emitting new editors 2018-05-15 11:32:31 -07:00
Jason Rudolph
db88a07e8c Fix test failure re: "Module._cache.hasOwnProperty is not a function"
Example build failure:
https://ci.appveyor.com/project/Atom/atom/build/job/fvtxos5ys6a5lek1#L634

As of Node 8.0.0, Module._cache.hasOwnProperty is no longer a function:
403b89e72b
2018-05-04 14:24:57 -04:00
Jordan Eldredge
c65c76cee9 Fix out of date doc block method name
Looks like this method name changed in https://github.com/atom/atom/pull/3456/files#diff-88c69a7ba7e0c0d0090f4501ca44472c but the comment did not get updated.
2018-05-02 10:09:55 -07:00
Max Brunsfeld
12a54fb04f Use callback when calling mkdirp in recovery service 2018-05-01 11:48:47 -07:00
Byron Igoe
305bf9b4cb Await async mkdirp 2018-05-01 11:48:47 -07:00
Byron Igoe
f17add20c1 Cleaned up 2018-05-01 11:48:47 -07:00
Byron Igoe
a885d8a030 Fixes https://github.com/atom/atom/issues/17013 by creating the recovery directory 2018-05-01 11:48:47 -07:00
Max Brunsfeld
3f8b463b15 Move auto update initialization back to AtomApplication.initialize
This fixes some CI problems introduced in #17216
2018-05-01 11:01:18 -07:00
Max Brunsfeld
d36c102ca0 Don't scroll in unfoldAll if there were no folds 2018-04-25 12:57:59 -07:00
Max Brunsfeld
79eab0527a Reassign language modes when toggling tree-sitter feature flag 2018-04-25 12:57:40 -07:00
Max Brunsfeld
1ad9715e9d Wait to initialize auto update manager until config is loaded 2018-04-25 09:33:53 -07:00
Max Brunsfeld
d233e20c32 Merge pull request #17212 from atom/mb-remove-project-flags
Remove 'project' command line flag
2018-04-25 09:14:02 -07:00
Max Brunsfeld
85d745cbec Remove 'project' command line flag
From what I can tell, this flag never worked correctly. Instead of
opening the paths specified in the project file, the directory
containing the project file itself would always be opened.
2018-04-25 07:45:58 -07:00
David Wilson
5b485dcb4b Merge pull request #15165 from segevfiner/sf-windows-update-process-env
Recognize Windows cmd or powershell environment in updateProcessEnv
2018-04-25 10:44:29 -04:00
Max Brunsfeld
7a5d727e22 Avoid writing to config file while quitting 2018-04-18 10:46:38 -07:00
Ash Wilson
c578cd2bfa .type 👉 .action 2018-04-16 14:09:55 -04:00
Ash Wilson
a0c68ec70b 👕 restore missing break 2018-04-12 14:43:13 -04:00
Ash Wilson
48a622cc74 Increment the version of the readOnly serialization key 2018-04-12 14:23:17 -04:00
Ash Wilson
0c2f458497 Boolean logic, my old enemy 2018-04-12 14:13:38 -04:00
Ash Wilson
4e9544583b Can't use the same name for the property and method 2018-04-12 14:07:17 -04:00
Ash Wilson
1def646e09 Return the property we're actually setting 2018-04-12 13:35:30 -04:00
Ash Wilson
1545768522 Derive the readonly attribute from model.isReadOnly() 2018-04-12 13:23:12 -04:00
Ash Wilson
6ee477a329 Disable the hidden input when the model is readOnly or keyboard disabled 2018-04-12 11:50:53 -04:00
Ash Wilson
0a48c3cece Separate TextEditor keyboard enablement from readOnly state 2018-04-12 11:50:11 -04:00
Jason Rudolph
72b664dc88 📝 Document deprecation for undo option
Refs #16956
2018-04-05 19:55:05 -04:00
Matthew Dapena-Tretter
dfd3ba8c14 Defer component initialization until element is requested
This fixes the error snapshotting Docks described in #16864.
2018-04-02 17:10:39 -07:00
Matthew Dapena-Tretter
5af205739d Don't trigger dock handle drag enter event unless a known item is being dragged
This seems a little counterintuitive. How could a dragenter event fire
if nothing's being dragged? Well, if something's dragged into the
document (i.e. from the desktop or another window), a dragenter event
will be fired even though (as far as we're concerned), nothing is being
dragged. Rather than trying to handle this class of events specially in
the dock, we simply limit our listening to when something is being
dragged. Since we have a single source of truth for this information,
this should be resilient to future changes in logic.
2018-03-30 14:11:30 -07:00
David Wilson
31e9ddad1e Merge pull request #16864 from atom/fb-mdt-etch-docks
Convert Dock class to Etch
2018-03-30 11:59:08 -07:00
Max Brunsfeld
e6abfd1f31 Remove duplicate command bindings for undo and redo
Co-authored-by: Nathan Sobo <nathan@github.com>
2018-03-29 16:50:38 -07:00
Ash Wilson
7ffe82c1cd Special-casing \r breaks the word regexp 2018-03-29 15:06:06 -04:00
Ash Wilson
92f6ab599f Pass Config file path to ApplicationDelegate call 2018-03-27 08:56:29 -04:00
Ash Wilson
34a93a9e66 Pass a configFilePath along with the user settings 2018-03-27 08:55:31 -04:00
Ash Wilson
ad8392b2f5 Accept a filePath in the set-user-settings IPC call 2018-03-27 08:55:07 -04:00
Ash Wilson
1342316e73 Maintain a global Map of ConfigFile instances 2018-03-27 08:54:37 -04:00
Ash Wilson
f927651e6e Giant-ass try/finally block 2018-03-23 16:36:35 -04:00
Ash Wilson
c16287fbdd Track Promises for URLs that are being opened asynchronously 2018-03-23 16:26:35 -04:00
Ash Wilson
9de8131731 Ditto for Selection methods 2018-03-21 14:30:18 -04:00
Ash Wilson
ebb7647903 Mutation methods are no-ops in production. Throw in dev or spec mode 2018-03-21 14:25:50 -04:00
Ash Wilson
82575f5b07 👕 2018-03-21 12:29:52 -04:00
Ash Wilson
8fee5f8fb2 Merge remote-tracking branch 'origin/master' into aw/no-really-read-only 2018-03-21 11:55:52 -04:00
Ash Wilson
d405039581 Pass {bypassReadOnly} to selection.cut() 2018-03-21 11:53:36 -04:00
Ash Wilson
71d12f3f2c Guard Selection methods against read-only TextEditor modification 2018-03-21 11:53:20 -04:00
Ash Wilson
56a3f1bc41 Fill in missing ensureWritable() calls caught by the specs 2018-03-21 09:29:36 -04:00
t9md
b35cfaed20 Pass selectionsMarkerLayer on transact, undo and redo
To restore selections of change initiated editor on undo/redo.
2018-03-21 14:25:59 +09:00
Ash Wilson
1f866bd592 Add options.bypassReadOnly on methods that modify the underlying Buffer 2018-03-20 16:38:15 -04:00
Ash Wilson
427460552d Don't register modifying commands for readonly TextEditors 2018-03-20 10:19:56 -04:00