Kevin Sawicki
4f2d935a1d
Reload grammar on path changed in TokenizedBuffer
2014-05-27 12:58:17 -07:00
Kevin Sawicki
b19126024a
💄
2014-05-27 12:58:17 -07:00
Kevin Sawicki
56eb1fc6e4
Reload grammar before emitting events
2014-05-27 12:58:17 -07:00
Kevin Sawicki
07a2a6710d
Reload grammar in editor when path changes
2014-05-27 12:58:17 -07:00
Nathan Sobo
6448258f4e
Add shims to support find-and-replace marker views
2014-05-27 12:11:01 -06:00
Maximilian Schüßler
7e5d554bd8
Fix example in editor-view.coffee
2014-05-25 21:27:21 +02:00
Kevin Sawicki
ac70bfc456
Don't parse line and column if path to open exists
...
This previously prevented file containing a colon from being open
from the command line.
Closes #2376
2014-05-23 15:32:55 -07:00
Kevin Sawicki
fd0f323666
Open directory path instead of project path
...
This ensures that the repository opened is always project’s
path instead of the potentially non-existent path or file
specified to Project::setPath
2014-05-23 15:05:04 -07:00
Nathan Sobo
0e31557abf
Only measure character widths when editor is visible
2014-05-23 15:59:44 -06:00
Nathan Sobo
5b149bd41a
Merge pull request #2370 from atom/ns-react-fix-scroll-corruption
...
Prevent React editor's scroll view from being auto-scrolled by Chromium
2014-05-23 12:54:15 -06:00
Corey Johnson
3784b77b95
Merge remote-tracking branch 'origin/master' into cj-paragraph-test
2014-05-23 09:23:30 -07:00
Corey Johnson
7f418e2de4
Add move by paragraph commands
2014-05-23 09:13:44 -07:00
karlin
64470a3c7d
add moveToBeginningOf{Next,Previous}Paragraph for cursor and wrappers for editor
2014-05-23 00:51:01 -04:00
Nathan Sobo
fae035731f
Prevent autoscrolling scroll-view when cursor is at end of longest line
...
If the longest line is longer than the width of the scroll view, we need
to allow 2px horizontally to prevent the hidden input from
autoscrolling.
2014-05-22 20:18:34 -06:00
Nathan Sobo
446a48ca00
Position hidden input at 0,0 unless cursor is focused
...
The editor's scroll view is getting autoscrolled when the editor is
focused, so we won't position the hidden input until after the editor
is focused, and will always return it to 0,0 when the editor is blurred.
2014-05-22 20:13:50 -06:00
Nathan Sobo
ce9b34c9eb
Warn when scroll view gets accidentally scrolled and fix it
...
I want this code to go away once we track down the causes of any
unwanted autoscrolling by the browser
2014-05-22 19:53:14 -06:00
Corey Johnson
d1ed176550
Merge pull request #2368 from atom/iz-scrollview-support-for-core-move-up-down
...
Support core:move-up and core:move-down in ScrollView
2014-05-22 16:41:50 -07:00
Nathan Sobo
9c066d93fa
Run react perf in scroll benchmark if NODE_ENV isn't production
2014-05-22 16:01:48 -06:00
Nathan Sobo
e754689014
Add displayName to ScrollbarComponent and ScrollbarCornerComponent
2014-05-22 16:01:48 -06:00
Ivan Zuzak
de96de2de1
Support core:move-up/down in ScrollView
...
Closes #1828
2014-05-22 23:58:50 +02:00
Kevin Sawicki
16df6a32d6
📝 Use TomDoc in Atom class
2014-05-22 14:06:17 -07:00
Kevin Sawicki
cdb6de05b3
Update broken Keymap class reference
2014-05-22 13:27:45 -07:00
Nathan Sobo
fe31d2d28a
Add scrolling benchmark to React editor
2014-05-22 13:25:47 -06:00
Nathan Sobo
875cfefd36
Merge branch 'master' into ns-ks-react-dont-measure-when-hidden
...
Conflicts:
spec/editor-component-spec.coffee
src/editor-component.coffee
src/editor-scroll-view-component.coffee
src/lines-component.coffee
2014-05-22 10:48:21 -06:00
Nathan Sobo
b6fb996ceb
Merge pull request #2327 from atom/ns-react-fork
...
Use Atom-specific fork of React allowing selection restoration opt out
2014-05-22 10:41:26 -06:00
Kevin Sawicki & Nathan Sobo
0951305962
Wire editor.lineHeight config value
2014-05-22 10:17:22 -06:00
Kevin Sawicki & Nathan Sobo
8ffcdad89a
Re-measure the line height in pixels when the CSS line-height changes
2014-05-22 10:17:21 -06:00
Kevin Sawicki & Nathan Sobo
9e3ce09658
Rename lineHeight to lineHeightInPixels to distinguish from CSS value
...
CSS has a line-height property with values like '1.3', but we also have
a measured pixel value for line height. It's important to keep these
separate conceptually.
2014-05-22 10:17:12 -06:00
Kevin Sawicki & Nathan Sobo
45eeee9aea
Ensure .lines div is always at least the height of the scroll view
...
This ensures that the wrap guide extends the entire height of the
editor.
2014-05-21 19:07:03 -06:00
Kevin Sawicki & Nathan Sobo
9cbc693c77
Avoid measuring lineHeight/defaultCharWidth on show unless needed
...
We only need to re-measure if the fontSize, fontFamily, or lineHeight
changed while the editor was hidden.
2014-05-21 17:35:57 -06:00
Kevin Sawicki & Nathan Sobo
ee9d4ab70e
Don't measure lineHeight/defaultCharWidth when editor is hidden
2014-05-21 17:15:47 -06:00
Kevin Sawicki & Nathan Sobo
68c3113b75
Call hide on the views instead of the jQuery collection
...
This ensures that views with custom ::hide methods can invoke special
behavior.
2014-05-21 17:11:36 -06:00
Nathan Sobo
65b1e13b83
Use Atom-specific fork of React allowing selection restoration opt out
...
This fork of React allows data-react-skip-selection-restoration to be
defined on input elements, skipping costly selection restoration that
occurs when the input element is focused during reconciliation.
2014-05-20 23:05:13 -06:00
probablycorey
746273a2ef
Merge remote-tracking branch 'origin/master' into cj-add-invisibles-to-react-editor
2014-05-20 16:30:18 -07:00
Nathan Sobo
778beba901
Remove editor-colors class from line numbers
2014-05-20 17:10:55 -06:00
Nathan Sobo
9278920093
Merge branch 'master' into cj-add-invisibles-to-react-editor
...
Conflicts:
src/editor-component.coffee
2014-05-20 17:03:14 -06:00
probablycorey
ece868c9de
Concat strings instead of joining an Array
2014-05-20 15:16:07 -07:00
Nathan Sobo
ac993680db
Remove stray logging
2014-05-20 15:27:28 -06:00
probablycorey
25e3ae0325
Re-render the lines when the showInvisible config option is triggered
2014-05-20 13:58:22 -07:00
Nathan Sobo
2ae7cba452
Don't blink cursors with CSS animation
...
It seems to create intermittent lags when moving the cursor and typing.
2014-05-20 14:04:59 -06:00
probablycorey
2f038cbe66
Update lines component when invisibles changes
2014-05-20 12:34:18 -07:00
probablycorey
6880368a79
Add soft wrap support to invisibles
2014-05-20 11:49:31 -07:00
probablycorey
1e6e804ebb
Use screen line count to determine renderedEndRow
2014-05-20 11:37:32 -07:00
Nathan Sobo
6fef8de63e
Merge pull request #2284 from pritambaral/react-paste
...
Ignore paste in react editor, Fixes #2186
2014-05-20 11:50:26 -06:00
probablycorey
c999a6e0e4
Show carriage return invisibles
2014-05-20 10:38:01 -07:00
Cheng Zhao
6fa6863244
Don't popup context menu with no items, fixes #2032 .
...
On OS X popuping an empty context menu would have no effect but on Linux
an empty menu container would still be showed.
2014-05-20 22:36:51 +08:00
Nathan Sobo
0ad26c337a
Don't use _.pluck when building TokenizedLines
2014-05-19 22:20:57 -06:00
Nathan Sobo
353eb27d2e
Update dataset screenRow of gutter nodes when updating them
2014-05-19 21:34:06 -06:00
Nathan Sobo
6edb0b7a3d
Delete dead method
2014-05-19 21:32:26 -06:00
Nathan Sobo
cd5f0c0047
Update the screenRow on the line element's dataset in ::updateLineNode
2014-05-19 21:32:26 -06:00