Commit Graph

539 Commits

Author SHA1 Message Date
Philip Schatz
3d22829104 🐛 documentation for TextEditor::indentationForBufferRow() 2016-09-29 14:23:17 -04:00
Lukas Geiger
498a56a603 Tildify path in title bar
This will use ~/ for the path to the home directory
2016-09-22 11:14:03 +02:00
Nathan Sobo
579e6b23cf Merge pull request #12426 from oggy/marker-count
Delegate TextEditor.getMarkerCount to default marker layer.
2016-08-20 14:19:44 -05:00
Antonio Scandurra
c667c77ff3 Copy auto{Width,Height} when copying an editor 2016-08-19 13:58:16 +02:00
Antonio Scandurra
1f4cd6e00d Merge branch 'master' into ns-fix-editor-auto-height
# Conflicts:
#	src/text-editor.coffee
2016-08-19 13:27:26 +02:00
Max Brunsfeld
26c9e5ee78 Set editor's tokenized buffer's tab length on its display layer when deserializing 2016-08-18 17:06:26 -07:00
Nathan Sobo
a264eaa18a Serialize TextEditor autoHeight and autoWidth properties 2016-08-18 14:03:44 -06:00
Max Brunsfeld
90b699f5cc Remove some text editor ivars that are redundant w/ display layer properties 2016-08-18 10:41:11 -07:00
Max Brunsfeld
bf839ab15e Reset display layer upon deserializing a text editor 2016-08-17 16:57:35 -07:00
Nathan Sobo
6a0b4d8fc0 Default autoWidth in getter method to match autoHeight 2016-08-17 15:52:51 -06:00
Nathan Sobo
13c00995d4 Return default value of true from TextEditor.getAutoHeight
When we need to check for unassigned in the deprecated code path, we
can just read the instance variable directly to avoid getting the
deafult.

Signed-off-by: Antonio Scandurra <as-cii@github.com>
2016-08-17 15:52:51 -06:00
Nathan Sobo
106621e161 Deprecate automatic assignment of autoHeight for text editors
Previously, we attempted to automatically determine whether the editor’s
height should be based on the editor’s content or the height of its
container. Unfortunately, DOM APIs are insufficient to make this
determination in a complete way, leading to unpredictable behavior.

This PR deprecates the automatic determination of this behavior. By
default, editors base their height on their content. If an editor has
an explicit height assigned via its style or is positioned absolute with
an explicit top and bottom, we disable the content-based autoHeight and
log a deprecation warning telling the user to assign autoHeight
explicitly.

This paves the way to add an autoWidth setting, which will default to
false.
2016-08-17 15:52:51 -06:00
Antonio Scandurra
683bf37907 Add autoWidth to TextEditor 2016-08-17 16:14:36 +02:00
Max Brunsfeld
c5a6e9c697 Merge branch 'master' into ns-mb-detangle-editor 2016-08-16 09:11:11 -07:00
Max Brunsfeld
4b0183d074 Remove extraneous TextEditor setter methods 2016-08-15 16:45:10 -07:00
Max Brunsfeld
0d099d2fd5 Serialize all TextEditor parameters needed for the DisplayLayer 2016-08-15 15:51:22 -07:00
George Ogata
dfbe2232a7 Delegate TextEditor.getMarkerCount to default marker layer. 2016-08-15 01:49:06 -04:00
Max Brunsfeld
bf644d1a6b Remove some unnecessary TextEditor accessor methods 2016-08-12 14:31:07 -07:00
Max Brunsfeld
a11a235ef1 Don't reset display layer twice in TextEditor constructor 2016-08-12 13:36:50 -07:00
Max Brunsfeld
65f385c0a4 Don't reset editor's display layer when setting identical invisibles 2016-08-12 12:21:03 -07:00
Max Brunsfeld
0a1834079f Rename getSoftWrapIndentLength -> getSoftWrapHangingIndentLength 2016-08-11 16:38:34 -07:00
Max Brunsfeld
684952458f Remove new TextEditor setters; just use update 2016-08-11 15:34:54 -07:00
Max Brunsfeld
fc16eeadca Use TextEditor::update in TextEditorRegistry 2016-08-11 14:09:17 -07:00
Max Brunsfeld
ef94a940a9 Make the TextEditor setters call update() 2016-08-11 13:52:57 -07:00
Max Brunsfeld
fb6b463818 Remove duplicate scrollPastEnd setter and getter 2016-08-11 12:14:11 -07:00
Max Brunsfeld
0c7750f560 🔥 ignoreInvisibles parameter to TextEditor
Now that the TextEditor doesn't depend on atom.config, showInvisibles
can always be configured independently of the config
2016-08-11 11:41:11 -07:00
Max Brunsfeld
11463ef00b Merge remote-tracking branch 'origin/as-introduce-editor-update' into ns-mb-detangle-editor 2016-08-11 11:36:48 -07:00
Antonio Scandurra
61a909b06e Remove config option editor.backUpBeforeSaving
After shipping #11828 Atom always creates a backup file in the
`~/.atom/recovery` directory, trying to restore it automatically via the
main process in case there is a hard crash on the renderer process. This
approach should be resilient enough to allow us to delete this config
option altogether.

We can still keep it for a while in text-buffer, in case we need to use
it again at some point, but it's probably fine to remove it from there
too at some point in the future.
2016-08-11 09:23:43 +02:00
Max Brunsfeld
09b1d402d5 📝 Fix typo in setAutoIndent{,OnPaste} docs 2016-08-10 13:28:06 -07:00
Max Brunsfeld
b97f317cd1 Remove fallbacks for scoped properties in TextEditor
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-08-09 15:20:00 -07:00
Max Brunsfeld
2c506840a5 📝 Document new editor configuration methods 2016-08-09 11:14:12 -07:00
Max Brunsfeld
ee2e18737e Fix maintenance of grammars for copied editors 2016-08-08 11:17:30 -07:00
Max Brunsfeld
1f34a8950a Don't use config for softWrapHangingIndent 2016-08-05 09:53:22 -07:00
Max Brunsfeld
ddfb124cb8 Merge branch 'master' into ns-mb-detangle-editor 2016-08-05 09:39:43 -07:00
Max Brunsfeld
43f34f73da Supply missing softWrapHangingIndent parameter to display layer 2016-08-02 16:20:23 -07:00
Max Brunsfeld
63a730253b Don't use config for scrollSensitivity in TextEditorComponent
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-27 15:35:56 -07:00
Max Brunsfeld
3f8b6138dc Don't use config in TextEditorPresenter
Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-27 14:56:36 -07:00
Max Brunsfeld
3d796df401 Stop using GrammarRegistry in TextEditor 2016-07-27 14:09:17 -07:00
Max Brunsfeld
455d3213ed Return token objects from tokensForScreenRow
Include the text of each token alongside its array of scopes.

Signed-off-by: Nathan Sobo <nathan@github.com>
2016-07-26 12:39:41 -07:00
Max Brunsfeld
c0cbb59666 Don't use config in TokenizedBuffer 2016-07-12 14:31:05 -07:00
Max Brunsfeld
5adb087ab1 Move config handling out of LanguageMode 2016-07-12 14:19:35 -07:00
Max Brunsfeld
58ec44f8ec Move handling of nonWordCharacters setting into TextEditorRegistry 2016-07-12 11:30:41 -07:00
Max Brunsfeld
5167dbca6f Move handling of undoGroupingInterval to TextEditorRegistry 2016-07-11 17:47:40 -07:00
Max Brunsfeld
9ab474a673 Move handling of scrollPastEnd setting to TextEditorRegistry 2016-07-11 17:41:06 -07:00
Max Brunsfeld
7a50aa9f9f Move handling of auto indent settings to TextEditorRegistry 2016-07-11 17:37:51 -07:00
Max Brunsfeld
6f764f86cf Move handling of backUpBeforeSaving to TextEditorRegistry 2016-07-11 17:16:41 -07:00
Max Brunsfeld
58e0f66a90 Supply default settings in TextEditor 2016-07-11 15:10:42 -07:00
Max Brunsfeld
596cc13f6a Don't use config in TextEditor::getSoftWrapColumn 2016-07-11 13:07:44 -07:00
Max Brunsfeld
eb97c61655 Remove .dispose calls for deleted subscriptions 2016-07-11 13:07:11 -07:00
Max Brunsfeld
5acab853cd Remove all config observation from text editor 2016-07-11 12:43:18 -07:00