Nathan Sobo
3eb7c9d767
Add LanguageMode::toggleLineCommentForBufferRow for toggling single rows
2014-01-20 11:14:27 -07:00
Nathan Sobo
ed93695d64
Add a foldable indicator for multi-line comments
2014-01-18 12:08:37 -07:00
Nathan Sobo
4db2ad53fd
Rename .fold class to .folded on line numbers in gutter
...
Using an adjective blends in better with '.foldable'
2014-01-18 11:35:22 -07:00
Nathan Sobo
99f025d5d6
Rename .fold-icon to .icon-right in gutter to make it multi-purpose
2014-01-17 16:59:50 -07:00
Nathan Sobo
a774c2ff08
🔫 unnecessary return statement
2014-01-17 15:46:49 -07:00
Nathan Sobo
fa6bce3085
Rename LanguageModel::isBufferRowFoldable to ::isFoldableAtBufferRow
...
It blends in better with the methods on Editor.
2014-01-17 15:19:07 -07:00
Nathan Sobo
b2dff15e51
Toggle folding upon 'mousedown' on a foldable line's fold-icon
2014-01-17 15:17:13 -07:00
Nathan Sobo
1a12a17b7a
Use actual markup for fold icon so we can determine when it's clicked
2014-01-17 14:55:06 -07:00
Nathan Sobo
8757e1f145
Add downward pointing chevrons next to foldable row numbers in gutter
2014-01-17 14:34:53 -07:00
Nathan Sobo
12ca214d6a
💄 Fix misleading variable name
2014-01-17 14:32:58 -07:00
Nathan Sobo
8e75831318
Rename LanguageMode::doesBufferRowStartFold to ::isBufferRowFoldable
2014-01-17 14:30:40 -07:00
Nathan Sobo
2f049b95a8
Use Delegator mixin to delegate to language mode
2014-01-17 14:07:56 -07:00
Nathan Sobo
926493f05c
Emit 'item-added' before setting the ::activeItem when adding first item
...
Fixes atom/tabs#11
2014-01-17 11:10:17 -07:00
probablycorey
4f82662263
Fix page up/page down keybindings
2014-01-17 08:28:45 -08:00
Cheng Zhao
dfa3d8a1c7
Temporarily workaround for slow net.connect, fixes #1429 .
2014-01-17 20:31:03 +08:00
Kevin Sawicki
f19d2d7369
Call selectLeft on editor
2014-01-16 16:00:20 -08:00
probablycorey
7f790137ed
Fix editor method name
2014-01-16 15:55:21 -08:00
probablycorey
c56dce0c80
Cache atom version
2014-01-16 14:07:20 -08:00
probablycorey
ec499e2bde
Remove version instance variable.
...
The version was being assigned to 1 causing getVersion to never check
app.getVersion for the actual version.
Fixes #1428
2014-01-16 12:39:20 -08:00
Nathan Sobo
fe2def8321
Merge remote-tracking branch 'origin/master' into ns-empty-panes
2014-01-16 11:16:00 -07:00
probablycorey
23d9f6e41f
Use actual indentation length when setting indentation for row.
...
Closes #1293
2014-01-16 09:27:26 -08:00
Nathan Sobo
649f0ac246
Merge branch 'master' into ns-empty-panes
...
Conflicts:
package.json
2014-01-16 10:21:59 -07:00
Cheng Zhao
b7ae12f86f
Merge branch 'master' into chrome31
...
Conflicts:
package.json
2014-01-16 23:42:22 +08:00
Kevin Sawicki
1006706cf6
Consistently order less cache import paths
2014-01-15 17:42:17 -08:00
Cheng Zhao
fcffcc83f9
Merge branch 'master' into chrome31
...
Conflicts:
package.json
vendor/apm
2014-01-16 09:11:34 +08:00
probablycorey
b620be7780
Fix cut, copy and paste key bindings
...
Closes #1425
2014-01-15 16:00:09 -08:00
Nathan Sobo
ccd86d91de
Make PaneContainer::activePaneItem behavior distinct until changed
...
If we switch from one empty active pane to another empty active pane,
there's no reason to emit a value from the activePaneItem behavior.
2014-01-15 16:08:36 -07:00
Nathan Sobo
5e14d44d6a
Destroy all pane models when workspace view is removed
2014-01-15 16:07:47 -07:00
Nathan Sobo
41dd4a386a
Restore PaneView::getContainer. Turns out it's actually public.
2014-01-15 16:07:47 -07:00
Nathan Sobo
9af4b14716
Never allow PaneContainer::root to be null
2014-01-15 16:07:47 -07:00
Nathan Sobo
aed9f18457
Accivate the first added pane item
2014-01-15 16:07:47 -07:00
Nathan Sobo
edf2fbe0e5
Make 'core:close' destroy the pane itself if it is empty
2014-01-15 16:07:47 -07:00
Nathan Sobo
ca71bf224b
Destroy the pane completely on 'pane:close' (not just its items)
2014-01-15 16:07:47 -07:00
Nathan Sobo
012363a785
Null guard item in ::destroyActiveItem
2014-01-15 16:07:47 -07:00
Nathan Sobo
1a48903f96
Only destroy empty panes on deserialization if config option is enabled
2014-01-15 16:07:47 -07:00
Nathan Sobo
44331d0ba6
Fix issues splitting panes with DOM events
...
* ::copyActiveItem guards against not having an active item
* The Pane constructor removes undefined items from params.items
2014-01-15 16:07:47 -07:00
Nathan Sobo
fe7c5b4bc1
Only destroy an empty panes if 'core.destroyEmptyPanes' is true
2014-01-15 16:07:47 -07:00
Nathan Sobo
1825af1309
Merge pull request #1415 from atom/ns-pane-model-specs
...
Move relevant pane specs from PaneView to Pane model
2014-01-15 15:06:43 -08:00
Nathan Sobo
b5947f5a56
Merge branch 'master' into ns-pane-model-specs
2014-01-15 15:54:49 -07:00
probablycorey
ac07cf3d9a
Merge remote-tracking branch 'origin/master' into cj-remove-editor-view-delegate-methods
...
Conflicts:
package.json
2014-01-15 13:52:42 -08:00
Nathan Sobo
d57e5f389d
Don't null out the model of a pane item view when removing it
...
Fixes #1422 (I think)
2014-01-15 14:20:30 -07:00
Cheng Zhao
2023aeef97
Use screen module to get screen's available size.
...
In Chrome31 the window.screen.availHeight and availWidth are sometimes
0, this is a workaround of this bug.
2014-01-15 12:49:22 +08:00
Nathan Sobo
dd0ae8a8ea
Don't remove PaneViews when their model is destroyed
...
They will be removed by their parent PaneContainerView or PaneAxisView,
and removing them in the previous way circumvented some of our focus
preservation logic.
2014-01-14 20:09:14 -07:00
Nathan Sobo
c0c2d797b1
Add some API documentation
2014-01-14 14:44:27 -07:00
Nathan Sobo
c350285044
Move Workspace and PaneContainer serialization to the model layer
...
The views are now stateless. You just construct them with a model to
deserialize.
2014-01-14 11:38:27 -07:00
Nathan Sobo
4a7b43f609
Write focusNext/PreviousPane in terms of activateNext/PreviousPane
...
"Activate" is the model level equivalent of focus.
2014-01-14 11:15:14 -07:00
Nathan Sobo
0d66c68fe8
Add delegator to model for PaneContainerView::saveAll
2014-01-14 11:12:08 -07:00
Nathan Sobo
a1d540d288
Revert WorkspaceView::getActivePane. It needs to return a PaneView.
2014-01-14 11:02:36 -07:00
Nathan Sobo
af4034ba39
Move WorkspaceView::destroyActivePaneItem to the model
2014-01-14 10:58:35 -07:00
Nathan Sobo
89cbd6b834
Move PaneContainerView::saveAll to the model
2014-01-14 10:58:35 -07:00
