Ben Ogle
43baee5abd
Merge pull request #1322 from atom/bo-fix-tabs-and-soft-wrap
...
Dont re-atomicize atomic tokens
2013-12-16 15:56:22 -08:00
Ben Ogle
b959fc0a6a
use @
2013-12-16 15:46:07 -08:00
Ben Ogle
77b5fd47ca
Dont re-atomicize atomic tokens.
...
Fixes #1318
2013-12-16 15:34:27 -08:00
Kevin Sawicki
9cdc15b161
Guard against no other focusable elements
...
This previously occurred in areas we all the elements had a -1 tabindex
or were disabled.
2013-12-16 13:54:59 -08:00
Kevin Sawicki
010931391e
Use event.target
2013-12-16 12:14:41 -08:00
Kevin Sawicki
eaf6aba943
Return true from event handler
2013-12-16 12:12:14 -08:00
Kevin Sawicki
d60d710325
Inline sendActionToFirstResponder
2013-12-16 12:11:19 -08:00
Kevin Sawicki
bb1bcc233a
Handle native commands in render process
...
This fixes copy, paste, undo, redo for elements with a native-key-bindings
class by forwarding to the menu's first responder from the render process.
2013-12-16 12:06:43 -08:00
Ben Ogle
c6e96a6188
Merge pull request #1308 from atom/bo-common-functions-up-a-level
...
Common core commands to workspaceView
2013-12-16 11:12:44 -08:00
Kevin Sawicki
6a7e4c30fb
🐎 Memoize version to prevent future IPC calls
2013-12-13 14:49:23 -08:00
Kevin Sawicki
70f3527123
Expose shell load time render process for metrics
2013-12-13 12:15:45 -08:00
Kevin Sawicki
87e325dce1
Set body's visibility to hidden when unloading
...
Previously the display was changed to none via $.hide() which accidentally
affected the ability of package's to serialize DOM properties such as
scrollTop since the value would always be zero when the display was none.
The goal here is to just prevent a flicker when refreshing the
editor window and setting visibility to hidden still accomplishes this.
2013-12-12 18:05:36 -08:00
Ben Ogle
a25812dca7
Move cmd-s and cmd-S to workspaceView
2013-12-12 17:50:15 -08:00
Ben Ogle
1f9a7599b7
cmd-w works anywhere in the editor
2013-12-12 17:50:15 -08:00
Nathan Sobo
75cee638bc
Protect from exceptions when attaching editor views w/ dead editors
...
Addresses #1306
We still need to know why this is happening, so I left an exception in
non-release builds. Since the pane system is about to change a lot I
think this is good enough for now.
2013-12-12 16:41:35 -08:00
probablycorey
90f3726c5c
Fix window specs
2013-12-12 15:10:01 -08:00
probablycorey
58bf19cc83
Fix syntax error
2013-12-12 14:00:21 -08:00
probablycorey
f439b04978
Update tree-view and find-and-replace packages
2013-12-12 13:37:56 -08:00
probablycorey
132194337e
Merge remote-tracking branch 'origin/master' into cj-deleted-files-not-modified
2013-12-12 11:00:17 -08:00
Ben Ogle
4ffa5bb90e
Make this fn private.
2013-12-12 10:34:08 -08:00
Ben Ogle
7111961929
Move function into setTextViaDiff()
2013-12-12 10:34:08 -08:00
Ben Ogle
5d46d7a881
💄
2013-12-12 10:34:08 -08:00
Ben Ogle
8d1d64d9d3
bufferRow -> row
2013-12-12 10:34:08 -08:00
Ben Ogle
60498616b7
numberLines -> lineCount
2013-12-12 10:34:08 -08:00
Ben Ogle
ed745d2072
Remove log lines
2013-12-12 10:34:08 -08:00
Ben Ogle
1f69963982
Apply text to buffer via diff on reload
...
Previously, it would blindly read from disk on reload, and set the text
into the editor. This was problematic as it would mess with markers and
folds. No longer.
Fixes #1285 and fixes atom/bookmarks#3
2013-12-12 10:34:08 -08:00
probablycorey
2d5b04579f
Merge branch 'master' into cj-deleted-files-not-modified
...
Conflicts:
src/pane.coffee
2013-12-12 09:57:28 -08:00
Kevin Sawicki
9fbfeb970b
Remove mixins already added by Model superclass
2013-12-12 09:04:16 -08:00
Nathan Sobo
b9b8c61c11
🚱 Properly remove items from pane's state document
...
Fixes #1299 .
This updates Pane::removeItemAtIndex to call Array::splice with the
index to be removed instead of Array::remove, which was changed to take
the *object* to be remove rather than an index. Oops.
2013-12-11 21:39:38 -08:00
Kevin Sawicki
865d94d758
Add dev mode icon to status bar
...
Skull colliding with tabs was too much to handle.
Red square in status bar is the new indicator.
2013-12-11 18:57:07 -08:00
Kevin Sawicki
29b85a1bb9
Clear the goal column when the cursor moves
...
Previously it was only cleared when changing the position explicitly
and not as a result of the underlying marker changing such as during a
text insertion.
Closes #1295
2013-12-11 18:02:52 -08:00
Kevin Sawicki
dda65d82c3
Remove unused guid require
2013-12-11 17:49:31 -08:00
Kevin Sawicki
56de32f433
📝 Mention packages instead of extension
2013-12-11 17:23:23 -08:00
Kevin Sawicki
3cb751723d
Register editor with project when deserializing
2013-12-11 17:18:03 -08:00
Nathan Sobo
0b5155f496
Set telepath.devMode to true when not on an official release
...
This will enable assertions inside of telepath to help us diagnose
atom/telepath#7 . Otherwise, the issue *should* be covered over for end
users.
2013-12-11 14:47:52 -08:00
Nathan Sobo
8a8df8d6cb
Add Atom::isReleasedVersion, which determines if the version is a SHA
2013-12-11 12:28:20 -08:00
Nathan Sobo
6bb4eaee93
Merge branch 'ns-teleditor'
2013-12-11 11:17:45 -08:00
Nathan Sobo
7710845cdc
Use property accessors instead of accessing state directly
2013-12-11 11:10:43 -08:00
Nathan Sobo
8471ffed29
Observe scroll* behaviors instead of the entire state document
2013-12-11 11:10:06 -08:00
Nathan Sobo
e5bf70544e
Document methods
2013-12-11 11:02:56 -08:00
Nathan Sobo
e275b6c414
Merge remote-tracking branch 'origin/master' into ns-reopen-uris
2013-12-10 19:13:21 -08:00
Nathan Sobo
f3cdb6e0a2
Merge remote-tracking branch 'origin/master' into ns-teleditor
2013-12-10 19:10:09 -08:00
Nathan Sobo
425c076221
Make Editor a telepath.Model subclass
2013-12-10 17:32:34 -08:00
Nathan Sobo
18a712a1f7
Reopen closed pane items in workspace – by uri instead of deserializing
...
Serializing and deserializing closed pane items was turning into a pain
with the new telepath changes that are phasing out this kind of on the
fly serialization. Reopening by uri saves memory and simplifies panes
enormously. If we want non-uri reopening we can revisit it later when
telepath models are better integrated.
2013-12-10 17:19:44 -08:00
probablycorey
4bfcdf4d5b
Remove unmodified editors from pane when the buffer is deleted
2013-12-10 17:08:07 -08:00
probablycorey
201717a9aa
Remove duplicate destroy
...
Telepath now emits the 'destroy' event
2013-12-10 17:04:46 -08:00
probablycorey
24c84fe09c
Merge remote-tracking branch 'origin/master' into cj-deleted-files-not-modified
2013-12-10 14:46:26 -08:00
probablycorey
a3eb76d630
💄
2013-12-10 13:52:42 -08:00
probablycorey
8ffa8fed12
Always use Pane::addItem when adding items.
2013-12-10 13:50:51 -08:00
Ben Ogle
43bf47fa26
Upgrade to underscore-plus@0.4.0
2013-12-10 11:47:53 -08:00
