Ben Ogle
48c05210fa
Remove specs from text-editor-component
2015-04-01 17:41:00 -07:00
Ben Ogle
bed09cf0ef
Presenter positions overlays when the overlay doesn’t have a size
...
Fix presenter specs
2015-04-01 17:41:00 -07:00
Ben Ogle
77139104fd
Remove getOverlayDimensions
...
No longer needed
2015-04-01 17:41:00 -07:00
Ben Ogle
3adc646a79
Remove the horribleUpdateMethod
2015-04-01 17:41:00 -07:00
Ben Ogle
32572c0106
Add ViewRegistry::pollAfterNextUpdate
...
Closes #6196
2015-04-01 17:41:00 -07:00
Ben Ogle
b0794bbb68
Move the overlay calculation into the presenter.
2015-04-01 17:40:59 -07:00
Ben Ogle
c62f06af9d
Cache the overlay dimensions in the presenter
2015-04-01 17:40:59 -07:00
Ben Ogle
0fa03f15b6
Update overlay rendering
2015-04-01 17:40:59 -07:00
Ben Ogle
6b5a74e3b6
Update specs for overlay rendering
2015-04-01 17:40:59 -07:00
Ben Ogle
8749db30cf
Add OverlayManager to the TextEditorComponent
2015-04-01 17:40:59 -07:00
Ben Ogle
db35022d0e
Remove OverlayManager from the LinesComponent
2015-04-01 17:40:59 -07:00
Mert Kahyaoğlu
33faef2499
remove duplicate switch case
2015-04-01 20:34:59 +03:00
Ben Ogle
72aa0524c4
Merge pull request #6200 from mertkahyaoglu/master
...
minor changes in decoration.coffee
2015-04-01 08:31:57 -07:00
Mert Kahyaoğlu
93e4b061fa
minor changes in decoration.coffee
2015-04-01 16:39:51 +03:00
Nikolaus Wittenstein
5a3f2035a1
Replace skipAtomicTokens with clip
...
When clipping a screen position, callers used to have to pick between
clipping to the left edge or the right edge when the position was in the
middle of an atomic token. This change allows them to choose the closest
edge, and makes this the default.
This makes selecting hard tabs (or any other atomic tokens) work in a
similar manner as in other text editors; that is, when clicking near
the middle of a tab, the insertion point will move to the closest edge
rather than the left edge.
2015-03-29 19:43:25 -04:00
Nikolaus Wittenstein
372fb49c88
TokenizedLine::screenColumnForBufferColumn calculates more accurately
...
screenColumnForBufferColumn used to break only if the current column
was strictly greater than the target column. This commit changes it so
it breaks when greater or equal, which is how bufferColumnForScreenColumn
works.
This also adds some unit tests for screenColumnForBufferColumn's
interactions with hard tab characters.
2015-03-29 19:43:25 -04:00
Nikolaus Wittenstein
3551780cdf
Marker::setHead/TailScreenPosition no longer clip unnecessarily
...
DisplayBuffer::bufferPositionForScreenPosition calls clipScreenPosition
first thing, meaning that Marker::setHead/TailScreenPosition don't need
to call clipScreenPosition before calling bufferPositionForScreenPosition.
2015-03-29 19:43:25 -04:00
Max Brunsfeld
230eb12a8a
Fix double autoscroll when moving cursor
2015-03-27 10:27:24 -07:00
Kevin Sawicki
c12f94907d
Remove grim.deprecate override
2015-03-26 16:36:00 -07:00
Nathan Sobo
127e0fbf6b
Merge pull request #6114 from atom/mb-ns-fix-autoscroll
...
Fix autoscroll on undo
2015-03-26 17:34:39 -06:00
Nathan Sobo
ae4f7f6170
Explicitly autoscroll when needed
...
Rather than when the selection’s marker changes. This is simpler than
suppressing autoscroll via state when we don’t want it. It also captures
the intent to autoscroll when attempting to move the cursor at the
beginning or end of the document.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-03-26 16:48:24 -06:00
Nathan Sobo
99c437ccec
Allow autoscroll override option in cursor/selection methods
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-03-26 16:48:21 -06:00
Kevin Sawicki
a70be30ee7
🎨
2015-03-26 14:37:30 -07:00
Kevin Sawicki
14d1fc2269
Merge pull request #5898 from basarat/master
...
Transpile all .ts files
2015-03-26 14:33:04 -07:00
Nathan Sobo
10458a5b45
Always autoscroll when the range of the last selection changes
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-03-26 15:30:53 -06:00
Kevin Sawicki
45afc9eb46
Handle EISDIR save errors
...
Closes #6100
2015-03-26 13:29:30 -07:00
Max Brunsfeld
2f5d975338
Remove autoscroll-related legacy editor view support
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-03-26 11:12:37 -07:00
Kevin Sawicki
27ffac5f1a
Set less property on caught error
2015-03-24 13:17:57 -07:00
Kevin Sawicki
40b4e36c09
Add custom formatting for Less errors
2015-03-24 13:17:56 -07:00
Basarat Syed
6f1b061dac
Added TypeScript to the compile-cache
2015-03-24 18:05:30 +11:00
Michael Bolin
14316b1cd7
Add Repository::getType().
...
For `GitRepository`, this will return `"git"`.
2015-03-23 15:38:38 -07:00
Kevin Sawicki
11a5b71fb3
Merge pull request #6047 from postcasio/project-deprecations
...
Fix deprecated calls and recommendations in deprecated methods
2015-03-23 09:24:07 -07:00
postcasio
c4ae567e8f
Fix deprecated calls and recommendations in deprecated methods
2015-03-20 09:22:02 +00:00
Kevin Sawicki
ec0681ed36
Merge pull request #6038 from atom/ks-remove-unwanted-loop-returns
...
Remove unwanted loop returns
2015-03-19 14:16:26 -07:00
Kevin Sawicki
576e00fb93
Keep returning array from TextEditor::mutateSelectedText
2015-03-19 11:57:16 -07:00
Kevin Sawicki
9f31afcbc9
Add explicit return after while loop
2015-03-19 11:48:40 -07:00
Kevin Sawicki
23eacc1e58
Add explicit return after for loop
2015-03-19 11:48:40 -07:00
Kevin Sawicki
a9803d3c4d
Add explicit return after for loop
2015-03-19 11:48:40 -07:00
Kevin Sawicki
d9a5aff919
Add explicit return after for loop
2015-03-19 11:48:40 -07:00
Kevin Sawicki
590a4b0fd5
Add explicit return after for loop
2015-03-19 11:48:40 -07:00
Kevin Sawicki
f728bc7aec
Add explicit returns to browser process classes
2015-03-19 11:48:40 -07:00
Nathan Sobo
6345799cf3
Revert "Don't soft-wrap on indentation"
2015-03-19 12:47:58 -06:00
Jessica Lord
390e95e220
Merge branch 'master' into jlks-missing-services-fix
2015-03-19 10:19:56 -07:00
Antonio Scandurra
0e0eeb3426
🔥 Delete TokenizedLine#isColumnOutsideIndentation
2015-03-19 12:23:10 +01:00
Antonio Scandurra
03b526a76b
🎨 Use only @firstNonWhitespaceIndex
2015-03-19 11:52:10 +01:00
Antonio Scandurra
56020b11b0
🐛 Avoid soft-wrapping on indentation
2015-03-19 11:36:55 +01:00
Basarat Syed
c2f258c679
Addressed code review
2015-03-19 11:45:13 +11:00
Jessica Lord
a787242e7a
check that services method exists
...
Signed-off-by: Kevin Sawicki <kevin@github.com >
2015-03-18 15:37:16 -07:00
Nathan Sobo
609a661174
Merge pull request #6010 from atom/as-soft-wrap-hanging-indent
...
Soft wrap hanging indentation spaces
2015-03-18 11:39:27 -06:00
Antonio Scandurra
522e82ebf1
🎨 Refactor buildSoftWrapIndentationTokens
...
...as suggested by @nathansobo ✨
2015-03-18 18:07:07 +01:00
