Commit Graph

300 Commits

Author SHA1 Message Date
Indrek Ardel
55f3311c01 Remove unused variables 2016-09-26 20:52:13 +03:00
Max Brunsfeld
920f62a76a Merge pull request #11216 from ypresto/speedup-config-setdefaults
🐎 wrap loop of config.setDefaults() in transact()
2016-07-25 10:29:35 -07:00
Yuya Tanaka
71e7d32916 🐎 Transact setSchema config changes 2016-07-25 07:49:04 +09:00
Lee Dohm
c7e3b0c728 📝 Update old docs links to point to Flight Manual 2016-06-15 08:57:27 -07:00
Mihail Bodrov
d602655708 replace _.extend in favore of Object.assign 2016-05-20 01:27:27 +03:00
Yuya Tanaka
6d0c708a7b 🐎 wrap loop of setDefaults in transact 2016-03-20 14:54:22 +09:00
Jonathan Willis
c849216084 Config: Added documentation for order key in config. 2016-02-29 14:49:19 -05:00
Lee Dohm
22d332a8d9 Change object section heading to be more descriptive 2016-02-03 16:46:40 -08:00
Lee Dohm
cfca20db79 Merge pull request #10552 from dirk-thomas/patch-1
improve docs about grouped settings
2016-02-03 16:44:45 -08:00
Ben Ogle
8acb742c30 Merge pull request #7916 from oggy/descriptive-enums
Support descriptions for enum values in config.
2016-01-26 14:45:00 -08:00
Dirk Thomas
13f0987ede improve docs about grouped settings
See https://github.com/atom/settings-view/pull/698#issuecomment-171725215
2016-01-22 19:46:51 -08:00
Chen Shen
6c0643b4fa address comments 2015-12-15 17:20:57 -08:00
Chen Shen
d227d8b646 Add config to disable autoupdate, revert previous build option 2015-12-15 17:20:57 -08:00
Dirk Thomas
fbbcdbf518 order keys in config.cson alphabetically 2015-12-07 09:54:18 -08:00
Ross Allen
aac52b7020 Correct config.coffee doc references to scope
The scope selector is referred to with the key `scope` on the options
object, not `scopeDescriptor` as the current docs claim. Reference
`scope` correctly.

Mark `options` as optional for `::observe` because the arguments
collection is checked for length, and a length of 2 assumes the second
argument is `callback`. `options` is actually optional.
2015-11-25 09:44:20 -08:00
Nathan Sobo
e572763cf7 Remove unnecessary fat arrow 2015-11-18 22:21:27 -08:00
Antonio Scandurra
b895baacbf Make transactAsync private 2015-11-11 18:30:06 +01:00
Antonio Scandurra
8c3c2dfa8d 🎨 2015-11-11 09:59:41 +01:00
Antonio Scandurra
c85088fb46 🎨 2015-11-11 09:58:07 +01:00
Antonio Scandurra
68ea20a705 📝 2015-11-11 09:56:25 +01:00
Antonio Scandurra
38d713379f 🎨 Introduce Config::transactAsync 2015-11-11 09:55:20 +01:00
Antonio Scandurra
d4a67a7db5 🎨 Call it ::beginTransaction 2015-11-10 11:42:39 +01:00
Antonio Scandurra
e437234c58 Transact on both async and sync package activation 2015-11-10 11:05:31 +01:00
Yakira C. Bristol
908316ec72 Remove keyPath as a possible return value on the event object for onDidChange in config.coffee
The value is never returned on the object so the documention was updated to reflect that
2015-10-27 18:20:37 -04:00
Nathan Sobo
dc44d11a2c Don’t load/save config if enablePersistence option is false 2015-10-14 20:05:06 -06:00
Max Brunsfeld
32780e2823 Merge branch 'master' into ns-alternative-test-env
Conflicts:
	package.json
2015-10-14 14:12:42 -07:00
Antonio Scandurra
b25d3e944b Parameterize configDirPath and move config.load in ctor 2015-10-14 12:41:36 +02:00
George Ogata
790ea8e6f2 Support descriptions for enum values in config.
The enum property may now specify options as a list of {value:,
description:} objects.
2015-10-14 01:53:58 -04:00
Max Brunsfeld
47961a8e6b Fix setting default values in config 2015-10-13 11:00:53 -07:00
Nathan Sobo
75fbeab8b4 🎨 2015-10-07 15:25:01 -05:00
Nathan Sobo
88d80b1c97 Assign config in Atom environment constructor 2015-10-07 15:24:51 -05:00
Max Brunsfeld
d55398b77b Use key-path-helpers module instead of underscore-plus 2015-09-28 17:27:15 -07:00
Thomas Johansen
4914c15289 🔥 Remove Config deprecations 2015-09-22 10:37:05 -06:00
Jeremy Ramin
9a0d657d52 Adds deepDefaults to config
Took at the deepExtend in the atom/underscore-plus repo and modified it
to become a deepDefaults method. Using this instead to see if it fixes
the failing specs.
2015-08-22 23:03:19 -07:00
Jeremy Ramin
85800f6d00 Fix method typo 2015-08-22 21:16:32 -07:00
Jeremy Ebneyamin
f2c9688b43 Fix config.get for schemas containing objects
The config.get method would not return the default values for the
properties in objects. Now with _.deepExtends, the default values are
the base while any new values overwrite the defaults. This way all
default values appear, including those nested in an object. This fixes
atom/settings-view#386 and fixes atom/settings-view#518.
2015-08-22 19:44:17 -07:00
Lee Dohm
bb0dc68e40 📝 Add docs for Markdown formatting of config descriptions
Related to atom/settings-view#635
2015-08-19 07:48:15 -07:00
Max Brunsfeld
5f620fb739 Config::getSchema - use null to represent inaccessible key path 2015-08-12 16:52:25 -07:00
Max Brunsfeld
fbd684926e Config - Support additionalProperties field of object schemas 2015-07-30 18:28:41 -07:00
Max Brunsfeld
84f72c880a Config - don't allow setting key-paths inside of strings, arrays, etc 2015-07-30 18:28:06 -07:00
Ivan Zuzak
2d7691c19a Fix config.set scope selector example 2015-07-13 06:51:01 -07:00
Kevin Sawicki
66620f8510 Add TODO comment 2015-06-01 13:32:38 -07:00
Kevin Sawicki
703eaac7ca Keep around atom.config.unobserve no-op 2015-06-01 13:32:03 -07:00
Nathan Sobo
e723b26eb0 Add maximumLength schema enforcer for strings 2015-06-01 18:45:38 +02:00
Nathan Sobo
d1c44dcb54 Never load config settings from disk when a save is pending
Fixes #5771

We load the user’s settings from disk when we detect a change to their
config.cson file. However, if there’s a save pending, doing this will
end up blowing away the values we intend to save.
2015-04-20 12:12:05 -06:00
Kevin Sawicki
4160a8c239 Merge pull request #6230 from mnquintana/coffeelint-plus
Lint for more styleguide errors
2015-04-08 12:07:23 -07:00
Kevin Sawicki
baae0c0ac6 Only include emissary Emitter in deprecation mode 2015-04-07 14:40:27 -07:00
Machiste Quintana
2bb2022b5b 👕 2015-04-07 00:05:19 -04:00
Machiste Quintana
5d2392ea67 👕 Fix new coffeelint errors 2015-04-06 23:59:54 -04:00
Kevin Sawicki
7d592c8b78 includeDeprecations -> includeDeprecatedAPIs 2015-04-03 11:29:16 -07:00