Nathan Sobo
f139992585
Avoid infinite recursion in Error.prepareStackTrace
...
Previously, prepareStackTraceWithStackAssignment could end up calling
itself when third-party code assigned Error.prepareStackTrace back
to its original value. Now, we short-circuit this process if the
rawStack property has already been assigned.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-11-30 10:51:21 -08:00
Max Brunsfeld
a36fc301f9
Merge branch 'master' into mb-deprecate-load-time-package-code
2015-11-30 10:51:14 -08:00
Max Brunsfeld
228e67838c
Suppress false coffeelint error
2015-11-30 10:51:03 -08:00
Max Brunsfeld
d058814957
Merge remote-tracking branch 'origin/master' into mb-deprecate-load-time-package-code
...
Conflicts:
package.json
2015-11-30 10:20:31 -08:00
joshaber
3a06953820
Merge branch 'master' into dh-async-repo
2015-11-30 11:44:20 -05:00
Antonio Scandurra
526a97562e
Include block decorations as a separate object on presenter's state
2015-11-30 15:05:15 +01:00
Antonio Scandurra
8a54a2c15b
Use a boolean in each line state object
2015-11-30 14:44:58 +01:00
Antonio Scandurra
539a5b0ae7
🐎 Do as little pixel conversion as possible
...
We desperately need a tree-based data structure. 😢
2015-11-30 14:34:16 +01:00
Antonio Scandurra
b998e7f2d9
🐎 Incremental updates for block decorations
2015-11-30 14:03:45 +01:00
Antonio Scandurra
0159d5c31e
🎨
2015-11-27 16:58:08 +01:00
Antonio Scandurra
6ad21307cc
Provide blockDecorationsHeight for each line number
2015-11-27 16:27:01 +01:00
Antonio Scandurra
6365c86992
Include blockDecorations inside each line's state
2015-11-27 14:32:01 +01:00
Antonio Scandurra
e1e06580c1
Move position conversion in LinesYardstick
2015-11-27 12:47:47 +01:00
Antonio Scandurra
0b5638f749
Make sure tile positions are computed correctly
2015-11-27 10:47:25 +01:00
Antonio Scandurra
a9cb1bda8d
Use ::positionForRow in ::updateTilesState
...
The algorithm is still super sloooow 🐌 , but we'll fix that in a later
commit.
2015-11-27 10:16:38 +01:00
Antonio Scandurra
02651b7a58
🎨 Rename to ::setBlockDecorationDimensions
2015-11-26 16:10:08 +01:00
Antonio Scandurra
96863eef1c
Ensure content scrollHeight takes block decorations into account
...
Seems like all these properties in the presenter's state share a common
contract, which we should probably extract. It could also mean there's an
underlying design problem, because we are testing two dimensions of the same
behavior in a single spec.
2015-11-26 15:44:59 +01:00
Antonio Scandurra
30da4bdb0c
Ensure gutter scroll height takes block decorations into account
2015-11-26 15:43:34 +01:00
Antonio Scandurra
89d9a2ce83
🎨 Create block decorations in TextEditor
...
This is just an experiment, although I like that we can hide some information
(irrelevant to the user) behind a clean API.
2015-11-26 15:40:08 +01:00
Antonio Scandurra
c8254566ef
Change verticalScrollbar's height according to block decorations
2015-11-26 15:34:45 +01:00
Antonio Scandurra
5dfd765bcf
Do not override user-defined keymaps when reloading packages
2015-11-26 10:39:47 +01:00
Wliu
71574d785c
Merge remote-tracking branch 'master' into wl-electron-35
...
# Conflicts:
# package.json
# src/application-delegate.coffee
2015-11-25 18:44:40 -05:00
Nathan Sobo
8978691831
Merge pull request #9773 from atom/mb-ns-prepare-stack-trace-fixes
...
Allow Error.prepareStackTrace to be temporarily reassigned
2015-11-24 11:59:53 -07:00
Antonio Scandurra
c061b27076
✅
2015-11-24 17:36:44 +01:00
Antonio Scandurra
9376738918
Make spec async because of Promise-based API
2015-11-24 12:28:31 +01:00
Max Brunsfeld
327cf6997b
Remember which packages use atom APIs at main module load time
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-11-23 17:35:38 -08:00
Max Brunsfeld
24938c0361
Defer loading view providers until activation or deserializer use
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-11-23 16:28:08 -08:00
Max Brunsfeld
d6e5ea8564
Defer requiring packages' main modules if they use new package.json fields
2015-11-23 16:05:32 -08:00
Max Brunsfeld
2d29fd6e79
Load config schemas from packages' package.json files
2015-11-23 15:53:26 -08:00
Max Brunsfeld
4bc46db355
Still assign error's raw stack when prepareStackTrace is overridden
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-11-23 15:30:11 -08:00
Max Brunsfeld
4616b426b0
Allow Error.prepareStackTrace to be temporarily reassigned
...
Fixes https://github.com/atom/atom/issues/9660
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-11-23 15:22:15 -08:00
Douwe Maan
b11d0c2585
Use em-dash in window title and exclude app name on OS X
2015-11-21 14:09:00 +01:00
Max Brunsfeld
30b3cb249e
Merge pull request #9636 from DouweM/unique-title
...
Use unique text editor title in window and tab titles
2015-11-20 16:55:38 -08:00
Nathan Sobo
dae4539fbe
Merge branch 'stable' into beta
2015-11-20 10:46:15 -07:00
Antonio Scandurra
cbfee4e809
🐛 Compute content width when the longest row is the first one
2015-11-20 10:45:16 -07:00
Antonio Scandurra
e5165814e6
Return early in FakeLinesYardstick for unrendered rows
...
This allows us to have a more consistent behavior with the real LinesYardstick.
2015-11-20 10:45:07 -07:00
Nathan Sobo
3e22d9f7a2
Merge PR #9607 with a small change
2015-11-20 10:41:22 -07:00
Nathan Sobo
704da43800
Prevent spec from closing window
2015-11-20 10:34:05 -07:00
Antonio Scandurra
a546005c65
Merge pull request #9709 from atom/as-fix-longest-screen-row-issue
...
Compute content width when the longest row is the first one
2015-11-20 09:24:33 -08:00
Antonio Scandurra
93481c8a0d
Move ::isTextEditor down into Workspace
2015-11-19 17:56:53 -08:00
Antonio Scandurra
85ee586e2e
✅ More specs
2015-11-19 17:30:33 -08:00
Wliu
577b85e76c
Merge remote-tracking branch 'refs/remotes/origin/master' into wl-electron-35
2015-11-19 20:20:24 -05:00
Antonio Scandurra
d427091b49
✅ Write specs for ::isTextEditor
2015-11-19 17:04:18 -08:00
Max Brunsfeld
cb2b068d77
Load view providers from files specified in package.json
2015-11-19 16:58:20 -08:00
Antonio Scandurra
0218431c62
🐛 Compute content width when the longest row is the first one
2015-11-19 16:38:20 -08:00
Antonio Scandurra
ff08642d3b
Return early in FakeLinesYardstick for unrendered rows
...
This allows us to have a more consistent behavior with the real LinesYardstick.
2015-11-19 16:32:39 -08:00
Max Brunsfeld
91b651e86c
Make model constructor argument to addViewProvider optional
2015-11-19 15:54:47 -08:00
Max Brunsfeld
a0a402c3f8
Remove 'atom' prefix from deserializers package.json key
2015-11-19 14:12:03 -08:00
Nathan Sobo
b04c26ba30
Discard highlights that end above the visible row range
...
Fixes #9628
2015-11-18 21:32:05 -08:00
Wliu
5fca7b6582
More ipc-renderer fixes
2015-11-18 21:20:45 -05:00
