Commit Graph

8833 Commits

Author SHA1 Message Date
David Wilson
4c47249be0 Use correct fontWeight value in ThemeManager spec
In Chrome 66+ it seems that getComputedStyle().fontWeight returns the computed
numeric value of the style instead of the original descriptive name.  We now
look for value '700' which corresponds to the value of 'bold'.
2019-05-21 14:56:41 -04:00
Nathan Sobo
3da827b8b0 Revert "Merge pull request #18916 from atom/electron-3.1"
This reverts commit dc39210cc2, reversing
changes made to e18559f01c.
2019-05-20 16:32:09 -06:00
Antonio Scandurra
dc39210cc2 Merge pull request #18916 from atom/electron-3.1
⬆️ Electron 3 (Take Two)
2019-05-20 15:20:12 +02:00
Antonio Scandurra
c8b96ea899 Use the new getActivatePromise method in TextEditorRegistry tests 2019-05-18 17:01:08 +02:00
Nathan Sobo
770b8fdcf8 Revert "Merge pull request #19244 from atom/ns/notify"
This reverts commit b2ecabd527, reversing
changes made to c3bf95194a.
2019-05-17 04:10:17 -06:00
Rafael Oleza
5c7deea8e1 Asyncify spec 2019-05-16 13:05:01 +02:00
Nathan Sobo
61c52e3185 Decaffeinate default-directory-searcher.coffee and its spec
Co-Authored-By: Rafael Oleza <rafeca@users.noreply.github.com>
2019-05-16 12:54:21 +02:00
Rafael Oleza
46997eae83 Merge branch 'master' into electron-3.1 2019-05-16 11:22:02 +02:00
Nathan Sobo
4e5e2e5293 Merge pull request #19336 from atom/ns/allow-quote-selectors
Allow escaped quote literals in the SyntaxScopeMap
2019-05-15 08:47:03 -06:00
Rafael Oleza
e01fe4ca90 Replace new Buffer() with Buffer.from()
This removes deprecation warnings on Node >=10

Co-Authored-By: Antonio Scandurra <as-cii@github.com>
2019-05-15 12:43:49 +02:00
Nathan Sobo
765d5122c3 Allow escaped " literals in the SyntaxScopeMap
In order to pass a quote literal to the postcss-selector-parser, it 
needs to be escaped. However, this escaping is not removed by the parser 
in the yielded value token, so in this commit I replace any escaped 
quote literals with unescaped quotes after we trim the outer quotes off 
of the string.
2019-05-14 17:17:49 -06:00
Winston Liu
2b15c1ed48 Merge branch 'master' into electron-3.1 2019-05-14 11:28:03 -04:00
Rafael Oleza
2df2f87c83 Add import statement at the beginning of file 2019-05-13 17:48:11 +02:00
David Wilson
9921e18e5a Use correct fontWeight value in ThemeManager spec
In Chrome 66+ it seems that getComputedStyle().fontWeight returns the computed
numeric value of the style instead of the original descriptive name.  We now
look for value '700' which corresponds to the value of 'bold'.
2019-05-13 13:53:53 +02:00
Nathan Sobo
1d2878f92e Merge remote-tracking branch 'origin/master' into ns/notify 2019-05-10 15:38:36 -06:00
Nathan Sobo
be7d129675 Normalize to realpath in waitForEvents helper 2019-05-10 14:31:14 -06:00
Nathan Sobo
b1b1b15d49 Normalize %TEMP% to a long path on Windows CI
This avoids problems with assertions that involve paths inside the temp 
folder.
2019-05-10 13:46:57 -06:00
Jason Rudolph
ecbdb3de75 Merge pull request #19279 from atom/mb-newlines-between-injection-points
Improve handling of comment characters in ERB and EJS
2019-05-08 15:53:16 -04:00
Jason Rudolph
f18ad1eea1 Enhance spec to better demonstrate the functionality being tested
/xref https://github.com/atom/atom/pull/19279#discussion_r282137915
2019-05-08 13:07:12 -04:00
Jason Rudolph
e247815879 Rename test for additional clarity (hopefully) 2019-05-08 10:33:25 -04:00
Jason Rudolph
e00ea44310 Fix test 2019-05-08 10:29:23 -04:00
Nathan Sobo
db40641a84 Merge remote-tracking branch 'origin/master' into ns/notify 2019-05-07 16:38:34 -06:00
Jason Rudolph
c163564a9e Explore potential test for ef94657438
This test doesn't pass yet. Stay tuned. 📺😇
2019-05-07 17:44:34 -04:00
Rafael Oleza
691c90e4b5 Fix atom.open() 2019-05-07 19:14:32 +02:00
Jason Rudolph
f1952c2fc1 Merge pull request #19272 from atom/improve-positioning-when-opening-file-at-line
Improve positioning when opening file at line
2019-05-07 10:53:52 -04:00
Jason Rudolph
4ac6107f95 🎨 Use await to make the world a better place
/xref https://github.com/atom/atom/pull/19272#discussion_r281562954
2019-05-07 09:20:00 -04:00
Rafael Oleza
1efa4f36ea Decaffeinate src/initialize-application-window.js 2019-05-07 12:47:10 +02:00
Rafael Oleza
833cdd0c29 Merge pull request #19274 from atom/prepare-for-electron-v3
Prepare Atom for the electron v3 upgrade
2019-05-07 10:30:46 +02:00
Max Brunsfeld
fa100866cb Merge pull request #19172 from atom/mb-tree-sitter-upgrade-test-travis
Try upgrading Tree-sitter for a third time
2019-05-06 22:33:20 -07:00
Max Brunsfeld
59319d639a Update test to expect new rendering of missing tree-sitter nodes 2019-05-06 14:50:38 -07:00
David Wilson
78f354ad3a Update StyleManager specs to address deprecated ::shadow selectors
As of Chromium 63, ::shadow CSS selectors have been fully removed:

https://developers.google.com/web/updates/2017/10/remove-shadow-piercing

As a result, any usage of ::shadow in a stylesheet seems to get removed as soon
as the stylesheet is applied to an HTMLStyleElement.  Since we have a couple of tests
that expect ::shadow selectors to be present, we must remove those expectations
since those selectors do not appear any longer.
2019-05-06 20:27:27 +02:00
David Wilson
614d3e150a Use fs.renameSync in Workspace spec to fix test failure 2019-05-06 20:25:52 +02:00
David Wilson
3bd2279d3c Make invalid JS file fail Babel spec again
This change uses a different JavaScript syntax to cause the "when a .js file
does not start with 'use babel'" spec to fail again after upgrading to Electron
3 / Node 10.3.0.  The previous generator syntax seems to be supported in the
version of V8 used by Node 10 so we now need to use the 'export default' syntax
to trigger an error.

I've verified that changing the first line of this file to 'use babel' causes
the file to load successfully, so it seems this new syntax is effective to
verify the desired behavior.
2019-05-06 20:24:29 +02:00
Jason Rudolph
9921d1cef3 Unfold (if needed) when opening file at specific line 2019-05-06 11:24:26 -04:00
Rafael Oleza
0d80191516 Merge pull request #19257 from atom/increase-timeout-file-recovery-test
Increase the timeout for the FileRecoveryService tests
2019-05-06 11:39:16 +02:00
Winston Liu
d8559d37a2 Add 'it' in front of spec descriptions 2019-05-04 12:29:52 -04:00
Nathan Sobo
5bfbdd2bce Stop all watchers before attempting to replace directory with file
I think that the notify subprocess might be holding a lock on the 
watched directory on Windows.
2019-05-03 14:11:59 -06:00
Nathan Sobo
1ec8e7730b Work around 8.3 path issue on Azure Windows 2019-05-03 10:46:33 -06:00
Rafael Oleza
fb79283d15 Increase the timeout for the FileRecoveryService tests 2019-05-03 17:27:48 +02:00
Nathan Sobo
f8d7c9cbce Use async/await in test to see if it fixes Windows failures on CI 2019-05-02 13:35:04 -06:00
Nathan Sobo
508b56da28 Remove logic supporting dynamic switching of path watcher backends
The logic is pretty complex and I don't want to take the time to 
integrate @atom/notify with it. I left a bunch of stuff commented out in 
this commit just in case these changes break the build. I'll do another 
pass to delete commented code once we go green.
2019-05-02 07:40:38 -06:00
Nathan Sobo
89a7aa851b Default to @atom/notify for file system notifications
There's still some work to do to make this work on Linux and support 
switching between notification back-ends.
2019-05-02 07:40:37 -06:00
Jason Rudolph
2cf285bc36 Merge #19175 from UziTech/patch-7: await uriHandler 2019-05-01 16:23:34 -04:00
Ash Wilson
3ee3641525 Merge pull request #19247 from atom/aw/drag-and-drop
Always use target window for drag-and-drop
2019-05-01 12:44:43 -04:00
Ash Wilson
e2d5143b53 Use the "here" option to open for drag-and-drop 2019-05-01 09:05:46 -04:00
Ash Wilson
61377b843c Support a "here" option in the "open" IPC message handler 2019-05-01 09:02:02 -04:00
Rafael Oleza
3fcdcde74d Use async randomBytes API to speedup Windows startup 2019-04-30 19:14:54 +02:00
Rafael Oleza
2a7ddf0d22 Merge pull request #19234 from atom/improve-flaky-test
Disable external events from workspaceElement test
2019-04-30 11:01:55 +02:00
Rafael Oleza
7e4dfa9417 Merge pull request #13760 from atom/wl-open-empty-editor-as-pending
Open empty editor as a pending pane item
2019-04-29 15:54:25 +02:00
Rafael Oleza
4e2e820a6c Disable external events from workspaceElement test 2019-04-29 15:09:23 +02:00