Nathan Sobo
4ccf976501
Pass tabText into EditSession explicitly on construction
2012-06-13 11:13:41 -06:00
Corey Johnson & Nathan Sobo
912b89184e
Rename highlightSelectedFolds to highlightFoldsContainingBufferRange on Editor.
2012-06-12 17:23:19 -07:00
Corey Johnson & Nathan Sobo
222e12d29d
Backspace in column 0 below a fold absorbs line into fold
2012-06-12 16:49:49 -07:00
Nathan Sobo
cca387b36a
Move selectLine specs from selection-spec to edit-session-spec
2012-06-12 16:14:37 -06:00
Nathan Sobo
3a93887292
Move structural folding to EditSession
2012-06-12 15:49:42 -06:00
Nathan Sobo
efcc43c296
Merge branch 'master' of github.com:github/atom
2012-06-12 15:21:06 -06:00
Corey Johnson
e56e775d8d
Merge branch 'dirty-buffer'
2012-06-12 14:13:23 -07:00
Nathan Sobo
b895122c24
Simplify Editor spec's mouse event integration specs
...
Test handling of non-corresponding buffer & screen positions in spec on setCursorScreenPosition in edit-session-spec instead of in editor-spec
2012-06-12 14:44:45 -06:00
Nathan Sobo
a71ee63906
Move undo/redo to EditSession
2012-06-12 13:40:18 -06:00
Corey Johnson
b5e3977ef2
Use Native class to call saveDialog
2012-06-12 10:52:11 -07:00
Corey Johnson
e56ef733ad
Add save alert when closing a modified buffer
2012-06-12 10:52:11 -07:00
Corey Johnson
0fec1fc5ba
Don't close edit session when its buffer is modified
2012-06-12 10:52:11 -07:00
Nathan Sobo
869df0bbc6
Add word and line selection methods to EditSession
2012-06-12 11:47:37 -06:00
Nathan Sobo
4e74f1bf2e
Fix issues with selections when switching between edit sessions
...
SelectionViews now update their appearance immediately when constructed. We can't assume they're empty. CursorView doesn't do a blanket `off()` call to its model when it's removed anymore, which was screwing up selection updates when switching back. Only attach selections / cursors when the editor is attached, and extract everything we do into a `renderWhenAttached` method.
2012-06-11 22:01:27 -06:00
Nathan Sobo
915707cd9c
Move backspace, delete, and pasteboard operations specs to edit-session-spec
2012-06-11 17:35:13 -06:00
Nathan Sobo
dc6012dabd
Merge branch 'master' of github.com:github/atom
2012-06-11 17:08:07 -06:00
Nathan Sobo
c2c48b9b38
Move more specs to EditSession. Auto indent and soft tabs settings are delegated to edit session.
2012-06-11 17:06:40 -06:00
Corey Johnson
e2bd646e0f
Scroll editor using css 'top' property instead of scrollTop
2012-06-11 15:48:03 -07:00
Nathan Sobo
cffadcf4a8
Remove CompositeCursor and Selection. Move their remaining methods into Editor
2012-06-11 10:11:33 -06:00
Nathan Sobo
31135afd9a
Remove more references to CompositeSelection
2012-06-11 09:28:25 -06:00
Nathan Sobo
e549864219
Switch indent/outdentSelectedRows to activeEditSession
2012-06-11 09:20:46 -06:00
Nathan Sobo
8c52fedd0d
Remove last of the extraneous CursorView methods
2012-06-10 21:53:54 -06:00
Nathan Sobo
80cd63227a
Remove methods from CompositeCursor + more 💄
2012-06-08 19:08:44 -06:00
Nathan Sobo
2161336c78
Move logic out of CompositeSelection into EditSession
2012-06-08 17:46:14 -06:00
Nathan Sobo
873c80eaf2
Move most remaining logical methods from selection view into model
2012-06-08 15:26:54 -06:00
Nathan Sobo
7eb01272ed
Move text insertion and auto indent/outdent code from the selection view to the model
2012-06-08 12:31:29 -06:00
Nathan Sobo
5a37a39b9b
Tie creation of SelectionViews to adding Selection models to the EditSession
2012-06-07 18:20:00 -06:00
Nathan Sobo
f406786a3a
Editor subscribes to EditSession for screen line changes. Remove more movement logic from cursor view.
2012-06-07 16:31:40 -06:00
Nathan Sobo
624cf3cbd3
EditSession informs cursor models of buffer changes (instead of Editor informing cursor views)
2012-06-07 15:41:35 -06:00
Nathan Sobo
d5d5caf764
Merge branch 'master' of github.com:github/atom into edit-session-refactor
2012-06-07 15:33:16 -06:00
Nathan Sobo
d872d12e04
Transfer word movement methods into cursor model
2012-06-07 15:33:01 -06:00
Corey Johnson
01d819abc8
💄
2012-06-07 10:54:42 -07:00
Nathan Sobo
d50c8f2d0e
Merge branch 'master' of github.com:github/atom into edit-session-refactor
2012-06-07 11:40:01 -06:00
Nathan Sobo
21ae28657c
Move moveTo(Beginning/FirstCharacter/End)OfLine methods to cursor model
...
Also, implement move to end of line by adding a clip option to setBufferPosition and passing [row, Infinity]
2012-06-07 11:28:40 -06:00
Corey Johnson
481ec16485
meta-w closes edit sessions until there are none left, then it closes the editor
2012-06-07 10:21:16 -07:00
Nathan Sobo
fccc88acaf
Move moveLeft/Right/ToTop/ToBottom methods into cursor model
2012-06-07 10:57:21 -06:00
Nathan Sobo
ddf29e89ec
Slave CursorView's screen position to its cursor model. Move moveUp and moveDown methods into cursor model.
2012-06-07 10:47:30 -06:00
Nathan Sobo
7387c553c3
Start introducing Cursor model in EditSession
...
The old cursor view still does most of the work, but to add a new cursor view we now must add a cursor model to the edit session at the correct position. The editor watches the 'add-cursor' event on edit session and add a corresponding CursorView to the CompositeCursor whenever a model is added. Next step: have the cursor view observe the cursor model and shadow its changes in position.
2012-06-06 21:52:19 -06:00
Nathan Sobo
c6fa2313ca
💄
2012-06-06 17:47:29 -06:00
Nathan Sobo
00b9c6db81
Active edit session 💄
2012-06-06 17:46:00 -06:00
Nathan Sobo
ff52993c9e
Fix bugs when switching between EditSessions
2012-06-06 17:00:02 -06:00
Nathan Sobo
024618b69a
Build Renderer in EditSession and assign it when switching to that EditSession
2012-06-06 12:42:53 -06:00
Nathan Sobo
5a28656259
Introduce EditSession class, which replaces edit session hashes
2012-06-06 12:10:49 -06:00
Nathan Sobo
e6af7a9515
Adjust the width of rendered lines to account for the longest line
2012-06-05 14:26:06 -06:00
Nathan Sobo
3a776347ff
Avoid leaking window resize subscriptions in editor spec
2012-06-05 14:25:08 -06:00
Nathan Sobo
e7ffaa1757
Merge branch 'master' of github.com:github/atom
2012-06-05 12:48:16 -06:00
Nathan Sobo
911a417cb8
Rename maxLineLength to softWrapColumn
2012-06-05 12:47:39 -06:00
Corey Johnson
4f364e8cd8
Add newline-below event
2012-06-05 11:30:29 -07:00
Nathan Sobo
4dc41dcc21
💄
2012-06-05 11:09:40 -06:00
Nathan Sobo
c24b8a90b2
If lines are removed after a renderer change, update padding appropriately
2012-06-05 10:59:11 -06:00
