Commit Graph

12958 Commits

Author SHA1 Message Date
abe33
4d44016eb1 🎨 Remove unnecessary branching 2015-10-12 19:40:23 +02:00
abe33
9ee89a1f31 🎨 Fix bad indentation 2015-10-11 18:15:22 +02:00
abe33
09ffa8bec9 🐛 Fix moving multiple selections down locked at wrapped line 2015-10-11 18:15:06 +02:00
abe33
f4f4b9fdef Merge branch 'master' into pr/8232 2015-10-11 14:23:36 +02:00
Nathan Sobo
8e834794a9 Remove scroll listener on destroy so we don’t call undefined onScroll
/cc @izuzak because no PR, @as-cii because this fixes an unexpected
issue with your change.
2015-10-07 16:52:37 -05:00
Nathan Sobo
3636eb35d8 Merge pull request #8811 from atom/as-double-reflow-measurements
DOM-based measurements
2015-10-07 15:43:59 -05:00
Antonio Scandurra
8da83022f1 🔥 Remove useless null assignment 2015-10-07 19:51:32 +02:00
Antonio Scandurra
1df9162389 Clear references to scrollbar components 2015-10-07 19:02:45 +02:00
Antonio Scandurra
a62341b548 Avoid capturing this when handling dragging 2015-10-07 19:02:01 +02:00
Antonio Scandurra
a767ca9892 🚱 Dispose ::onDidUpdateMarkers in presenter 2015-10-07 09:54:59 +02:00
Max Brunsfeld
06a0a26ba0 Include version in socket path on mac and linux 2015-10-06 10:17:29 -07:00
Antonio Scandurra
428f0db75b 🔥 2015-10-06 11:02:36 +02:00
Antonio Scandurra
e8387e0095 🐎 2015-10-06 11:00:50 +02:00
Antonio Scandurra
61892f932b Use cached text nodes instead of NodeIterator 2015-10-06 10:43:32 +02:00
Antonio Scandurra
175c21f47e Cache built text nodes 2015-10-06 10:35:01 +02:00
Antonio Scandurra
5529645ff3 Recycle highlights 2015-10-06 10:26:49 +02:00
Antonio Scandurra
cc1b42b279 Faster DOM removal 2015-10-06 10:21:13 +02:00
Antonio Scandurra
dede68011f Recycle text nodes in lines 2015-10-06 10:18:05 +02:00
Antonio Scandurra
c1e56322aa Recycle text nodes in line numbers 2015-10-06 10:08:06 +02:00
Antonio Scandurra
c79cc87172 Prepare DOMElementPool to account for text nodes 2015-10-06 10:02:04 +02:00
Antonio Scandurra
b31d3d1a3f Revert "🐎 Faster line number calculation"
This reverts commit e04aef0af3.
2015-10-06 09:16:29 +02:00
Antonio Scandurra
d5dac3459b Merge branch 'master' into as-double-reflow-measurements 2015-10-06 08:36:22 +02:00
Nathan Sobo
a64d5b18e2 Fix linter errors 2015-10-05 15:48:20 -06:00
Nathan Sobo
ddb08d0c46 Avoid redundant onDidAddPaneItem notifications
Refs #9012
2015-10-05 12:34:49 -06:00
Antonio Scandurra
e04aef0af3 🐎 Faster line number calculation 2015-10-05 17:36:28 +02:00
Antonio Scandurra
1c56c3f951 🎨 2015-10-05 16:32:51 +02:00
Antonio Scandurra
0bee6a0cc1 Avoid invalidating state when clearing screen rows to measure 2015-10-05 16:10:58 +02:00
Antonio Scandurra
581ffb1360 🐎 Avoid to measure invisible lines when dragging 2015-10-05 16:05:17 +02:00
Antonio Scandurra
56488748db 🔥 Remove dead code 2015-10-05 14:37:22 +02:00
Antonio Scandurra
3df6ed8405 Merge branch 'master' into as-double-reflow-measurements 2015-10-03 15:53:34 +02:00
Antonio Scandurra
beb7896234 Enable subpixel font scaling
For certain font sizes, enabling `textRendering: optimizeLegibility` caused a
bunch of measurement-related issues. You can reproduce it by setting the following in your stylesheet:

```
atom-text-editor {
  font-size: 14px;
  text-rendering: optimizeLegibility;
}
```

Although I wanted to defer subpixel font scaling to a later moment, it seems
like Chrome needs to have it enabled in order to properly support the
"legibility" path for text rendering. (I guess this is part of the reason why
the Chromium team enabled it by default at some point in the past.)
2015-10-02 18:14:09 +02:00
Antonio Scandurra
b7e373fdca 🐛 Correctly measure RTL characters
This will fix also the "hidden cursor" issue we were experiencing.

/cc: @izuzak
2015-10-02 12:51:10 +02:00
Antonio Scandurra
2ffa7da59e 🐎 Remove rows to measure in the next frame 2015-10-02 12:38:19 +02:00
Jeremy Ebneyamin
5b522f70c2 🐛 Fix Windows context menu shortcut
Fix the bug where Open With Atom on Windows machines will fail for paths
containing spaces. Wraps quotes around the path to the Atom executable
in the reg key string.
2015-10-02 00:06:30 -07:00
Nathan Sobo
9ec6bcd9c6 Merge pull request #8931 from ssorallen/texteditor-decoratemarker
Link Gutter::decorateMarker to TextEditor::decorateMarker
2015-10-01 13:30:31 -06:00
Ross Allen
1670357293 Link Gutter::decorateMarker to TextEditor::decorateMarker
`Gutter::decorateMarker` passes its `decorationParams` object through to
`TextEditor::decorateMarker`. Rather than duplicate documentation and
fall out-of-date (as was surfaced in #8920), link the
`TextEditor::decorateMarker` as the canonical docs location.
2015-10-01 10:08:36 -07:00
Max Brunsfeld
2cd4826e62 Merge pull request #8862 from phord/dot-git-files
🐛 Teach Atom to read .git files
2015-10-01 09:32:49 -07:00
Antonio Scandurra
e1c3d2ef57 🐎 Avoid recomputing state for lines twice 2015-10-01 17:42:44 +02:00
Antonio Scandurra
63ce6cae03 🐛 Fix an issue where yardstick cache wasn't being emptied 2015-10-01 14:20:53 +02:00
Antonio Scandurra
b16d2a59f2 💚 2015-10-01 13:58:13 +02:00
Antonio Scandurra
b6a0db916f 🐛 Fix wrong pixel to screen position conversion 2015-10-01 13:05:50 +02:00
Antonio Scandurra
e94ff33d83 🐛 Exclude invalid tiles 2015-10-01 12:58:02 +02:00
Antonio Scandurra
116f92d816 🐎 Mark soft-wrapped lines in TokenizedLine 2015-10-01 11:15:55 +02:00
Antonio Scandurra
243dea1a1c 🎨 Move pixel-related code to LinesYardstick
* 🔥 Remove useless 'scoped char width' methods
2015-10-01 11:03:25 +02:00
Nathan Sobo
1940d4584b Fix typos
/cc @izuzak since I don’t want to open a PR for this
2015-09-30 15:01:52 -06:00
Antonio Scandurra
58219a243e Slightly more precise conversion to screen positions 2015-09-30 18:20:48 +02:00
Antonio Scandurra
2b6973d4b1 Fix a 🐛 where some invalid lines were being measured 2015-09-30 17:44:43 +02:00
Antonio Scandurra
bca3be32e6 Avoid to call ::prepareScreenRows explicitly 2015-09-30 16:23:49 +02:00
Antonio Scandurra
bb709f58d9 🐎 Cache pixel positions 2015-09-30 16:15:49 +02:00
Antonio Scandurra
59d6974f89 🐎 Remove AcceptFilter
...so that Chrome doesn't need to switch to user space when iterating over line
nodes.
2015-09-30 16:03:36 +02:00