Nathan Sobo
4e74f1bf2e
Fix issues with selections when switching between edit sessions
...
SelectionViews now update their appearance immediately when constructed. We can't assume they're empty. CursorView doesn't do a blanket `off()` call to its model when it's removed anymore, which was screwing up selection updates when switching back. Only attach selections / cursors when the editor is attached, and extract everything we do into a `renderWhenAttached` method.
2012-06-11 22:01:27 -06:00
Nathan Sobo
b51ab212f6
Un-F
2012-06-11 17:40:51 -06:00
Nathan Sobo
5f29f7e67d
💄
2012-06-11 17:40:37 -06:00
Nathan Sobo
09e0fb2a58
Delete irrelevant specs
2012-06-11 17:40:26 -06:00
Nathan Sobo
e619d84893
Move insertTab specs to edit-session-spec
2012-06-11 17:40:02 -06:00
Nathan Sobo
915707cd9c
Move backspace, delete, and pasteboard operations specs to edit-session-spec
2012-06-11 17:35:13 -06:00
Nathan Sobo
dc6012dabd
Merge branch 'master' of github.com:github/atom
2012-06-11 17:08:07 -06:00
Nathan Sobo
c2c48b9b38
Move more specs to EditSession. Auto indent and soft tabs settings are delegated to edit session.
2012-06-11 17:06:40 -06:00
Corey Johnson
a4f4b3a3bb
Update tests to use editor.renderLines.css('top')
...
instead of editor.scrollView.scrollTop().
2012-06-11 15:48:03 -07:00
Corey Johnson
e2bd646e0f
Scroll editor using css 'top' property instead of scrollTop
2012-06-11 15:48:03 -07:00
Nathan Sobo
41f08cc075
Start moving specs from editor-spec to edit-session-spec
2012-06-11 16:06:21 -06:00
Nathan Sobo
4d5760e287
Kill tabText ivar on EditSession
2012-06-11 16:06:02 -06:00
Nathan Sobo
cffadcf4a8
Remove CompositeCursor and Selection. Move their remaining methods into Editor
2012-06-11 10:11:33 -06:00
Nathan Sobo
8c52fedd0d
Remove last of the extraneous CursorView methods
2012-06-10 21:53:54 -06:00
Nathan Sobo
80cd63227a
Remove methods from CompositeCursor + more 💄
2012-06-08 19:08:44 -06:00
Nathan Sobo
2161336c78
Move logic out of CompositeSelection into EditSession
2012-06-08 17:46:14 -06:00
Nathan Sobo
873c80eaf2
Move most remaining logical methods from selection view into model
2012-06-08 15:26:54 -06:00
Nathan Sobo
7eb01272ed
Move text insertion and auto indent/outdent code from the selection view to the model
2012-06-08 12:31:29 -06:00
Nathan Sobo
f3144fe0d8
Base the screen range of the selection view on the selection model
2012-06-08 11:22:12 -06:00
Nathan Sobo
608c4f48bf
Remove more logic from cursor view
2012-06-07 16:58:45 -06:00
Nathan Sobo
d50c8f2d0e
Merge branch 'master' of github.com:github/atom into edit-session-refactor
2012-06-07 11:40:01 -06:00
Corey Johnson
481ec16485
meta-w closes edit sessions until there are none left, then it closes the editor
2012-06-07 10:21:16 -07:00
Nathan Sobo
7387c553c3
Start introducing Cursor model in EditSession
...
The old cursor view still does most of the work, but to add a new cursor view we now must add a cursor model to the edit session at the correct position. The editor watches the 'add-cursor' event on edit session and add a corresponding CursorView to the CompositeCursor whenever a model is added. Next step: have the cursor view observe the cursor model and shadow its changes in position.
2012-06-06 21:52:19 -06:00
Nathan Sobo
ff52993c9e
Fix bugs when switching between EditSessions
2012-06-06 17:00:02 -06:00
Nathan Sobo
1344d42061
Add spec to ensure we unsubscribe from every buffer when we remove editor
2012-06-06 12:48:45 -06:00
Nathan Sobo
e6af7a9515
Adjust the width of rendered lines to account for the longest line
2012-06-05 14:26:06 -06:00
Nathan Sobo
e433d106b8
Remove unnecessary construction of new editor
2012-06-05 14:25:32 -06:00
Nathan Sobo
3a776347ff
Avoid leaking window resize subscriptions in editor spec
2012-06-05 14:25:08 -06:00
Nathan Sobo
e7ffaa1757
Merge branch 'master' of github.com:github/atom
2012-06-05 12:48:16 -06:00
Nathan Sobo
911a417cb8
Rename maxLineLength to softWrapColumn
2012-06-05 12:47:39 -06:00
Corey Johnson
4f364e8cd8
Add newline-below event
2012-06-05 11:30:29 -07:00
Nathan Sobo
4dc41dcc21
💄
2012-06-05 11:09:40 -06:00
Nathan Sobo
c24b8a90b2
If lines are removed after a renderer change, update padding appropriately
2012-06-05 10:59:11 -06:00
Nathan Sobo
9cfbce826d
WIP: Don't allow impossibly high scroll top values.
...
It fixes the move to bottom issues, but breaks some other tests. Not sure why yet...
2012-06-04 21:57:10 -06:00
Nathan Sobo
3c2facc7be
Add a disabled failing spec for text rendering when moving to the end of the file
2012-06-04 21:11:32 -06:00
Nathan Sobo
de1086639d
Add failing spec for folding more than a screen of text to less than a screen
2012-06-04 20:45:28 -06:00
Nathan Sobo
c3a157a544
Revert "Use renderTo and renderFrom (instead of firstVisible/lastVisible) to adjust visible lines."
...
This reverts commit 419d7b1dec
2012-06-04 20:29:40 -06:00
Corey Johnson
0cfb2e9ef4
Rename Editor.visibleLines to Editor.renderedLines
2012-06-04 17:53:58 -07:00
Corey Johnson
419d7b1dec
Use renderTo and renderFrom (instead of firstVisible/lastVisible) to adjust visible lines.
...
Fix specs that had wrong assumptions,
2012-06-04 17:48:11 -07:00
Nathan Sobo
ded6281e0f
Merge branch 'master' into toggle-comments
2012-06-04 12:07:54 -06:00
Nathan Sobo
d2a1da7ba6
Window spec no longer nukes the jasmine stylesheet
2012-06-04 12:07:37 -06:00
Nathan Sobo
a033d13c1a
Merge branch 'master' of github.com:github/atom into toggle-comments
2012-06-04 11:55:15 -06:00
Nathan Sobo
b667ba4262
If selection is empty when toggling a line comment, keep it empty
2012-06-04 11:50:48 -06:00
Corey Johnson
2f6dd085ee
Editor toggle-fold event toggles the largest fold at the cursor position
2012-06-04 09:44:20 -07:00
Corey Johnson & Nathan Sobo
fd152ef2a9
When a fold is created inside an existing fold, don't trigger change events or update line map.
2012-06-02 09:21:06 -07:00
Corey Johnson & Nathan Sobo
2f435e08f3
Add regression test for "can't create multiple folds over same region".
...
Am I using the term regression test correctly?
2012-06-02 08:56:02 -07:00
Nathan Sobo
14e399fdf0
Meta-/ comments out selected lines
2012-06-01 19:38:33 -06:00
Corey Johnson
ca4371d9ce
The solution to all build problems
2012-06-01 15:35:38 -07:00
Nathan Sobo
2c35a1f12d
LineCommenter.proto.toggleLineCommentsInRange comments / uncomments lines in a selection
2012-06-01 14:28:40 -06:00
Nathan Sobo
d8b324e14f
WIP: Starting on toggling comments.
2012-06-01 14:03:48 -06:00
