Antonio Scandurra
d6ac7863c9
Merge branch 'master' into as-tiled-gutter
2015-06-19 20:12:43 +02:00
Antonio Scandurra
d7156ff387
Remove event listeners from orphaned gutters
2015-06-19 10:24:48 +02:00
Antonio Scandurra
a3a8d8417b
Merge branch 'as-remove-gutter-from-view-registry' into as-tiled-gutter
2015-06-18 19:58:33 +02:00
Antonio Scandurra
b04b0a8dc4
🐛 Fix race condition as well
2015-06-17 13:48:31 +02:00
Antonio Scandurra
e893b5105b
Remove presenter as a dependency where possible
...
Although we have a couple of components which still access it, we
agreed it would have been just better to avoid relying on
`TextEditorPresenter` where possible and use it purposefully in other
places (e.g. `LinesComponent` which needs it to store text
measurements).
/cc: @jssln
2015-06-13 14:18:36 +02:00
Antonio Scandurra
7ac0cdcbf5
Start porting TextEditorComponent spec
2015-06-12 18:22:33 +02:00
Luke Pommersheim
c67f98febb
if there are multiple cursors and you click a cursor, it is removed, otherwise new cursor is added. Cannot remove if there is only one cursor and you click on it
2015-06-11 13:26:09 +02:00
Antonio Scandurra
b4dfb2a31b
Merge branch 'master' into as-tiled-rendering
2015-05-29 14:19:25 +02:00
Max Brunsfeld
9e3c2d093b
Avoid double transaction when typing
2015-05-26 17:09:59 -07:00
Antonio Scandurra
752dbf2c6e
Manually config tileSize
...
Dealing with a manually entered `tileSize` is actually easier to reason about,
therefore we no longer calculate it based on `tileCount.`
2015-05-21 09:59:58 +02:00
Antonio Scandurra
b66fdca057
Merge branch 'master' into as-tiled-rendering
...
Conflicts:
spec/text-editor-presenter-spec.coffee
2015-05-18 11:49:12 +02:00
Antonio Scandurra
e7ddb3d8ad
💚 Fix all TextEditorPresenter specs
2015-05-14 15:54:53 +02:00
Antonio Scandurra
6be88fd645
Scroll every single tile left/right
2015-05-14 11:36:20 +02:00
Jess Lin
957424f987
[Gutter] @state.gutter.sortedDescriptions -> @state.gutters
2015-05-13 11:15:44 -07:00
Antonio Scandurra
25acaf26c1
🎨 tileId -> tileRow
2015-05-13 12:44:06 +02:00
Antonio Scandurra
a6e0fa6e91
Scroll exactly as we did before tiling
...
Except that now we store the scrolling tile, instead of the scrolling
row.
2015-05-11 09:42:04 +02:00
Antonio Scandurra
216b757ac0
Keep scrolling tile around for mousewheel
2015-05-05 19:49:49 +02:00
Antonio Scandurra
3a1bb898c3
Fix clicking on line
2015-05-05 19:09:48 +02:00
Max Brunsfeld
570c424eae
Merge pull request #6563 from atom/ns-fix-scroll-width-with-folds
...
Fix scroll width calculation when longest line is folded
2015-04-30 14:26:34 -07:00
Ben Ogle
d3ef6c91af
Measure gutterWidth, and pass to presenter
2015-04-29 15:47:44 -07:00
Nathan Sobo
1d238dd927
Fix scroll width calculation when longest line is folded
...
With the presenter we started clipping screen positions prior to
translating them to pixel positions. This interacts with the current
clipping behavior on folded lines (which should change) where the cursor
is always clipped to 0. So when the longest line was also folded we
were miscalculating the width. 🙈 !
The removal of clipping also causes us to calculate the width based on
the trailing whitespace of soft-wrapped lines, which I actually think
is an improvement but it is slightly different.
2015-04-28 23:30:13 -06:00
Nathan Sobo
90d6eb7a13
Merge pull request #5217
2015-04-22 13:28:37 -06:00
Kevin Sawicki
5f38719dfc
⬆️ scrollbar-style@3.1
2015-04-22 10:27:07 -07:00
Jess Lin
79b460a0ca
[Gutter] Add ::getDomNode method to all 'components'
2015-04-22 07:28:59 -07:00
Jess Lin
34856d94f5
[Gutter][DOM Persistence] Keep a gutter in the DOM if it is merely hidden (not destroyed)
2015-04-22 07:28:58 -07:00
Jess Lin
f3d2597bda
[Gutter][View Registry] Make the Presenter pass sorted Gutter models instead of sorted derived state
2015-04-22 07:28:58 -07:00
Jess Lin
8d6745d8a9
[Gutter] Replace GutterComponent with GutterContainerComponent in TextEditorComponent
2015-04-22 07:28:57 -07:00
Jess Lin
b4ffa04e4c
[Gutter] Rename GutterComponent to LineNumberGutterComponent
2015-04-22 07:28:57 -07:00
Jess Lin
7582e98f4c
[Gutter] TextEditorPresenter: rename @state.gutter -> @state.lineNumberGutter
2015-04-22 07:28:57 -07:00
Antonio Scandurra
1c8cf4390c
Rename to safe-clipboard
...
...and use remote only on Linux renderer processes.
2015-04-14 10:50:09 +02:00
Antonio Scandurra
87972caf1e
🐧 Disable failing spec
2015-04-13 16:24:22 +02:00
Antonio Scandurra
f633a4f771
Use src/native-clipboard in TextEditorComponent
2015-04-13 14:20:17 +02:00
Machiste Quintana
5d2392ea67
👕 Fix new coffeelint errors
2015-04-06 23:59:54 -04:00
Kevin Sawicki
60913cd9bf
📝 Remove empty deprecated comments
2015-04-03 11:37:34 -07:00
Kevin Sawicki
7d592c8b78
includeDeprecations -> includeDeprecatedAPIs
2015-04-03 11:29:16 -07:00
Kevin Sawicki
63072bf8ae
Check deprecations flag for space pen shim inclusion
2015-04-03 11:29:14 -07:00
Kevin Sawicki
baca3284f4
Conditionally include deprecations in TextEditorComponent
2015-04-03 11:29:12 -07:00
Kevin Sawicki
87fca98bab
Deprecate TextEditorComponent::setShowInvisibles
2015-04-03 11:27:59 -07:00
Ben Ogle
3adc646a79
Remove the horribleUpdateMethod
2015-04-01 17:41:00 -07:00
Ben Ogle
c62f06af9d
Cache the overlay dimensions in the presenter
2015-04-01 17:40:59 -07:00
Ben Ogle
6b5a74e3b6
Update specs for overlay rendering
2015-04-01 17:40:59 -07:00
Ben Ogle
8749db30cf
Add OverlayManager to the TextEditorComponent
2015-04-01 17:40:59 -07:00
Max Brunsfeld
2f5d975338
Remove autoscroll-related legacy editor view support
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-03-26 11:12:37 -07:00
Ivan Zuzak
d21ae2c869
Select buffer lines for mouse clicks on gutter
2015-03-02 22:29:47 +01:00
Antonio Scandurra
436322fc41
Call it onDidUpdateState
2015-02-28 09:36:56 +01:00
Antonio Scandurra
0dca5a5fcd
Encapsulate state update inside TextEditorPresenter#getState
2015-02-28 09:25:53 +01:00
Antonio Scandurra
fbec9e31c4
Let's call it needsUpdate 😉
2015-02-27 20:54:00 +01:00
Antonio Scandurra
bcc99c163f
Rename applyChanges to update
2015-02-27 20:42:04 +01:00
Antonio Scandurra
bf16287b16
🎨 Avoid entering/exiting from the outside
2015-02-27 16:59:59 +01:00
Antonio Scandurra
2f00d3e361
Batch on @requestUpdate
2015-02-27 15:10:17 +01:00
