Antonio Scandurra
52631bab98
Use fs-plus instead of fs in AtomProtocolHandler
...
This commit fixes some deprecation warnings we were observing in our
test suite, as well as when opening packages that registered protocol
handlers such as the `welcome` package.
The warnings were due to using the `fs.(l)statSyncNoException` API,
which will be deprecated from Electron 4 onwards. We had already dealt
with this by shipping https://github.com/atom/fs-plus/pull/46 , which
provided a shim on `fs-plus` to suppress the warning. However,
`AtomProtocolHandler` was still using the standard `fs` module, which
was causing the warning to be displayed whenever a package registered a
URL opener.
2019-05-20 18:03:14 +02:00
Antonio Scandurra
dc39210cc2
Merge pull request #18916 from atom/electron-3.1
...
⬆️ Electron 3 (Take Two)
2019-05-20 15:20:12 +02:00
Antonio Scandurra
623887b91e
Return activatePromise when calling PackageManager.prototype.activate
2019-05-18 16:36:46 +02:00
Nathan Sobo
616f7845a9
Fix leak of LanguageMode objects in tests
2019-05-17 16:40:52 -06:00
Nathan Sobo
d5c84e5f4e
Wait for config file to load before watching and prompting to restart
2019-05-17 05:18:24 -06:00
Nathan Sobo
770b8fdcf8
Revert "Merge pull request #19244 from atom/ns/notify"
...
This reverts commit b2ecabd527 , reversing
changes made to c3bf95194a .
2019-05-17 04:10:17 -06:00
Nathan Sobo
4f08da2a98
Revert "Merge pull request #19325 from atom/ns/notify-asar-exclude"
...
This reverts commit da8b1a1a42 , reversing
changes made to 1edf94a240 .
2019-05-17 04:10:10 -06:00
Nathan Sobo
bfe216c8ac
Revert "Merge pull request #19345 from atom/ns/notify-retreat"
...
This reverts commit 3d37651ac1 , reversing
changes made to e1a5d520e0 .
2019-05-17 04:09:44 -06:00
Nathan Sobo
61c52e3185
Decaffeinate default-directory-searcher.coffee and its spec
...
Co-Authored-By: Rafael Oleza <rafeca@users.noreply.github.com >
2019-05-16 12:54:21 +02:00
Rafael Oleza
46997eae83
Merge branch 'master' into electron-3.1
2019-05-16 11:22:02 +02:00
Nathan Sobo
425aaa7981
Disable @atom/notify again
2019-05-15 12:57:58 -06:00
Nathan Sobo
765d5122c3
Allow escaped " literals in the SyntaxScopeMap
...
In order to pass a quote literal to the postcss-selector-parser, it
needs to be escaped. However, this escaping is not removed by the parser
in the yielded value token, so in this commit I replace any escaped
quote literals with unescaped quotes after we trim the outer quotes off
of the string.
2019-05-14 17:17:49 -06:00
Winston Liu
2b15c1ed48
Merge branch 'master' into electron-3.1
2019-05-14 11:28:03 -04:00
Rafael Oleza
0994d8ae80
Merge pull request #19322 from atom/remove-cached-run-in-this-context
...
Remove cached-run-in-this-context dependency
2019-05-14 10:50:18 +02:00
Jason Rudolph
da8b1a1a42
Merge pull request #19325 from atom/ns/notify-asar-exclude
...
Exclude @atom/notify binary from the ASAR bundle
2019-05-13 17:38:14 -04:00
Nathan Sobo
a952e40b31
Fix @atom/notify's binary path when running within Atom's ASAR archive
...
/cc @rafeca
2019-05-13 12:12:36 -06:00
Rafael Oleza
c77468eca4
Tweak disable rules to play nicely with prettier
2019-05-13 17:48:11 +02:00
Rafael Oleza
d6d1fb41b2
Use the TodoElectronIssue keyword to make the comment easier to find
2019-05-13 16:45:34 +02:00
David Wilson
8def301b74
Remove cached-run-in-this-context and use Node's 'vm' script caching
2019-05-13 16:21:00 +02:00
Rafael Oleza
e57e3ddb7e
Always return a Disposable from the watch() method
2019-05-13 16:05:22 +02:00
David Wilson
75d9a30190
Use new attributeStyleMap for elements
...
More info here: https://developers.google.com/web/updates/2018/03/cssom
2019-05-13 13:53:53 +02:00
David Wilson
552bb22eeb
Remove cached-run-in-this-context and use Node's 'vm' script caching
2019-05-13 13:52:58 +02:00
Nathan Sobo
1d2878f92e
Merge remote-tracking branch 'origin/master' into ns/notify
2019-05-10 15:38:36 -06:00
Rafael Oleza
db6031db03
Merge pull request #19297 from atom/startup-timing-markers
...
Add markers for more granular logging of startup time
2019-05-10 23:16:57 +02:00
Rafael Oleza
b59d6d838f
Add more markers on atom-environment
2019-05-10 17:33:43 +02:00
Winston Liu
5f35405a6a
🔥 custom-event-mixin.coffee
2019-05-09 16:02:13 -04:00
Rafael Oleza
90bcdf4cba
Add markers for more granular logging of startup time
2019-05-09 20:12:07 +02:00
Nathan Sobo
58dece3d9c
🔥 unused methods
2019-05-09 08:33:36 -06:00
Nathan Sobo
5366614774
Revert "Default to 'native' watcher on the stable channel just to be safe"
...
This reverts commit 6da489edc9 .
This commit was messing up the V8 startup snapshot.
2019-05-08 15:28:44 -06:00
Nathan Sobo
6da489edc9
Default to 'native' watcher on the stable channel just to be safe
2019-05-08 14:47:11 -06:00
Nathan Sobo
bfdb1fa7b0
Enable 'poll' option for @atom/notify-based fs watching
2019-05-08 13:59:35 -06:00
Jason Rudolph
ecbdb3de75
Merge pull request #19279 from atom/mb-newlines-between-injection-points
...
Improve handling of comment characters in ERB and EJS
2019-05-08 15:53:16 -04:00
Nathan Sobo
db40641a84
Merge remote-tracking branch 'origin/master' into ns/notify
2019-05-07 16:38:34 -06:00
Nathan Sobo
f1bb55db58
Throw exceptions when there are @atom/notify watcher errors
...
This will surface these errors to users and to our exception reporting
infrastructure to ensure we get feedback on the new backend in the wild.
2019-05-07 13:21:31 -06:00
Jason Rudolph
1747b09025
👕
2019-05-07 13:33:18 -04:00
Rafael Oleza
691c90e4b5
Fix atom.open()
2019-05-07 19:14:32 +02:00
Jason Rudolph
b389240a06
Merge origin/master into mb-newlines-between-injection-points
2019-05-07 13:06:02 -04:00
Jason Rudolph
f1952c2fc1
Merge pull request #19272 from atom/improve-positioning-when-opening-file-at-line
...
Improve positioning when opening file at line
2019-05-07 10:53:52 -04:00
Rafael Oleza
1efa4f36ea
Decaffeinate src/initialize-application-window.js
2019-05-07 12:47:10 +02:00
Rafael Oleza
5302cf92b3
Merge pull request #19275 from atom/fix-remove-all-listeners
...
Fix remove all listeners in Electron v3
2019-05-07 10:32:38 +02:00
Rafael Oleza
833cdd0c29
Merge pull request #19274 from atom/prepare-for-electron-v3
...
Prepare Atom for the electron v3 upgrade
2019-05-07 10:30:46 +02:00
Max Brunsfeld
fa100866cb
Merge pull request #19172 from atom/mb-tree-sitter-upgrade-test-travis
...
Try upgrading Tree-sitter for a third time
2019-05-06 22:33:20 -07:00
Nathan Sobo
1d1b45087f
⬆️ @atom/notify@1.1 for improved error handling
2019-05-06 15:42:51 -06:00
Rafael Oleza
166e7d2386
Add TODOs to remember to fix this when upgrading to electron v4
2019-05-06 21:35:45 +02:00
David Wilson
cc7a1d036a
Remove listeners for specific events in Task class
...
This change is necessary for Electron 3 to a bug in Node.js 10.2.x which causes
the `removeAllListeners` method to no longer remove all listeners for any event
name when no argument is passed:
https://github.com/nodejs/node/pull/20924
This issue has been fixed in Node.js 10.3.0+ so we will have to remove this
workaround when we move to Electron 4.0 to avoid future event handler leaks.
2019-05-06 21:33:38 +02:00
David Wilson
a7af6c7568
Fix usage of deprecated Buffer APIs in render process
2019-05-06 20:27:56 +02:00
Jason Rudolph
0c51771244
Scroll line to center when opening file at specific line
2019-05-06 11:25:30 -04:00
Jason Rudolph
9921d1cef3
Unfold (if needed) when opening file at specific line
2019-05-06 11:24:26 -04:00
Rafael Oleza
18a308de57
Fix atom --dev with JSON config files
2019-05-06 14:00:41 +02:00
Max Brunsfeld
ef94657438
Add support for newlinesBetween property of injection points
2019-05-03 15:14:29 -07:00