Antonio Scandurra
570cfdeaff
Ignore resize events if they are delivered while the editor is hidden
2017-05-05 09:29:30 +02:00
Nathan Sobo
c36303e631
Avoid blowing away classes assigned on the editor element by packages
...
/cc @t9md
2017-05-05 09:29:30 +02:00
Nathan Sobo
c7228f6d81
Fix error when attaching soft-wrap editor in synchronous update mode
...
Taking the initial measurement was setting the soft wrap column, which
was triggering a display layer reset, which was scheduling an update.
This update occurred at an unexpected time causing an exception.
2017-05-05 09:29:30 +02:00
Nathan Sobo
bd6eedcc88
Eliminate strictly contained divs wrapping lines and highlights
...
I was hoping to strictly contain the layouts of highlights an lines
separately, since they are updated during different render phases.
Unfortunately, strict containment requires both divs to be positioned
absolutely. This in turn creates separate stacking contexts for lines
and highlights, which makes it impossible to render highlights in front
lines which themes sometimes need to do. For example,
atom-material-syntax pushes bracket matcher highlights to the front so
they are not obscured by the theme's solid black cursor line background.
/cc @as-cii. You should examine my work here and make sure I'm not
screwing something up with your line/block decoration update code.
2017-05-05 09:29:30 +02:00
Antonio Scandurra
72351481c7
Fix positioning for block decorations located at the beginning of a tile
2017-05-05 09:29:30 +02:00
Antonio Scandurra
638bb78ecb
Fix build failures
2017-05-05 09:29:30 +02:00
Nathan Sobo
82cdf80f25
Extract CursorsAndInputComponent
2017-05-05 09:29:30 +02:00
Nathan Sobo
1ca4c69c87
WIP: Start extracting gutter component
2017-05-05 09:29:30 +02:00
Nathan Sobo
305fd14cd9
Add TextEditorElement.pixelRectRangeForScreenRange for compatibility
2017-05-05 09:29:30 +02:00
Nathan Sobo
a5a80448cb
Add intersectsVisibleRowRange on TextEditorElement
2017-05-05 09:29:30 +02:00
Antonio Scandurra
6ed7cd97cc
Add highlight decoration classes to region elements as well
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-05-05 09:29:30 +02:00
Antonio Scandurra
4bcace1628
Don't remeasure scrollbars for mini editors
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-05-05 09:29:30 +02:00
Antonio Scandurra
37b5d2eb4d
Restore scrollbar positions correctly on reload
2017-05-05 09:29:30 +02:00
Antonio Scandurra
72d6316459
Fix shift-scroll on Windows and Linux
2017-05-05 09:29:29 +02:00
Antonio Scandurra
906b3b05d6
Update mock text editor in gutter-container-spec.coffee
2017-05-05 09:29:29 +02:00
Antonio Scandurra
6a083e14a2
Schedule component updates directly from the model
...
The only event-based APIs we kept are for listening to changes in block
decoration markers.
2017-05-05 09:29:29 +02:00
Nathan Sobo
5bbbe1d790
Give line numbers the full width of the line number gutter
2017-05-05 09:29:29 +02:00
Nathan Sobo
1cc68e408e
Add TextEditorComponent.screenPositionForPixelPositionSync
...
This method can be used to translate a pixel position to a screen
position even if the line is not currently rendered on screen.
2017-05-05 09:29:29 +02:00
Nathan Sobo
3d6921cca3
Add cursor decorations
...
These decorations allow the class and style of a cursor associated with
any marker to be customized.
/cc @t9md
2017-05-05 09:29:29 +02:00
Antonio Scandurra
3bca09bf27
Schedule update when setting scroll top row or scroll left column
2017-05-05 09:29:29 +02:00
Antonio Scandurra
e4659aad87
Add data-screen-row to line nodes
2017-05-05 09:29:29 +02:00
Antonio Scandurra
9d79b0189f
Fix cursor positioning around fold markers
2017-05-05 09:29:29 +02:00
Antonio Scandurra
1e6a1c61e7
Add middle mouse pasting on Linux
2017-05-05 09:29:29 +02:00
Antonio Scandurra
2f356f85d3
Make process.platform easier to mock
2017-05-05 09:29:29 +02:00
Nathan Sobo
b242f034b4
Don't render decorations for invalidated markers
2017-05-05 09:29:29 +02:00
Antonio Scandurra
c38da710ae
Don't remove non accented character from history, improve test coverage
...
Unfortunately Chromium does not trigger a `compositionstart` before
firing the text input event for the non accented character. Using `undo`
to remove such character from the history is risky because it could be
grouped with a previous change, thus making Atom undo too much.
With this commit we simply keep the behavior master exhibits as of
today. In the process of rewriting this code path, however, we fixed a
bug that occurred when opening the accented character menu while holding
another key, and improved test coverage as well by simulating the events
the browser triggers.
2017-05-05 09:29:29 +02:00
Nathan Sobo
24e03ee4e6
Fix pageUp/Down tests by using a real element
2017-05-05 09:29:29 +02:00
Nathan Sobo
f2070ef880
Restore editor scroll position across reloads
...
This commit introduces the concept of a scrollTopRow and
scrollLeftColumn which is used to query and update the logical scroll
position.
2017-05-05 09:29:29 +02:00
Antonio Scandurra
9ccfd3415c
Remeasure gutter dimensions when a gutter changes its visibility
2017-05-05 09:29:29 +02:00
Antonio Scandurra
2a688db26b
Add better test coverage for the mini and placeholder-text attributes
2017-05-05 09:29:29 +02:00
Antonio Scandurra
552fbf7915
Honor the gutter-hidden attribute correctly
2017-05-05 09:29:29 +02:00
Nathan Sobo
4c8fd0cb75
Add tests for TextEditorElement.setScrollTop/Left
2017-05-05 09:29:29 +02:00
Nathan Sobo
996e0462b7
Don't update synchronously in text-editor-element-spec
2017-05-05 09:29:29 +02:00
Nathan Sobo
129749f2ff
Set updatedSynchronously to false in text-editor-element-spec
2017-05-05 09:29:29 +02:00
Nathan Sobo
e232a868c5
Drop tests for set/getFirstVisibleScreenRow
...
These are now tested in text-editor-component-spec
2017-05-05 09:29:29 +02:00
Nathan Sobo
eb7cdf2a34
Delegate get/setFirstVisibleScreenColumn from the model to the component
2017-05-05 09:29:29 +02:00
Nathan Sobo
4f52637518
Delegate setFirstVisibleScreenRow from the model to the component
2017-05-05 09:29:29 +02:00
Nathan Sobo
493b735740
Delegate getFirst/LastVisibleScreenRow from model to component
2017-05-05 09:29:29 +02:00
Nathan Sobo
19f5535d68
Add back the measureDimensions method since some packages rely on it
...
Ideally, packages would resize and then wait for an update. But we set
up an example of calling measureDimensions directly in find-and-replace
so the easiest thing for now is just to keep this method around.
2017-05-05 09:29:29 +02:00
Nathan Sobo
69a29b2c58
Delegate (get|set)(Height|Width) to element
...
Rather than storing these values on the editor model.
2017-05-05 09:29:29 +02:00
Antonio Scandurra
55950f9594
Assign placeholder text on the model only when the attribute is present
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-05-05 09:29:29 +02:00
Antonio Scandurra
f7c55b9473
Honor the updateSynchronously parameter
2017-05-05 09:29:29 +02:00
Nathan Sobo
5b07334993
Assign bufferRow property to line number nodes
...
I wish we didn't need this, but it's currently relied on by several
packages including bookmarks.
2017-05-05 09:29:29 +02:00
Nathan Sobo
a536c5950a
Add TextEditorElement.pixelPositionForScreen/BufferPosition
...
These methods require us to render off-screen lines in some
circumstances in order to measure them, so this commit extends the
rendering of the longest line to include arbitrary lines.
2017-05-05 09:29:29 +02:00
Nathan Sobo
a9d0f82afb
Use async/await in text-editor-element-spec
2017-05-05 09:29:29 +02:00
Nathan Sobo
5000f9eccb
Convert text-editor-element-spec to JS
2017-05-05 09:29:29 +02:00
Nathan Sobo
c8f2fbb657
Get TextEditorElement tests passing
2017-05-05 09:29:29 +02:00
Nathan Sobo
eb33b5c39b
Delete obsolete code and tests related to text editor rendering
2017-05-05 09:29:29 +02:00
Nathan Sobo
bfa410b114
Add has-selection class to editors with non-empty selections
2017-05-05 09:29:29 +02:00
Nathan Sobo
f83ad6bb7c
Give cursors at the end of lines the width of an 'x' character
2017-05-05 09:29:29 +02:00
