Commit Graph

170 Commits

Author SHA1 Message Date
Kevin Sawicki
68964f1ca1 🏁 Don't crash when closing spec window
Focusing the window during the blur event that fires when the
window is closed currently crashes the app on Windows.

Closes #2485
2014-06-04 14:33:39 -07:00
Kevin Sawicki
c1ebbf36be Add missing l to global 2014-06-04 09:52:20 -07:00
Kevin Sawicki
8717547db4 Normalize resource path in remaining locations 2014-06-04 09:45:27 -07:00
Kevin Sawicki
7c4a32fffa Normalize resource path in AtomWindow constructor 2014-06-04 08:46:40 -07:00
Kevin Sawicki
b5703ff57a Normalize resource path before creating app
This ensures the drive letter case is consistent with the format
used by require.
2014-06-03 17:40:08 -07:00
Corey Johnson
8ed3b7a250 Merge pull request #2134 from erikhakansson/AdvancedContextMenu
Advanced context menu
2014-06-03 10:13:37 -07:00
Kevin Sawicki
4d65a220e2 Add support for a ATOM_DEV_RESOURCE_PATH env var
This is helpful on windows to set a default dev resource path that
isn't ~/github/atom since on Windows it is common to clone Atom to C:\atom
2014-06-02 12:38:33 -07:00
Erik Håkansson
3c8bfb8bc8 Context menus can now handle different types and commands, as well as submenus 2014-05-24 23:52:08 +02:00
Kevin Sawicki
ac70bfc456 Don't parse line and column if path to open exists
This previously prevented file containing a colon from being open
from the command line.

Closes #2376
2014-05-23 15:32:55 -07:00
Cameron McEfee
7882ac60d8 Include Terms of Use in the help menu 2014-05-14 10:44:33 -07:00
Stan Kardach
b4cb92af99 Fix #2152: Cast opened paths to string
path.resolve() was throwing an exception if given path was not a string.
When iterating through all given paths, each entry is casted by JS to
most suitable type and paths in form of a number (i.e. '1234') were
cast to Number, hence the bug.
2014-05-12 15:59:33 +02:00
Stan Kardach
19c7086200 Fix #2152: Cast opened paths to string
path.resolve() was throwing an exception if given path was not a string.
When iterating through all given paths, each entry is casted by JS to
most suitable type and paths in form of a number (i.e. '1234') were
cast to Number, hence the bug.
2014-05-11 17:29:24 +02:00
Kevin Sawicki
c75d36ef93 Implement application:open-license in AtomWindow
Allows the LICENSE.md file to be opened even when no windows are
open.

Closes #1624
2014-05-05 15:54:47 -07:00
Kevin Sawicki
66943c4820 Add application:open-safe command
This opens a new "safe mode" window similar to the application:open-dev
command
2014-05-01 15:20:22 -07:00
Kevin Sawicki
4ed9e34893 Tweak option description 2014-05-01 15:20:22 -07:00
Kevin Sawicki
4f4da78e54 Add --safe argument
This will launch Atom in "safe" mode where packages from ~/.atom
will not be loaded automatically or be resolveable by name.
2014-05-01 15:20:22 -07:00
Kevin Sawicki
cf62d3212c Use path.join instead of hard-coded separator 2014-04-30 16:07:26 -07:00
Kevin Sawicki
1367f08de8 Parse initial column from path to open argument 2014-04-30 16:07:26 -07:00
Cheng Zhao
f3168b2672 Use "closed" event instead of "destroyed".
The meaning of "destroyed" event has changed since atom-shell v0.12.0,
fixes #1910.
2014-04-30 12:25:59 +08:00
Cheng Zhao
9c06b4d344 Some events of browser-window have changed. 2014-04-29 15:25:36 +08:00
Cheng Zhao
f48241bc5e Use new IPC API of atom-shell. 2014-04-29 15:16:27 +08:00
Kevin Sawicki
c1260d68bb Restore window when opening path
Previously the window would stay minimized if it was triggered
from the command line and was already open.

Closes #1889
2014-04-22 16:58:53 -07:00
Kevin Sawicki
e37fc316fb Remove unneeded ?
AtomWindow always has a non-null browserWindow property
2014-04-17 11:42:57 -07:00
Kevin Sawicki
9128041c20 Include AtomWindow in command options
This ensures that all application commands can use it instead of relying
on the focused window.
2014-04-17 11:36:19 -07:00
Kevin Sawicki
be3a6bc6d0 Send context menu commands without focused window
The context menu always knows what window it is bound to so
start supporting running context menus on non-focused windows.

Previously these would either fail silently or log an error
if focusedWindow() returned null and the command wasn't guarding
against it.
2014-04-17 11:24:53 -07:00
Kevin Sawicki
7c1a7f52a5 📝 Use TomDoc in src/browser/ files 2014-04-11 10:50:33 -07:00
Kevin Sawicki
590c6be33d Add back dialog require used for path prompting
Closes #1861
2014-04-11 10:42:49 -07:00
Cheng Zhao
f37ca3e19c Add application:open-file and application:open-folder command. 2014-04-11 11:29:38 +08:00
Corey Johnson
613e05f4ac Merge pull request #1855 from atom/cj-remember-last-window-dimensions
Remember last window dimensions
2014-04-10 16:39:01 -07:00
Corey Johnson
e9a975fd92 Don't use version as a method 2014-04-10 14:42:51 -07:00
probablycorey
d72e3d9c81 Add AtomWindow::getWindowDimensions 2014-04-08 17:11:20 -07:00
probablycorey
6fcd905d4f Use windowDimensions instead of initialSize 2014-04-08 16:57:18 -07:00
probablycorey
4b089b62a6 Destructure item instead of calling it i 2014-04-07 17:01:11 -07:00
probablycorey
8ca5d6db35 Remove trailing whitespace 2014-04-07 15:29:15 -07:00
probablycorey
980c17e50c Pass current version to AutoUpdateManager 2014-04-07 15:28:42 -07:00
probablycorey
6613b9fd4d Don't send autoUpdateManager to ApplicationMenu 2014-04-07 15:19:48 -07:00
probablycorey
6bc471cef1 Only emit window:update-available event after window is loaded 2014-04-07 14:55:50 -07:00
probablycorey
4b3240eeee Use EventEmitter instead of emissary
To be consistent with other browser process classes
2014-04-07 14:55:12 -07:00
probablycorey
1f9de98eb2 Make AtomWindow emit window:loaded 2014-04-07 14:54:27 -07:00
probablycorey
7eea30fa7f Make new windows receive previously triggered update-available events 2014-04-07 14:26:07 -07:00
probablycorey
63e51af87d Move window_udpate-evailable emitter to method 2014-04-07 14:25:35 -07:00
probablycorey
bbc6433a75 Update comment 2014-04-07 14:18:16 -07:00
probablycorey
d4ae836225 Use hidden menu items for update processes 2014-04-07 14:17:44 -07:00
probablycorey
789f29e0b5 AutoUpdateManager barely works 2014-04-07 12:25:55 -07:00
probablycorey
f5ea098417 Don't overwrite menu item's metadata field 2014-04-07 11:04:55 -07:00
probablycorey
82081aa5e9 Rename methods 2014-04-07 10:21:37 -07:00
probablycorey
33adaab8b1 Add getMenu method 2014-04-07 10:21:25 -07:00
probablycorey
e21a1339a2 Use AutoUpdateManager 2014-04-07 10:20:32 -07:00
probablycorey
23d3405ae7 Rename to AutoUpdateManager
So it isn't confused with Atom Shell's auto-updater class
2014-04-07 09:38:36 -07:00
probablycorey
d39c422da9 Add content to AutoUpdater 2014-04-07 09:37:44 -07:00