Nathan Sobo
5566d54f58
Don’t update screen lines if DisplayBuffer has been destroyed
2015-07-09 15:44:11 -05:00
Nathan Sobo
c7d99140b9
Merge pull request #7638 from atom-community/jf-dispatch-grammar-used
...
Add activationHooks + Trigger `{grammar-package-name}:grammar-used` Hook When A text-editor-element's Grammar Is Set
2015-07-09 15:42:31 -05:00
Nathan Sobo
53162160bb
Merge pull request #7809 from atom/dh-register-views-earlier
...
Move view registration for Pane & Gutter related views earlier
2015-07-09 11:54:55 -05:00
Nathan Sobo
4567601ae9
Maintain change counts for debugging purposes
...
When we have an unexpected display-buffer or tokenized-buffer state,
we can include the change counts to make sure that every change to the
buffer has been processed by display-buffer and tokenized-buffer. If
they haven’t, there’s something wrong with our event ordering. If they
have, there’s a logic error somewhere else.
2015-07-09 02:18:24 -05:00
Nathan Sobo
afa6c9a786
Add invariant assertion about line count to see if we can find a bug
...
Does the line count ever get out of whack after an update, or is it
happening in some other way?
2015-07-09 01:55:13 -05:00
Nathan Sobo
028acbcae4
Don’t call method to read stack
...
If the line is undefined, we want the stack to be null.
2015-07-09 01:51:36 -05:00
Joe Fitzgerald
f954aa2732
Rename @hooks >> @ activationHookEmitter
2015-07-09 02:38:06 -04:00
Joe Fitzgerald
b3b046aa66
Add activationHooks To package.json
...
- Trigger the `{grammar-package-name}:grammar-used` hook when grammar is set for tokenized-buffer
2015-07-09 02:33:17 -04:00
Nathan Sobo
587e898867
Remove assertion since we call this with out of range rows legitimately
2015-07-09 00:28:46 -05:00
Nathan Sobo
de8d1d95d8
Add assertion about removing the last selection
2015-07-09 00:23:11 -05:00
Nathan Sobo
442e75853b
Base textNodeLength on textNode.textContent.length
...
This is how we were computing the length previously. Not sure what the
difference is but I want to keep it the same.
2015-07-09 00:18:42 -05:00
Nathan Sobo
a352a2ca61
Try to avoid exceptions due to undefined lines in TokenizedBuffer
2015-07-09 00:13:06 -05:00
Nathan Sobo
1dd1770b1a
Assert the liveness of editor model when attaching editor view
2015-07-09 00:13:05 -05:00
Kevin Sawicki
8bad01ca5b
Guard against null item like saveItem/saveItemAs does
2015-07-08 21:11:49 -07:00
Daniel Hengeveld
b13ee1c9cb
re-add Pane require
2015-07-08 17:21:39 -07:00
Daniel Hengeveld
afee699137
Move view registration for Pane & Gutter related views earlier
...
Registering them in pane-container led to packages deserializing
before e.g. Gutter was available.
2015-07-08 17:07:26 -07:00
Max Brunsfeld
c60c00f626
Ignore NaN coordinates passed to workspace.open
2015-07-08 16:50:17 -07:00
Kevin Sawicki
22f7379f32
Handle UNKNOWN open errors
2015-07-08 15:40:43 -07:00
Kevin Sawicki
27a94b4d70
Handle ENOTCONN open errors
2015-07-08 15:40:42 -07:00
Kevin Sawicki
955749b320
Handle EIO open errors
2015-07-08 15:40:42 -07:00
Kevin Sawicki
de4cf38dcc
Handle ENXIO open errors
2015-07-08 15:40:42 -07:00
Kevin Sawicki
770dc9821e
paneItem -> item for consistency
2015-07-08 15:40:42 -07:00
Kevin Sawicki
8c9ecbaf03
Add custom notification for ESPIPE
2015-07-08 15:40:42 -07:00
Kevin Sawicki
485f4dc3a3
Add custom notification for EINTR
2015-07-08 15:40:42 -07:00
Kevin Sawicki
c3e73bdd26
Add custom notification for EIO
2015-07-08 15:40:42 -07:00
Kevin Sawicki
3e744b0714
Add custom notification for ENOTSUP
2015-07-08 15:40:42 -07:00
Kevin Sawicki
7d88f9ea66
Use item path when error has no path
2015-07-08 15:40:42 -07:00
Nathan Sobo
cac74b9567
Merge pull request #7804 from atom/ns-clip-position
...
Clip positions in TokenizedBuffer::scopeDescriptorForPosition
2015-07-08 17:36:07 -05:00
Nathan Sobo
b953a11fa5
Clip positions in TokenizedBuffer::scopeDescriptorForPosition
2015-07-08 17:06:05 -05:00
Nathan Sobo
9c63de930e
Merge pull request #7798 from atom/ns-undefined-screen-line-metadata
...
Report extra metadata when screen lines are undefined when clipping
2015-07-08 17:01:29 -05:00
Sander van Harmelen
eaf814e5be
Improve auto indenting by removing a hard coded restriction and adding a 3rd regexp
...
Currently there are only two regexps that can influence the indents.
Those are `increaseIndentPattern` (which tells Atom the indent of next
line should be increased) and `decreaseIndentPattern` (which tells Atom
the indent of the current line should be decreased).
But I found that a couple of languages would need a 3rd regexp in order
to support their use cases. This 3rd regexp should be a mixture of the
existing two so it tells Atom that the indent of the next line should
decrease.
I’ll add a screencast to show a use case for this 3rd regexp which I
would like to call `decreaseNextIndentPattern`.
2015-07-08 20:30:21 +02:00
Nathan Sobo
3e7881f35f
Report extra metadata when screen lines are undefined when clipping
2015-07-08 13:29:25 -05:00
Nathan Sobo
a094142a45
Merge pull request #7778 from atom/ns-mb-suppress-line-measurement-exceptions
...
Suppress line measurement exceptions and gather data to solve them
2015-07-08 12:43:55 -05:00
Nathan Sobo
a13e002079
Use atom.getCurrentWindow()
2015-07-07 20:19:22 -05:00
Nathan Sobo
08fe81844c
Guard against IndexSizeError when measuring lines
...
Refs #7464 #7465 #5997
This will ask the user for the content of the offending line, but only
once so as not to be annoying. Hopefully this and the other data we’re
collecting will help us solve the problem.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-07-07 19:33:21 -05:00
Nathan Sobo
54549f916a
Change assertion API to pass error to callback
...
Don’t assume anything about metadata. Just give assertion callers access
to the error object.
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-07-07 19:29:23 -05:00
Nathan Sobo
4091fa9e78
Merge pull request #7770 from atom/ns-only-forward-menu-action-on-osx
...
Handle native chromium undo, redo, cut, copy, paste, selectAll on all platforms
2015-07-07 19:26:04 -05:00
Nathan Sobo
a4d716c491
Call native method on WebContents instead of sendActionToFirstResponder
...
Fixes #6587
2015-07-07 16:34:35 -05:00
Kevin Sawicki
a6dfbb2804
Remove string detail check
...
This appears to be in use by other packages
Refs atom/notifications#50
2015-07-07 13:46:53 -07:00
Kevin Sawicki
3a02b54851
details -> detail
2015-07-07 13:46:53 -07:00
Kevin Sawicki
93069fad75
Add stricter object checking
2015-07-07 13:46:53 -07:00
Kevin Sawicki
7fbcd147d5
Make Notification::getDetail public
2015-07-07 13:46:53 -07:00
Kevin Sawicki
4ba552c515
Valid message, options, and detail
2015-07-07 13:46:52 -07:00
Kevin Sawicki
2e2fef0c47
Merge pull request #7768 from atom/iz-more-guards-in-pane-error-handling
...
Guard against non-string messages in Pane.handleSaveError
2015-07-07 11:09:29 -07:00
Ivan Žužak
cd31770121
Guard against non-string messages in Pane.handleSaveError
2015-07-07 19:51:16 +02:00
Ross Allen
178fffa74e
Add 'name' arg docs to PackageManager functions
2015-07-07 10:49:45 -07:00
Kevin Sawicki
34d3dadd51
📝 Mention --include-deprecated-apis is not currently supported
2015-07-07 10:42:22 -07:00
Kevin Sawicki
b852b06724
Merge pull request #7717 from atom/iz-pane-handle-save-error
...
Check if error message exists before using it in Pane.handleSaveError
2015-07-07 10:14:28 -07:00
Kevin Sawicki
b371b2f0c9
Guard against missing stdout/stderr
2015-07-07 09:50:07 -07:00
Max Brunsfeld
1761f19efb
Merge pull request #7748 from atom/mb-emit-will-insert-text-on-paste
...
Emit will-insert-text event when pasting
2015-07-07 09:14:07 -07:00
