Antonio Scandurra
13f82280a0
💚 Fix presenter specs
2015-09-21 11:05:35 +02:00
Antonio Scandurra
4318de43c9
wip
2015-09-20 21:02:25 +02:00
Antonio Scandurra
af41b71cd8
Redesign LinesYardstick
2015-09-20 12:10:09 +02:00
Antonio Scandurra
7fafdbb6ab
Implement ::getStateForMeasurements(screenRows)
2015-09-18 14:00:04 +02:00
Antonio Scandurra
03507f7be3
Revert previous commit
2015-09-18 12:25:01 +02:00
Antonio Scandurra
b773b60c7b
🐛 Avoid creating a useless extra tile
2015-09-18 12:03:00 +02:00
Antonio Scandurra
96de78f264
🔥 Avoid computing top for line and line numbers
2015-09-18 11:36:18 +02:00
Antonio Scandurra
96d4bdb173
Revert changes to the presenter and the component
2015-09-18 10:35:29 +02:00
Antonio Scandurra
bf7d7e0d2a
Improve LinesYardstick design
...
We have shifted the responsibility of orchestrating state updates and
measurements to the yardstick. The presenter still needs to be updated to make
use of these new capabilities.
2015-09-18 10:17:55 +02:00
Antonio Scandurra
8a0d029ad1
🎨 Rename to ::onWillNeedMeasurements
2015-09-17 16:34:57 +02:00
Antonio Scandurra
2dd944f3ee
Trigger ::onWillMeasure before measuring anything
2015-09-16 12:07:57 +02:00
Antonio Scandurra
2750a384ac
💚 Fix TextEditorPresenter specs
...
...so that they play nicely with LinesYardstick
2015-09-16 11:33:51 +02:00
Antonio Scandurra
578b157da0
Differentiate between gutter and lines tiles
...
...and fix specs as well. 💚
2015-09-15 17:22:22 +02:00
Antonio Scandurra
8e06e06899
Compute the state for the longest line on screen
2015-09-15 16:32:42 +02:00
Antonio Scandurra
fe039a0f3c
💚
2015-09-09 13:31:34 +02:00
Antonio Scandurra
0d248e0c5b
Merge pull request #8500 from natthu/master
...
Fix a bug with refreshing the gutter UI.
2015-08-31 14:24:12 +02:00
Nathan Sobo
314e082f1d
Clean up max scroll margin code
...
Previously we were attempting the same computation twice, once
incorrectly when returning the scroll margins as integers and then doing
the same thing in terms of pixels. This just cleans up the original
calculation. It’s *slightly* different because it takes the floor to
continue returning integers, but the behavior is extremely close.
2015-08-27 17:40:01 -06:00
Natthu Bharambe
20aa3a6a87
Fix nits with the spec.
...
Summary:
Test Plan:
Reviewers:
CC:
Task ID: #
Blame Rev:
2015-08-27 08:38:05 -07:00
Natthu Bharambe
aba76015b0
Add a spec to verify gutter decorations are updated even if a higher priority gutter is hidden.
2015-08-26 15:17:03 -07:00
Antonio Scandurra
b5c0f5ac0b
Change lines container height based on boundingClientRect
2015-08-26 16:21:51 +02:00
Max Brunsfeld
a60f330628
Default maintainHistory marker option to false
2015-07-21 13:27:05 -07:00
Antonio Scandurra
4e4b49eef8
🐛 updateContentDimensions when model changes
2015-07-07 11:28:30 +02:00
Antonio Scandurra
ce3304b788
🔥 Delete redundant specs
2015-06-12 18:41:19 +02:00
Antonio Scandurra
605f584d2e
Extract tiles specs into tiledContentContract
2015-06-12 12:53:29 +02:00
Antonio Scandurra
d45fc8a41f
Port TextEditorPresenter specs
2015-06-12 12:10:55 +02:00
Antonio Scandurra
f73435e053
🐛 Delete partially off-screen markers which are empty
...
* 🔥 Delete old code which was used to support some non-batched
methods in a previous version;
* ✅ Cover “partially off-screen markers which are
empty” scenario, since that code path was not hit by previous specs
Fixes #7183
2015-06-09 21:35:01 +02:00
Antonio Scandurra
b68da1e19b
💚 Finish porting TextEditorPresenter specs
2015-06-06 10:51:35 +02:00
Antonio Scandurra
de766afee7
Start porting specs
2015-06-06 10:18:26 +02:00
Max Brunsfeld
f5895d8b0b
presenter: use 'markers-updated' event for state updates
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-06-03 17:58:44 -07:00
Antonio Scandurra
9b4d62b687
🐛 Update cursors after model changes
...
/cc: @nathansobo
2015-05-29 15:21:00 +02:00
Antonio Scandurra
b4dfb2a31b
Merge branch 'master' into as-tiled-rendering
2015-05-29 14:19:25 +02:00
Machiste Quintana
82958d5aa0
WIP: 👕 Fix even more linter errors
2015-05-22 17:03:06 -04:00
Antonio Scandurra
80a3294f8e
💚 Fix wrong spec
...
@nathansobo: I just forgot to include an actually visible tile in this
test which, therefore, complained. “Production code”-wise the behavior
was consistent and correct.
2015-05-22 14:05:21 +02:00
Nathan Sobo
1783415714
Fix spec failure
...
@as-cii this was just a typo, but there’s a failure later in the spec
that you’re probably in a better position to fix quickly.
2015-05-22 09:51:48 +02:00
Nathan Sobo
2379b3803f
Revert "Revert "Merge pull request #6757 from atom/ns-less-memory-for-tokens""
...
This reverts commit 7cb0bc3bc2
2015-05-21 19:56:52 +02:00
Nathan Sobo
7cb0bc3bc2
Revert "Merge pull request #6757 from atom/ns-less-memory-for-tokens"
...
This reverts commit 0cd1f110b5d75d202d33
2015-05-21 16:25:23 +02:00
Antonio Scandurra
490ab2c468
💚
...
Conflicts:
spec/text-editor-presenter-spec.coffee
src/lines-component.coffee
src/text-editor-presenter.coffee
2015-05-21 11:07:03 +02:00
Antonio Scandurra
299ee5dbf3
Merge branch 'master' into as-tiled-rendering
...
# Conflicts:
# spec/text-editor-presenter-spec.coffee
# src/lines-component.coffee
# src/text-editor-presenter.coffee
2015-05-21 10:46:52 +02:00
Antonio Scandurra
752dbf2c6e
Manually config tileSize
...
Dealing with a manually entered `tileSize` is actually easier to reason about,
therefore we no longer calculate it based on `tileCount.`
2015-05-21 09:59:58 +02:00
Antonio Scandurra
d116a33202
🔥
2015-05-18 11:56:41 +02:00
Antonio Scandurra
b66fdca057
Merge branch 'master' into as-tiled-rendering
...
Conflicts:
spec/text-editor-presenter-spec.coffee
2015-05-18 11:49:12 +02:00
Nathan Sobo
3dcf9a4c66
Merge remote-tracking branch 'origin/master' into ns-less-memory-for-tokens
2015-05-16 03:05:11 +02:00
Kevin Sawicki
3a51c44b55
👕 Use skinny arrow for afterEach
2015-05-14 17:03:48 -07:00
Antonio Scandurra
e7ddb3d8ad
💚 Fix all TextEditorPresenter specs
2015-05-14 15:54:53 +02:00
Antonio Scandurra
5b23a002cf
💚 Fix position specs
2015-05-14 15:54:45 +02:00
Jess Lin
57d0887346
[Gutter] Move line number gutter tests to be under .gutters in TextEditorPresenter specs
2015-05-13 16:47:42 -07:00
Jess Lin
e34dfc636c
[Gutter] Fix custom decorations tests in TextEditorPresenter specs
2015-05-13 16:47:42 -07:00
Jess Lin
cd806ee764
[Gutter] Fix former .sortedDescription tests in TextEditorPresenter specs
2015-05-13 16:47:42 -07:00
Jess Lin
b6055f3a67
[Gutter] Fix shared gutter styles tests in TextEditorPresenter specs
2015-05-13 16:47:42 -07:00
Jess Lin
fdb696f4dc
[Gutter] Fix line-number gutter tests in TextEditorPresenter specs
2015-05-13 16:47:42 -07:00
