Ash Wilson
fa5a1d3361
Respect the class overlay decoration property.
2015-07-27 11:38:01 -04:00
Machiste Quintana
5d2392ea67
👕 Fix new coffeelint errors
2015-04-06 23:59:54 -04:00
Ben Ogle
e29b8416a1
Always add the item to the parent.
2015-04-01 17:41:00 -07:00
Ben Ogle
b0794bbb68
Move the overlay calculation into the presenter.
2015-04-01 17:40:59 -07:00
Ben Ogle
c62f06af9d
Cache the overlay dimensions in the presenter
2015-04-01 17:40:59 -07:00
Ben Ogle
0fa03f15b6
Update overlay rendering
2015-04-01 17:40:59 -07:00
Antonio Scandurra
0dca5a5fcd
Encapsulate state update inside TextEditorPresenter#getState
2015-02-28 09:25:53 +01:00
Nathan Sobo
d337c88aea
Delete overlay node from hash before removing
2015-02-19 17:14:57 -07:00
Nathan Sobo
c06e100fae
Make LinesComponent a normal object instead of a React component
...
Also, remove ability to disable hardware acceleration since there’s
no longer a need for it and it complicated this conversion.
2015-02-19 17:14:53 -07:00
Nathan Sobo
4f5b989cbb
Use property instead of non-existent method in OverlayManager
2015-02-11 23:04:49 -07:00
Nathan Sobo
77599c799c
Rename TextEditorPresenter::height to ::explicitHeight
...
This clarifies that the height is being assigned externally rather than
derived from the content.
2015-02-04 15:10:58 -07:00
Nathan Sobo
0a6116a785
Fix undefined method errors in overlay manager
...
Access properties directly now
2015-02-03 15:05:43 -07:00
Nathan Sobo
bbc1a264b5
Make each section of presenter state self-contained
...
This means we have some duplicated values in different parts of the
tree, but it’s cleaner in the view since each component only consumes
a single object. Seems like the presenter should convey the correct
data to the correct locations and minimize the logic in the view. A
few duplicated integers is a reasonable trade-off.
2015-02-03 15:05:31 -07:00
Nathan Sobo
42ab02d7d2
Rename ::clientHeight/Width to ::height and ::contentFrameWidth
...
The term “client” was actually a misnomer here because it typically
means the height excluding the scrollbars, which wasn’t how we were
using it here.
2015-02-03 15:05:30 -07:00
Nathan Sobo
9d7285d04a
Use presenter for rendering overlay decorations
...
We’re still doing some sync DOM reads and computation in the view that
should eventually be made async and moved into the presenter, but I’m
going to leave it alone for now.
2015-02-03 15:05:25 -07:00
Nathan Sobo
a5580a704d
Remove unused properties in EditorComponent and children
2015-02-03 15:05:25 -07:00
Nathan Sobo
1e50985ec7
Add ‘position’ option to overlay decorations
...
By default overlays are positioned at the head of the given marker.
This option allows them to be positioned at the tail instead by passing
`position: ’tail’` when creating the decoration, which is useful for
autocomplete.
2014-11-26 12:29:52 -07:00
Ben Ogle
b369a1085c
Use headPixelPosition in overlay decoration rendering
2014-11-12 14:43:52 -08:00
Ben Ogle
eae80ca46d
Add a check for negative bounds when translating the overlay
2014-11-12 11:50:22 -08:00
Ben Ogle
12b9f232c2
💄
2014-11-11 16:39:30 -08:00
Ben Ogle
97a671cb49
Works with the shadow DOM disabled.
2014-11-11 16:30:22 -08:00
Ben Ogle
9dfaa8a4e5
Add bounds checking for overlay decorations
2014-11-11 15:46:27 -08:00
Ben Ogle
9399e00033
Properly display when a marker is reversed
2014-11-11 13:32:13 -08:00
Ben Ogle
307108ec6c
Specs for positioning the overlay decorations
2014-11-11 13:08:05 -08:00
Ben Ogle
6538da22a6
Fix linter error
2014-11-11 11:25:36 -08:00
Ben Ogle
c79db992d9
Overlay decorations render
2014-11-11 11:25:36 -08:00
