Michael Bolin
318498464a
Responded to all of @maxbrunsfeld's comments except for:
...
* The effect of a failed search.
* Letting `DirectorySearcher::search` take multiple directories.
I'm working on those now.
2015-06-09 15:34:09 +01:00
Michael Bolin
5fc9d9e01a
Document and test the cancel() method on the object returned by atom.workspace.scan().
2015-06-09 15:34:09 +01:00
Michael Bolin
f7e822d41f
Make delegate method names more delegate-like.
2015-06-09 15:34:09 +01:00
Michael Bolin
4eb30f3925
Switch to the delegate pattern,
...
eliminating a nasty race condition and deleting a lot of code.
2015-06-09 15:34:09 +01:00
Michael Bolin
fa3fd9c50c
Remove empty param lists as per the linter.
2015-06-09 15:34:08 +01:00
Michael Bolin
735bdcca08
Two things:
...
1. Update documentation for `default-directory-search.coffee`.
2. Ensure that multiple `DirectorySearch` searches are run in series rather than in parallel to conserve resources.
2015-06-09 15:34:08 +01:00
Michael Bolin
fd670a4dd4
Remove myResolve local variable that I was using for debugging.
2015-06-09 15:34:08 +01:00
Michael Bolin
4330c3a181
Fix some nits I found during my self-review.
2015-06-09 15:34:08 +01:00
Michael Bolin
7294e0cda4
Change DirectorySearcher to return a DirectorySearch.
2015-06-09 15:34:08 +01:00
Michael Bolin
986640f670
Respond to comments from @maxbrunsfeld and @kevinsawicki.
2015-06-09 15:34:08 +01:00
Michael Bolin
7781e34ba2
Introduce atom.directory-searcher service v0.1.0.
...
The contract for a provider for the `atom.directory-searcher` service
is defined by the spec of the `DefaultDirectorySearcher`.
This modifies `Workspace::scan()` to use the appropriate `DirectorySearcher`
for each member of `atom.project.getDirectories()` when scanning the workspace
for files that match the specified regex.
2015-06-09 15:34:08 +01:00
Antonio Scandurra
119f297280
Merge branch 'master' into as-tiled-gutter
...
Conflicts:
src/lines-component.coffee
src/text-editor-presenter.coffee
2015-06-09 11:22:25 +02:00
Machiste Quintana
f9c612d1c8
Use an empty object if metadata is ~null
2015-06-08 21:33:07 -04:00
Machiste Quintana
07da68c95e
Don't reassign metadata.name
2015-06-08 21:18:21 -04:00
Machiste Quintana
d78bc3f234
🎨
2015-06-08 21:14:11 -04:00
Machiste Quintana
0f876a73cc
Only use package directory name as fallback
...
Fixes https://github.com/atom/atom/issues/7174
2015-06-08 20:45:41 -04:00
Nikhil Narula
50f4fe5b6c
Correct isMaximixed misspelling to isMaximized
2015-06-08 20:43:13 -04:00
Jesse Grosjean
6cdc555a93
Clone options parameter before modifying it.
2015-06-08 20:40:15 -04:00
Kevin Sawicki
efb2ea544f
Merge pull request #7158 from atom/wl-downloading-update
...
Enable "Downloading Update" context menu entry
2015-06-08 15:36:31 -07:00
Kevin Sawicki
6859a2924a
Keep upgrading deprecated selectors until 1.0
2015-06-08 15:35:22 -07:00
Nathan Sobo
5c57cb0cfe
Show a warning prompt when opening files over 20MB
...
We still have some trouble on files this large. I want to show a
progress bar, but for now this is better than freezing without any
warning at all.
2015-06-09 00:02:36 +02:00
Nathan Sobo
36d55c9384
Don’t break out soft tabs that are interrupted by a scope boundary
2015-06-08 22:56:32 +02:00
Jesse Grosjean
1dbfd0b5ac
Rename to getSaveDialogOptions and document in TextEditor
2015-06-08 16:20:53 -04:00
Jesse Grosjean
656c91beb4
Preserve previous API behavior
2015-06-08 16:19:39 -04:00
Antonio Scandurra
29ab1af2bf
Merge pull request #7127 from atom/as-opaque-tiles
...
Bring Subpixel Anti-Aliasing Back
2015-06-08 20:51:02 +02:00
Antonio Scandurra
cec6959e08
Extend highlights to the full editor width
2015-06-08 18:58:04 +02:00
Kevin Sawicki
89de8cd185
Merge pull request #7169 from atom/mq-docs-get-repositories
...
Update Project::getRepositories() example
2015-06-08 09:31:07 -07:00
Machisté N. Quintana
0db3b70177
📝 Update Project::getRepositories() example
2015-06-08 10:59:34 -04:00
Wliu
9e6e05a5a6
Put 'update-available' in @downloadUpdate instead
...
So that it only shows up when there's an actual update
2015-06-07 11:33:26 -04:00
Wliu
ca72b802ac
Enable "Downloading Update" context menu entry
...
Previously 'update-downloaded' would get emitted right after 'update-available' which would suppress the "Downloading Update" menu entry
2015-06-07 11:23:42 -04:00
Thomas Johansen
fbf58d0725
📝 Remove mention of WorkspaceView which no longer exists
...
Fixes #7146
2015-06-07 09:30:10 +02:00
Devon Carew
786f3399ad
Update text-editor.coffee
...
Fix a type in `src/text-editor.coffee` (`adter` => `after`).
2015-06-06 22:17:14 -07:00
Jesse Grosjean
f88e21cbb0
Allow items to provide savePanel options.
2015-06-06 22:21:51 -04:00
Antonio Scandurra
465043f213
🔥
2015-06-06 16:22:33 +02:00
Antonio Scandurra
047a405290
Merge branch 'master' into as-opaque-tiles
2015-06-06 11:16:31 +02:00
Antonio Scandurra
de766afee7
Start porting specs
2015-06-06 10:18:26 +02:00
Antonio Scandurra
f7b82f2411
🔥
2015-06-06 09:31:38 +02:00
Antonio Scandurra
8319eae0d7
🔥 Delete unused code
2015-06-06 09:29:40 +02:00
Antonio Scandurra
11202ebb69
🎨
2015-06-06 09:15:10 +02:00
Antonio Scandurra
cf70739bf1
Don't clip when building highlight regions
2015-06-06 08:34:28 +02:00
Nathan Sobo
6bba381393
Merge pull request #7130 from atom/ns-large-file-mode
...
Load large files with fewer features but much better performance
2015-06-06 00:05:27 +02:00
Nathan Sobo
88812831ce
Only check for max line length when lines exist
2015-06-05 23:40:56 +02:00
Max Brunsfeld
2732e0dcac
presenter: 🔥 redundant decoration state updates
2015-06-05 13:31:24 -07:00
Nathan Sobo
48ce361bd0
Select grammars based on first 10 lines of content, not the entire file
2015-06-05 22:24:49 +02:00
Nathan Sobo
56273e7eef
Preserve large file mode across serialization and pane splits
2015-06-05 21:44:23 +02:00
Nathan Sobo
efd4662de0
Don’t allow soft wrap to be enabled in large file mode
2015-06-05 21:36:20 +02:00
Nathan Sobo
639647d115
Disallow fold creation in large file mode
2015-06-05 21:31:06 +02:00
Nathan Sobo
c34838277d
In largeFileMode, base maxLineLength on the longest line we’ve seen
...
This is pretty hacky. If we want to compute the true longest line, we’ll
need to process every line, which is what large file mode is designed
to avoid. So now whenever the display buffer returns a line, it has
the potential to update the longest line.
This is a bit weird because retrieving a line now has a side effect.
It’s even more weird because the longest line will actually be wrong for
the initial state updates in the TextEditorPresenter. But as soon as
the user interacts in any way the dimensions are recomputed, so it works
for now.
A better approach may be to set a visible region on the display buffer.
But I’d like to keep this low-touch until we have a chance to revisit
the design of DisplayBuffer in a bigger way.
2015-06-05 19:55:34 +02:00
Antonio Scandurra
b3c9a9a77d
🐛 Correctly display highlight regions
2015-06-05 18:33:32 +02:00
Nathan Sobo
c37caaf59d
Merge pull request #7125 from atom/ns-fix-scope-descriptor-for-position
...
Use buffer coordinates in TokenizedBuffer::scopeDescriptorForPosition
2015-06-05 18:30:17 +02:00
