Commit Graph

12724 Commits

Author SHA1 Message Date
Nathan Sobo
26c56b1906 Merge branch 'master' of github.com:github/atom 2012-03-20 17:11:44 -06:00
Nathan Sobo
50f11f1a4c Remove fixed editor subview from root view. 2012-03-20 16:55:33 -06:00
Nathan Sobo
8ea4b4eb72 File finder opens selected file in the most recent pane.
Only editors inside #root-view #panes are tracked as the most recent active editor. Otherwise the file finder tries to open the selected file in its own mini editor.
2012-03-20 15:51:22 -06:00
Nathan Sobo
965e66ffd4 Focus most-recently active editor pane when file finder closes. 2012-03-20 15:11:34 -06:00
Corey Johnson
6ae39f167b loads ~/.atom/index.coffee when window is loaded 2012-03-20 13:32:26 -07:00
Nathan Sobo
55efb65500 Merge branch 'master' of github.com:github/atom 2012-03-20 13:09:48 -06:00
Nathan Sobo
4748b4e09b Remove row/columns from split pane layout when they become empty.
This fixes layout issues when closing split panes.
2012-03-20 13:09:35 -06:00
Nathan Sobo
285c04ea62 WIP: Split panes can be closed with meta-w
Still some issues… view gets screwed up after closing panes in certain layout arrangements.
2012-03-20 12:29:47 -06:00
Corey Johnson
99e3074c25 Previously focused element regains focus when file finder is removed 2012-03-20 11:05:57 -07:00
Corey Johnson
cd17cb6de3 <escape> removes file finder 2012-03-20 10:31:03 -07:00
Nathan Sobo
81e5a10ddd Perform vim-style editor pane splitting
Using percentage dimensions to absolutely position the panes on screen where they need to be located. Flexbox would have been nice, but unfortunately I could not work around what seem to be bugs (or at least major inconveniences) in its current implementation.
2012-03-19 16:48:13 -06:00
Nathan Sobo
5b145f64c2 Add vertical splitting. Still some issues with some nested arrangements. 2012-03-19 12:15:37 -06:00
Nathan Sobo
509bac15b6 Cursor is colored / blinks on on focused editor pane 2012-03-19 09:31:03 -06:00
Corey Johnson & Nathan Sobo
1437858241 Implement split-left 2012-03-19 09:22:13 -06:00
Corey Johnson & Nathan Sobo
9bd6751a46 Don't move the cursor on buffer change unless the editor is focused
Add a boolean isFocused flag to editor that is assigned when the hidden input gains / loses focus. This makes it easier in specs because we can treat the editor as if its focused without having to add it to the DOM. It's also a bit more abstract.
2012-03-19 09:04:39 -06:00
Corey Johnson & Nathan Sobo
2903126047 When editor is split, set same cursor position on new editor and focus it. 2012-03-19 08:48:16 -06:00
Corey Johnson & Nathan Sobo
8add398e9c Merge branch 'master' of github.com:github/atom 2012-03-19 08:34:53 -06:00
Corey Johnson & Nathan Sobo
2e42df3401 WIP: alt-meta-right splits editor pane to the right 2012-03-19 08:34:37 -06:00
Corey Johnson & Nathan Sobo
f8b6bf0de6 Folds can end on the penultimate screen line of a wrapped buffer line 2012-03-16 16:26:31 -07:00
Corey Johnson & Nathan Sobo
4e8847289d 💄 2012-03-16 15:34:53 -07:00
Corey Johnson & Nathan Sobo
b31bef4ea0 When updating folds, don't modify the array over which we're iterating 2012-03-16 16:31:52 -06:00
Corey Johnson & Nathan Sobo
67d017f3f4 Fix bug where destroying a fold on last screen line of wrapped line caused an artifact. 2012-03-16 16:11:44 -06:00
Corey Johnson & Nathan Sobo
7336e8313c Folds can be created on the penultimate screen line of a wrapped buffer line 2012-03-16 14:35:07 -07:00
Corey Johnson & Nathan Sobo
3b46ce84e6 expandBufferRangeToLineEnds works for ranges that are folded on screen 2012-03-16 13:33:11 -07:00
Corey Johnson & Nathan Sobo
45c825e76c Report proper screen ranges on change events for folds created on wrapped lines 2012-03-16 13:33:11 -07:00
Nathan Sobo
da75f8a6ff Explicitly focus editor when file finder is closed.
Trying to catch focusout events on anything other than the editor was really error-prone and ultimately more abstraction than we need right now. This fixes a bug where we would lose the ability to input text after clicking on the editor element.
2012-03-16 05:58:12 -06:00
Nathan Sobo
174c4e18cc Fix scrolling misbehavior and display artifacts.
Switching back to the new flexbox and re-introducing a scrollable-content node that the flexbox is applied to. This has no height settings so it grows to contains the gutter and lines. The editor outside of it has a width / height of 100% of its container plus overflow-y of scroll. Trying to apply flexbox AND a 100% height + scroll all to the editor causes display artifacts.
2012-03-16 05:41:43 -06:00
Corey Johnson & Nathan Sobo
fd5439f357 Simplify layout and prevent scrollbar flash when toggling file finder. 2012-03-15 17:18:26 -06:00
Nathan Sobo
0efee25ded Cleanup keybindings after app spec. 2012-03-15 16:22:02 -06:00
Nathan Sobo
6bdba313d1 Don't add to the same window to the atom.windows array twice 2012-03-15 16:10:55 -06:00
Nathan Sobo
60056e57fb Use an editor in the file finder instead of an input element. 2012-03-15 13:41:37 -06:00
Nathan Sobo
3515591d58 Fix bug where you couldn't use backspace, delete, arrow keys in file finder.
Bind all these movement keys only to editor for now, because they're interfering with the default input behavior.
2012-03-14 19:17:32 -06:00
Nathan Sobo
04fce8067f Add some temporary logging to debug intermittent spec failure. 2012-03-14 19:15:59 -06:00
Nathan Sobo
8b0d79b589 Don't call shutdown on close event. The window is closing anyway. 2012-03-14 19:00:31 -06:00
Nathan Sobo
f88bfc1ab0 Use _.remove to remove windows from atom.windows array 2012-03-14 19:00:15 -06:00
Nathan Sobo
601cf41108 Fix bug where file-finder pushed editor up.
For now, I'm removing the flexbox treatment of #app-vertical because the file finder just needs to overlay the bottom and absolute positioning is simpler. I'm also using requireStylesheet to load the file finders CSS instead of a link tag.
2012-03-14 18:28:23 -06:00
Nathan Sobo
5bf9925d0a Unsubscribe from Buffer when an Editor is removed from the DOM. 2012-03-13 19:20:40 -06:00
Nathan Sobo
8cd0b23cd4 Fix bug where render ids were NaN 2012-03-13 19:20:12 -06:00
Nathan Sobo
eb92966acd Fully unsubscribe from previous buffer when setting a new buffer 2012-03-13 19:05:48 -06:00
Nathan Sobo
5e5a5bdfa5 Add EventEmitter.subscriptionCount 2012-03-13 19:05:24 -06:00
Nathan Sobo
e1283e1788 Add event namespacing to EventEmitter. 2012-03-13 18:17:43 -06:00
Nathan Sobo
4c79b43c52 Add _.remove, which removes an element from an array in place 2012-03-13 18:17:27 -06:00
Nathan Sobo
da3e1d4553 Every Buffer gets its own UndoManager. 2012-03-13 16:24:12 -06:00
Nathan Sobo
7d2d0f2037 Add a drop shadow to gutter when horizontal scroller is scrolled right. 2012-03-13 16:09:11 -06:00
Nathan Sobo
5709b0d152 Now we can force line wrapping in specs without editor being on the DOM. 2012-03-13 15:56:24 -06:00
Nathan Sobo
06a3f3d376 Fix exception when auto-indenting after fold placeholder.
Propagate state when splitting and concatenating screen line fragments, because we were passing an undefined state to the auto-indenter.
2012-03-13 15:50:43 -06:00
Nathan Sobo
826bf6ec61 Editor recalls cursor position and scroll state when a previously edited buffer is re-assigned. 2012-03-13 15:25:20 -06:00
Nathan Sobo
a96e09f6d1 When soft wrap is on, don't position hidden input beyond width of horizontal scroller. 2012-03-13 12:14:08 -06:00
Nathan Sobo
8d432c02c1 Fix bug where text typed into empty buffer was on the wrong line. 2012-03-13 12:12:52 -06:00
Nathan Sobo
43fbfba68d 💄 2012-03-12 19:47:25 -06:00