Commit Graph

12675 Commits

Author SHA1 Message Date
Antonio Scandurra
5a2e4ba2aa Merge branch 'master' into as-double-reflow-measurements
# Conflicts:
#	src/text-editor-presenter.coffee
2015-09-18 09:02:50 +02:00
Nathan Sobo
6b66bf7b0a Fix use of _atomModuleCache in getNativeModuleDependencyPaths
Previously, we weren’t converting the relative path from the module
cache and the test wasn’t strong enough to detect this fact.
2015-09-17 17:21:52 -06:00
Nathan Sobo
0717c1d377 Merge PR #8826 into stable 2015-09-17 16:29:03 -06:00
Chen Shen
20dcdf77a4 update 2015-09-17 09:52:00 -07:00
Chen Shen
7ea141b376 add 2015-09-17 09:09:57 -07:00
Antonio Scandurra
63a282750a 📝 Fix typo 2015-09-17 17:17:14 +02:00
Antonio Scandurra
3575928cce Move continuous reflow setting into TextEditorElement 2015-09-17 17:14:00 +02:00
Antonio Scandurra
91bb8f518d Merge branch 'master' into as-continuous-reflow 2015-09-17 16:58:37 +02:00
Antonio Scandurra
8a0d029ad1 🎨 Rename to ::onWillNeedMeasurements 2015-09-17 16:34:57 +02:00
Antonio Scandurra
2ad336c649 💚 2015-09-17 16:26:55 +02:00
Antonio Scandurra
be843cc4df 🐎 Cache positions 2015-09-17 14:22:27 +02:00
Antonio Scandurra
65167727e7 Merge branch 'master' into as-double-reflow-measurements 2015-09-17 12:41:54 +02:00
Antonio Scandurra
fd1c20ed2a Explicit returns on DOMElementPool 2015-09-17 12:16:24 +02:00
Antonio Scandurra
80d872c4ac Avoid calling getBoundingClientRect twice for each line 2015-09-17 11:51:03 +02:00
Antonio Scandurra
d78c166d6b Merge branch 'master' into as-double-reflow-measurements 2015-09-17 11:32:26 +02:00
Antonio Scandurra
3fe34ed748 Merge pull request #8783 from atom/as-recycle-nodes
Recycle DOM nodes
2015-09-17 11:17:01 +02:00
Antonio Scandurra
42e58f1dd3 💚 Use tokenizedLine.id to refer to lines 2015-09-17 11:10:32 +02:00
Antonio Scandurra
751f5920b4 🎨 2015-09-17 10:50:18 +02:00
Antonio Scandurra
c6948b36dc Clear pool after updating 2015-09-17 10:38:40 +02:00
Antonio Scandurra
8b52538213 Pool highlight elements 2015-09-17 10:35:20 +02:00
Max Brunsfeld
f79b3abe3f Avoid incorrect character replacement when initially typing in text-editor
It seems that chrome now automatically selects all text in an input element
when its containing shadow root gains focus, as if it had been reached by
typing tab. Setting the input's tabindex to -1 prevents this behavior.

Signed-off-by: Nathan Sobo <nathan@github.com>
2015-09-16 13:41:16 -07:00
Antonio Scandurra
bae4d7d336 🔥 2015-09-16 17:59:04 +02:00
Antonio Scandurra
2542a8d603 Integrate LinesYardstick with TextEditorComponent 2015-09-16 12:32:26 +02:00
Antonio Scandurra
2dd944f3ee Trigger ::onWillMeasure before measuring anything 2015-09-16 12:07:57 +02:00
Antonio Scandurra
2750a384ac 💚 Fix TextEditorPresenter specs
...so that they play nicely with LinesYardstick
2015-09-16 11:33:51 +02:00
Antonio Scandurra
29846d0a51 Add LinesYardstick
...and create a MockLineNodesProvider for testing purposes
2015-09-15 18:41:41 +02:00
Antonio Scandurra
398fb1f62d 🔥 Avoid mounting the container in ctor
...as it will be mounted anyways when updateSync gets called
2015-09-15 17:50:21 +02:00
Antonio Scandurra
346c7d9b37 Defer state building in TextEditorPresenter 2015-09-15 17:44:31 +02:00
Antonio Scandurra
1cdc7ae5a0 Decouple horizontal dimensions computation from vertical ones
The former needs measurement and, therefore, depends on the latter.
2015-09-15 17:30:47 +02:00
Antonio Scandurra
578b157da0 Differentiate between gutter and lines tiles
...and fix specs as well. 💚
2015-09-15 17:22:22 +02:00
Antonio Scandurra
a6c13d097a Render the longest screen row without painting it 2015-09-15 16:53:55 +02:00
Antonio Scandurra
8e06e06899 Compute the state for the longest line on screen 2015-09-15 16:32:42 +02:00
Antonio Scandurra
4c5101a7e1 🎨 Refactor ::updateTilesState to a composed method 2015-09-15 15:44:06 +02:00
Antonio Scandurra
f8868ffcf2 Clear dataset elements for pooled objects 2015-09-15 12:23:53 +02:00
Antonio Scandurra
ad83a03440 Merge branch 'master' into as-recycle-nodes
# Conflicts:
#	src/line-numbers-tile-component.coffee
#	src/lines-tile-component.coffee
2015-09-15 11:50:54 +02:00
Antonio Scandurra
c7d4871453 Merge pull request #8730 from atom/as-faster-style-recalculation
Faster Style Recalculations
2015-09-15 11:25:10 +02:00
Antonio Scandurra
daf4316974 Clear the pool when font or lineHeight change 2015-09-15 10:59:32 +02:00
Antonio Scandurra
f86c9b2331 Let TextEditorComponent manage DOMElementPool 2015-09-15 10:58:24 +02:00
Antonio Scandurra
c8c69a99b9 Release free nodes after destroying TextEditor 2015-09-15 10:36:47 +02:00
Antonio Scandurra
ce4281821d Replace insertAdjacentText with textContent 2015-09-14 20:31:21 +02:00
Antonio Scandurra
663de4c8d6 Use textContent instead of innerText 2015-09-14 20:28:09 +02:00
Antonio Scandurra
f0bc6ca23a 🎨 Some renaming 2015-09-14 20:27:25 +02:00
Antonio Scandurra
e9bf04b50b Guard against some edge cases 2015-09-14 20:21:37 +02:00
Antonio Scandurra
4349b152d5 🎨 2015-09-14 18:22:31 +02:00
Antonio Scandurra
f52e000bec 🔥 Remove unused code 2015-09-14 18:14:12 +02:00
Antonio Scandurra
536a5f4395 🐎 Save an allocation while removing nodes 2015-09-14 17:44:57 +02:00
Antonio Scandurra
6b2e7a6765 🎨 2015-09-14 17:36:45 +02:00
Antonio Scandurra
93ed0853a2 Recycle gutter nodes 2015-09-14 17:25:30 +02:00
Antonio Scandurra
ece15b2a24 Recycle tile nodes (and descendants) 2015-09-14 14:48:30 +02:00
Antonio Scandurra
ccb8623a88 🎨 Extract a buildElement helper function 2015-09-14 12:01:33 +02:00