Commit Graph

275 Commits

Author SHA1 Message Date
Max Brunsfeld
5aee514ef5 🔥 debuggers 2015-10-07 15:25:05 -05:00
Antonio Scandurra
464cfd4474 Don't use atom.confirm in Workspace 2015-10-07 15:25:02 -05:00
Nathan Sobo
122bf72c75 Don’t use atom.packages global in TokenizedBuffer 2015-10-07 15:25:00 -05:00
Nathan Sobo
b2359f44a6 Don’t use atom.grammars global in TokenizedBuffer 2015-10-07 15:25:00 -05:00
Nathan Sobo
dc0709ef9e Don’t use atom.assert global in DisplayBuffer 2015-10-07 15:24:59 -05:00
Nathan Sobo
b729a9bb37 Parameterize project on TextEditor 2015-10-07 15:24:59 -05:00
Nathan Sobo
8d7a08d07f Parameterize view registry on TextEditor 2015-10-07 15:24:59 -05:00
Nathan Sobo
e803801145 Parameterize clipboard on TextEditor 2015-10-07 15:24:59 -05:00
Nathan Sobo
ad57dca1f7 Remove dead registerEditor parameter 2015-10-07 15:24:58 -05:00
Nathan Sobo
979963a25c Parameterize notification manager on TextEditor 2015-10-07 15:24:58 -05:00
Nathan Sobo
51abab930d Parameterize config on editor instead of using global atom.config 2015-10-07 15:24:58 -05:00
Nathan Sobo
eb2ace37b4 Move TextEditor construction to Workspace
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-10-07 15:24:56 -05:00
Max Brunsfeld
eb68c9135e Don't use atom global in default commands
Signed-off-by: Nathan Sobo <nathan@github.com>
2015-10-07 15:24:55 -05:00
Nathan Sobo
156cdfaf31 Move Workspace.deserialize to an instance method
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-10-07 15:24:55 -05:00
Nathan Sobo
fd7fbbfea5 Move PaneContainer.deserialize to an instance method
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-10-07 15:24:55 -05:00
Nathan Sobo
e0d426b817 Register deserializers, view providers, and commands in Atom constructor
Previously, these registrations were scattered all over the codebase and
required that `global.atom` be defined, which creating weird ordering
issues. Registering them all from the global makes the relationships
clearer and means we don’t have to assign a global to set up a fully-
functional environment.
2015-10-07 15:24:52 -05:00
Max Brunsfeld
a9531fc4dd Install atom command as 'atom-beta' when using beta version 2015-09-23 14:10:07 -07:00
Nathan Sobo
50ce1c4afc Guard against undefined state in Workspace.deserialize 2015-09-23 10:16:59 -06:00
Nathan Sobo
3d4ed37f81 Don’t use Serializable mixin in Workspace 2015-09-22 10:55:52 -06:00
Thomas Johansen
e0ff96127a 🔥 Remove deprecations from Workspace 2015-09-22 10:37:06 -06:00
Ivan Zuzak
fd9f483486 Use thin arrow where possible 2015-09-21 12:55:12 +02:00
Nathan Sobo
37f8661ec6 Use promises instead of Q in Workspace
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
2015-09-18 21:24:59 -06:00
Nathan Sobo
f77cb3786c Terminate all directory searches if any fail
@bolinfest: I was seeing exceptions after the test terminated due to
one of the searches still running. I think since the promise rejects
with “all” semantics that we should cancel any other searches when one
fails. I wouldn’t expect them to continue if the promise is no longer
unresolved.
2015-09-18 20:48:46 -06:00
Antonio Scandurra
9a431a5c97 💚 2015-09-10 18:06:18 +02:00
Andrey Fedorov
f2a1b69a34 Add backticks around URLs for style consistency 2015-09-05 14:24:07 -04:00
Andrey Fedorov
2c7be877c6 Update note explaining the usage of the protocol 2015-09-04 13:28:19 -04:00
Andrey Fedorov
136a30f180 Add a clarification about the usage of addOpener
Documentation augmented with a note about the need of using fake protocol in
order to invoke opener on a file already opened.

See discussion at

https://discuss.atom.io/t/difficulties-using-atom-workspace-addopener/20444
2015-09-04 10:23:40 -04:00
Lee Dohm
73dded1e42 📝 Fix a typo and make recommendation more clear 2015-08-21 13:14:28 -07:00
Nathan Sobo
f9a576b0ce Allow Infinity for initialLine/Column; move specs to workspace
The initialLine and initialColumn behavior belongs on workspace.
2015-08-10 11:32:38 -06:00
Nathan Sobo
69da157ecb Add specs for initialLine and initialColumn, simplify implementation 2015-08-10 11:27:15 -06:00
Jong Eun Lee
93586d2410 fix : workspace.open with initial cursor position bug
When opening already opened file via `atom.workspace.open(path,{ initialLine: 0,  initialColumn: 0, searchAllPanes: true} )`, cursor position doesn't move `[0,0]`.

Expected result:
Whether or not file is opened already, cursor position has to be [0,0].
2015-08-07 19:38:35 +09:00
George Ogata
45694dcda0 Fire event before a pane is destroyed. 2015-07-23 18:47:38 -04:00
Kevin Sawicki
2c37294f3b Handle EINVAL errors on open
Closes atom/tree-view#408
2015-07-20 17:04:17 -07:00
Kevin Sawicki
d2a7012512 Handle ECONNRESET error codes on open
Closes #7946
2015-07-20 15:24:33 -07:00
Max Brunsfeld
c60c00f626 Ignore NaN coordinates passed to workspace.open 2015-07-08 16:50:17 -07:00
Kevin Sawicki
22f7379f32 Handle UNKNOWN open errors 2015-07-08 15:40:43 -07:00
Kevin Sawicki
27a94b4d70 Handle ENOTCONN open errors 2015-07-08 15:40:42 -07:00
Kevin Sawicki
955749b320 Handle EIO open errors 2015-07-08 15:40:42 -07:00
Kevin Sawicki
de4cf38dcc Handle ENXIO open errors 2015-07-08 15:40:42 -07:00
Ivan Žužak
852456fafe Merge pull request #7173 from atom/ns-prompt-on-large-files
Show a warning prompt when opening files over 20MB
2015-06-21 18:17:59 +02:00
Michael Bolin
ad46b37cfe In workspace-spec.coffee, updated FakeSearch to match the spec, which
helped uncover a bug.
2015-06-10 23:30:42 +01:00
Michael Bolin
3c44bc06f4 Revert "Revert "Introduce atom.directory-searcher service v0.1.0.""
This reverts commit 262d41c306.
2015-06-10 23:30:25 +01:00
Max Brunsfeld
262d41c306 Revert "Introduce atom.directory-searcher service v0.1.0." 2015-06-09 11:51:30 -07:00
Michael Bolin
535c0e2f34 Fix documentation bug. 2015-06-09 15:34:10 +01:00
Michael Bolin
6b1b57c89c Rename a variable to reflect a change in the previous commit. 2015-06-09 15:34:10 +01:00
Michael Bolin
0630bce95c Two things:
* Removed the `Directory` argument to `didSearchPaths`.
Now each searcher gets its own instance of `didSearchPaths` that is parameterized by provider.
* Simplified `DefaultDirectorySearcher.search()` so it creates one `DirectorySearch`
rather than one per `Directory` passed to `search()`.
2015-06-09 15:34:10 +01:00
Michael Bolin
18ac7d0cbc Comment excised, as recommended by @maxbrunsfeld. 2015-06-09 15:34:09 +01:00
Michael Bolin
028ac79836 Changed the behavior so that if a searcher rejects,
then the thenable returned by `atom.workspace.scan()` rejects.
2015-06-09 15:34:09 +01:00
Michael Bolin
7dc3d07f8a Changed the contract of DefaultDirectorySearcher in two significant ways:
* `search()` takes an array of `Directory` objects rather than an individual object.
* `options.didSearchPaths` now takes the `Directory` in addition to the `count` as an argument.
2015-06-09 15:34:09 +01:00
Michael Bolin
36123faf5d Changed DefaultDirectorySearcher to take multiple directories.
Still need to update `workspace.coffee` to make better use of this.
2015-06-09 15:34:09 +01:00