Ash Wilson
fb4d7ee5e5
Clean the pending operations too
2017-09-12 14:39:17 -04:00
Ash Wilson
7737aec3ae
🔥 fdescribe
2017-09-12 11:25:29 -04:00
Ash Wilson
e275a5ff76
Ensure that .get calls before .requestLoad return .set properties
2017-09-12 11:21:20 -04:00
Ash Wilson
18a0a5a857
.set operations should be immediately visible through .get
2017-09-12 10:33:46 -04:00
Ash Wilson
e9588c8fae
Bring the new spec up to date
2017-09-12 10:18:09 -04:00
Ash Wilson
adb032adf1
Some cosmetic coffeescript changes
2017-09-12 10:16:50 -04:00
Ash Wilson
bf121eab72
Remove some diagnostics
2017-09-12 10:16:25 -04:00
Ash Wilson
fa0bd1e049
Use a real clock and artificial file mtimes to work with nsfw
2017-09-12 10:15:55 -04:00
Ash Wilson
21e220cd5f
Stub the correct fs method
2017-09-12 10:13:05 -04:00
Ash Wilson
046ff87f01
Trick the specs into seeing the settings as loaded
2017-09-12 10:12:38 -04:00
Katrina Uychaco
494cb7ea4b
WIP Add test for ensuring that set/unset operations take place after load
2017-08-25 20:32:17 -07:00
Katrina Uychaco
1dc5dec816
WIP fix broken tests
2017-08-25 19:58:51 -07:00
Max Brunsfeld
6c59486166
Silence warnings from config spec
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-04-07 13:29:51 -07:00
Damien Guard
ff83e59753
Merge pull request #13365 from atom/dg-specs-reliability
...
Specs: test reliability & auto temp clean-up
2016-12-01 13:24:12 -08:00
Damien Guard
3fd1dbdce3
Clean up temporary files when running specs
2016-12-01 10:48:45 -08:00
Damien Guard
f2b6da332d
Temporarily disable 3 flakey specs on Windows x64
2016-11-30 19:18:26 -08:00
Rowan Bottema
b53c5a10d0
Add zero to hexadecimal numbers below F (16)
2016-03-08 10:20:37 +01:00
Ben Ogle
8acb742c30
Merge pull request #7916 from oggy/descriptive-enums
...
Support descriptions for enum values in config.
2016-01-26 14:45:00 -08:00
Chen Shen
f774e1ce21
add unittest
2016-01-04 17:41:42 -08:00
Dirk Thomas
6e2061c076
✅ add spec for ordered config.cson
2015-12-06 17:15:13 -08:00
Antonio Scandurra
c6cb37ac88
🎨
2015-11-11 20:26:23 +01:00
Antonio Scandurra
38d713379f
🎨 Introduce Config::transactAsync
2015-11-11 09:55:20 +01:00
Nathan Sobo
dc44d11a2c
Don’t load/save config if enablePersistence option is false
2015-10-14 20:05:06 -06:00
Max Brunsfeld
32780e2823
Merge branch 'master' into ns-alternative-test-env
...
Conflicts:
package.json
2015-10-14 14:12:42 -07:00
Antonio Scandurra
4b10f8a2b0
🔥 Avoid mocking atom.config in spec-helper
2015-10-14 12:47:33 +02:00
George Ogata
790ea8e6f2
Support descriptions for enum values in config.
...
The enum property may now specify options as a list of {value:,
description:} objects.
2015-10-14 01:53:58 -04:00
Max Brunsfeld
47961a8e6b
Fix setting default values in config
2015-10-13 11:00:53 -07:00
Max Brunsfeld
d55398b77b
Use key-path-helpers module instead of underscore-plus
2015-09-28 17:27:15 -07:00
Thomas Johansen
4914c15289
🔥 Remove Config deprecations
2015-09-22 10:37:05 -06:00
Jeremy Ramin
1de707f2d7
✅ Add tests to config spec
...
Add tests to check if the get command properly merges the stored values
with the defined defaults in the schema.
Two cases:
- Obj has no property changes.
- Obj has one or more changes to a property.
2015-08-24 17:00:09 -07:00
Max Brunsfeld
5f620fb739
Config::getSchema - use null to represent inaccessible key path
2015-08-12 16:52:25 -07:00
Max Brunsfeld
fbd684926e
Config - Support additionalProperties field of object schemas
2015-07-30 18:28:41 -07:00
Max Brunsfeld
84f72c880a
Config - don't allow setting key-paths inside of strings, arrays, etc
2015-07-30 18:28:06 -07:00
Nathan Sobo
e723b26eb0
Add maximumLength schema enforcer for strings
2015-06-01 18:45:38 +02:00
Nathan Sobo
b68902dd83
🎨
2015-06-01 18:45:38 +02:00
Nathan Sobo
d1c44dcb54
Never load config settings from disk when a save is pending
...
Fixes #5771
We load the user’s settings from disk when we detect a change to their
config.cson file. However, if there’s a save pending, doing this will
end up blowing away the values we intend to save.
2015-04-20 12:12:05 -06:00
Nathan Sobo
96b0938c7c
🎨
2015-04-20 12:12:05 -06:00
Kevin Sawicki
4160a8c239
Merge pull request #6230 from mnquintana/coffeelint-plus
...
Lint for more styleguide errors
2015-04-08 12:07:23 -07:00
Kevin Sawicki
06b8195fb8
Remove template config.cson file
...
This old template file had several problems:
* The entries in this file are already the schema defaults so they
would get unset anyway when initially loaded
* The file was in the old format that didn't have scope selectors
* A race condition could occur when the file was copied, inited, and written
to all during the very first run of Atom.
Closes #6226
2015-04-07 11:47:36 -07:00
Machiste Quintana
5d2392ea67
👕 Fix new coffeelint errors
2015-04-06 23:59:54 -04:00
Kevin Sawicki
30419027a8
Show notification on config save failures
2015-02-05 15:34:17 -08:00
Ben Ogle
7263ca8faa
🎨 Fix spec title
2015-01-29 17:54:41 -08:00
Ben Ogle
083bafdb33
Handle unschema’d items in objects.
...
This is required for packages that still use configDefaults
2015-01-29 17:54:41 -08:00
Ben Ogle
26b450fe49
🎨 Clean up spec naming
2015-01-29 17:54:41 -08:00
Ben Ogle
5d273d0ee6
Add a bit more coverage to the specs
2015-01-29 17:54:41 -08:00
Ben Ogle
b9b2b4bca2
Adhere to the schemas when loading the user’s config
2015-01-29 17:54:41 -08:00
Ben Ogle
79094ee889
Reset all user config values when the schema changes.
2015-01-29 17:54:40 -08:00
Kevin Sawicki
63335f6b60
Return Color object when in cloned objects
...
This adds a custom deepClone that clones any Color objects
correctly.
2015-01-22 10:48:07 -08:00
Max Brunsfeld
0a59d13d56
Fix Config::unset with no scope-selector
...
Closes #5095
2015-01-16 10:23:12 -08:00
Ben Ogle
1bc2248fc2
Fix config specs
2015-01-14 16:15:53 -08:00
