Commit Graph

33889 Commits

Author SHA1 Message Date
Ash Wilson
654cb26819 Only run render process tests on Windows for the moment 2017-08-03 14:20:24 -04:00
Nathan Sobo
18c5a31fbc Unset ELECTRON_ENABLE_LOGGING on Windows unless explicitly requested 2017-08-03 11:53:36 -06:00
Ash Wilson
dedf5193cd Does stderr work there... ? 2017-08-03 13:11:09 -04:00
Jason Rudolph
29810c6cd1 Attempt to fix flaky test re: blinking cursor
As shown in #15122, this test sometimes fails in CI with the following
error:

  TextEditorComponent
    rendering
      it blinks cursors when the editor is focused and the cursors are not moving
        Expected '0' to be '1'.
          at it (C:\projects\atom\spec\text-editor-component-spec.js:414:49)
        Expected '0' to be '1'.
          at it (C:\projects\atom\spec\text-editor-component-spec.js:415:49)

I *think* this might be a case of overspecification in the test's
assertions. Prior to this commit, the test expected the blinking cursor
to *start* in the visible state, and then transition to the invisible
state. When we see the failure above, I suspect that the cursor has
already transitioned from the visible state to the invisible state by
the time the assertion runs.

Since the test aims to verify that the cursor blinks, it seems like we
should focus on the blinking, and not worry about the *initial* state of
the cursor. This commit removes the assertions that verify the initial
state of the cursor, and instead asserts that the cursor toggles between
the visible and the invisible state.
2017-08-03 12:25:01 -04:00
Ash Wilson
3deb26b6a0 console.log debugging 2017-08-03 11:52:15 -04:00
Ash Wilson
3e3ab73748 Use distinct names for spec directories 2017-08-03 07:48:22 -07:00
Jason Rudolph
7d6bd2a6b1 Merge pull request #15147 from atom/ns-jr-fix-gutter-decoration-dimensions
Ensure custom gutter decoration elements fill their container
2017-08-03 10:11:04 -04:00
Ash Wilson
b6a3c5c6d2 Consistently split paths in test cases 2017-08-03 08:51:44 -04:00
Ash Wilson
4cf519f2d7 Merge branch 'master' into aw-filewatcher 2017-08-03 08:37:40 -04:00
Ash Wilson
fc53b21857 Merge pull request #15124 from smashwilson/aw-spec-reporters
Use spec reporters in CI
2017-08-03 06:54:54 -04:00
Nathan Sobo
55748bd2c4 Document enable-electron-logging option 2017-08-02 21:12:02 -06:00
Nathan Sobo
b5bdf4acb9 Don't enable electron logging by default 2017-08-02 21:03:29 -06:00
Nathan Sobo
1584189962 Ensure custom decoration elements fill their container 2017-08-02 20:34:18 -06:00
Ash Wilson
e5139874d0 🔥 dumping the test environment 2017-08-02 20:08:20 -04:00
Ash Wilson
e90441303d 🔥 console.logs 2017-08-02 19:34:44 -04:00
Jason Rudolph
03b631a1da Merge pull request #15145 from atom/jr-tree-view-0-217-6
⬆️ Upgrade tree-view to 0.217.6 to fix intermittent CI failures
2017-08-02 18:30:44 -04:00
Wliu
977b337b4c ⬆️ language-php@0.41.0 2017-08-02 16:45:46 -04:00
Ash Wilson
219eabfa50 Use jasmine-reporters 1.x 2017-08-02 16:29:36 -04:00
Jason Rudolph
88c4d383fb ⬆️ Upgrade tree-view to 0.217.6 2017-08-02 15:36:02 -04:00
Ash Wilson
1e739aa891 Prepend a drive root to lookup paths on Windows 2017-08-02 14:55:12 -04:00
Ash Wilson
b9080bcec5 Don't use "path" as a variable name 2017-08-02 12:59:38 -04:00
Wliu
03742f6343 Merge pull request #15138 from alanyee/patch-1
Update README.md
2017-08-02 12:57:48 -04:00
Alan Yee
9b6eff2d81 Update README.md
Removing Homebrew install instructions
2017-08-02 09:36:22 -07:00
Ash Wilson
931b4e7055 👕 lint lint lint 2017-08-02 12:33:06 -04:00
Ash Wilson
1f56713702 Un-exclude nsfw 2017-08-02 11:50:07 -04:00
Alan Yee
d57346f23a Update README.md
Fix grammar error
2017-08-02 08:35:15 -07:00
Ash Wilson
318708bb42 wip 2017-08-02 09:50:57 -04:00
Ash Wilson
320664a359 Remove an export I missed 2017-08-02 09:04:33 -04:00
Ash Wilson
05a4f1f6fb 👕 standard.js in script/test 2017-08-02 08:29:10 -04:00
Ash Wilson
f8f6ecb5c1 Merge remote-tracking branch 'upstream/master' into aw-filewatcher 2017-08-02 08:25:39 -04:00
Ash Wilson
7244fb9670 Format script/test with standard 2017-08-02 08:18:25 -04:00
simurai
ad7e206a78 ⬆️ one-dark/light-ui@v1.10.6 2017-08-02 12:39:46 +09:00
Ash Wilson
c7a47a9e89 Use module.exports to not break Joanna horribly 2017-08-01 16:40:54 -04:00
Ash Wilson
00346614a0 Spec for onDidChangeFiles 2017-08-01 15:58:38 -04:00
Ash Wilson
f005fcdca1 Use directory.getPath() as the object key 2017-08-01 15:55:39 -04:00
Ash Wilson
1285a89a4b Reset @watchersByPath on atom.project.setPaths 2017-08-01 15:55:28 -04:00
Ash Wilson
ee9ad53d91 🔥 unused variables 2017-08-01 15:55:08 -04:00
Ash Wilson
b3f327b0b3 Implement atom.project.onDidChangeFiles 2017-08-01 15:08:07 -04:00
Ash Wilson
697dfaf3b3 Re-export watchPath 2017-08-01 15:08:07 -04:00
Ash Wilson
67a8ba2a04 Adjust specs for the changed event shape 2017-08-01 15:08:07 -04:00
Ash Wilson
ba11070d16 Translate nsfw events to the events we're advertising 2017-08-01 15:08:07 -04:00
Ash Wilson
afdb2f13a6 Doooooocs 2017-08-01 15:08:07 -04:00
Ash Wilson
53ea430019 Update spec name 2017-08-01 15:08:07 -04:00
Ash Wilson
3fab3fed36 Consistent path handling in specs 2017-08-01 15:08:07 -04:00
Ash Wilson
6fdeedd4ab Introduce a helper to re-join split absolute paths regardless of platform 2017-08-01 15:08:07 -04:00
Ash Wilson
3c967b07ef Use a cross-platform way to generate absolute paths for specs 2017-08-01 15:08:07 -04:00
Ash Wilson
9c874c921e Use the watchPath API in specs 2017-08-01 15:08:07 -04:00
Ash Wilson
4f0b52d2ab Move the global watcher registry to a lazily initialized manager 2017-08-01 15:08:07 -04:00
Ash Wilson
99d6f911cf Rename the filesystem-manager-spec too 2017-08-01 15:08:06 -04:00
Ash Wilson
7aab9925a8 Rename filesystem-manager to path-watcher 2017-08-01 15:08:06 -04:00