github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-19 02:44:29 -05:00
Code Issues Packages Projects Releases Wiki Activity
33,889 Commits 140 Branches 571 Tags
5c4e13840dafaaa7710d5efe89c05694e75e321f
Commit Graph

33889 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Nathaniel Ringo
7be9ff527f 🎨 Improves customizable-size-warning spec styling. 2016-08-17 17:36:54 -05:00
Nathan Sobo
67313aec8d Default editor height to 100% 
Previously, when autoHeight was assigned to false on the editor, we would assign an inline style of height: 100%. This preserves the essence of that behavior without prohibiting users from assigning their own height via more specific CSS rules.

Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
 2016-08-17 16:14:04 -06:00
Nathan Sobo
6a0b4d8fc0 Default autoWidth in getter method to match autoHeight 2016-08-17 15:52:51 -06:00
Nathan Sobo
13c00995d4 Return default value of true from TextEditor.getAutoHeight 
When we need to check for unassigned in the deprecated code path, we
can just read the instance variable directly to avoid getting the
deafult.

Signed-off-by: Antonio Scandurra <as-cii@github.com>
 2016-08-17 15:52:51 -06:00
Nathan Sobo
106621e161 Deprecate automatic assignment of autoHeight for text editors 
Previously, we attempted to automatically determine whether the editor’s
height should be based on the editor’s content or the height of its
container. Unfortunately, DOM APIs are insufficient to make this
determination in a complete way, leading to unpredictable behavior.

This PR deprecates the automatic determination of this behavior. By
default, editors base their height on their content. If an editor has
an explicit height assigned via its style or is positioned absolute with
an explicit top and bottom, we disable the content-based autoHeight and
log a deprecation warning telling the user to assign autoHeight
explicitly.

This paves the way to add an autoWidth setting, which will default to
false.
 2016-08-17 15:52:51 -06:00
Nathaniel Ringo
324bf649ea Improves specs for configurable large file limit. 2016-08-17 15:14:22 -05:00
Nathan Sobo
351bad432b Merge pull request #12448 from atom/as-editor-auto-width 
Introduce autoWidth for TextEditors
 2016-08-17 12:55:54 -06:00
Nathaniel Ringo
5a1def03ac Updates spec for configurable large file limit. 2016-08-17 13:37:36 -05:00
Antonio Scandurra
1587dcbe89 Take the gutter width into account when sizing TextEditorElement 2016-08-17 19:21:56 +02:00
Antonio Scandurra
c37138e09e Revert refactoring to make the diff shorter 2016-08-17 18:08:02 +02:00
Antonio Scandurra
3642292302 🔥 debugger 2016-08-17 18:05:58 +02:00
Antonio Scandurra
6f0fd965cd Clear out width on TextEditorElement only if autoWidth was previously on 2016-08-17 18:05:16 +02:00
Antonio Scandurra
e71027ed36 Ensure editors don't scroll or show scrollbars when autoWidth is enabled 2016-08-17 17:58:36 +02:00
Antonio Scandurra
5b44b51150 🎨 Clarify naming 2016-08-17 17:20:24 +02:00
Antonio Scandurra
e8f2e3a608 Size TextEditorElement according to the autoWidth property 2016-08-17 16:20:00 +02:00
Antonio Scandurra
2e37d7f0cf Change state.content.width based on autoWidth 2016-08-17 16:14:57 +02:00
Antonio Scandurra
683bf37907 Add autoWidth to TextEditor 2016-08-17 16:14:36 +02:00
Nathaniel Ringo
b32b8b40fe Adds configuration option for large file warning threshold. 2016-08-16 16:43:16 -05:00
Max Brunsfeld
f376316d60 Merge pull request #12125 from atom/ns-mb-detangle-editor 
Remove some of the TextEditor class's Atom-specific dependencies
 2016-08-16 12:07:42 -07:00
Max Brunsfeld
c5a6e9c697 Merge branch 'master' into ns-mb-detangle-editor 2016-08-16 09:11:11 -07:00
Antonio Scandurra
061ae3786a Remove custom copySync function 
Originally we introduced this function because we thought empty
directories were causing path length issues on Windows, but it turns out
that it was a problem with Squirrel, so we can delete this code path
altogether.

Signed-off-by: Nathan Sobo <nathan@github.com>
 2016-08-16 18:08:16 +02:00
Max Brunsfeld
782b070964 Use es6 export in null-grammar.js 2016-08-16 09:03:50 -07:00
Antonio Scandurra
f139c800e2 Merge branch 'master' into ns-modernize-build 2016-08-16 16:10:59 +02:00
Antonio Scandurra
6439812bf6 Try replacing dashes with dots 2016-08-16 14:55:24 +02:00
Antonio Scandurra
0189616e12 Use x.y.z~dev.sha as the appVersion on rpm packages 2016-08-16 14:34:16 +02:00
Antonio Scandurra
943df9347d Install rpm on Travis to build rpm packages 2016-08-16 13:36:41 +02:00
Antonio Scandurra
2b3adaeace Merge pull request #12393 from atom/as-remove-backup-before-saving 
Remove config option `editor.backUpBeforeSaving`
 2016-08-16 13:29:59 +02:00
Antonio Scandurra
552c02f60f Copy generated packages into buildOutputPath 2016-08-16 13:14:27 +02:00
Antonio Scandurra
03045ff2ec Delete ~/rpmbuild entirely before creating a rpm package 2016-08-16 13:02:06 +02:00
Antonio Scandurra
266db1669e Don't stringify stdout/stderr when they don't exist 2016-08-16 12:54:04 +02:00
Antonio Scandurra
8e1972d804 Unlock keychains using the correct format 2016-08-16 12:53:33 +02:00
Antonio Scandurra
6afcc7e96b Convert package.json version dashes into tildes for rpm packages 2016-08-16 12:49:34 +02:00
Antonio Scandurra
e3e85e4780 Put back mistakenly deleted requires 2016-08-16 12:46:37 +02:00
Antonio Scandurra
62d5af52ae Use execSync when changing permissions via the find command 
This will prevent the arguments supplied to `-exec` from being escaped
incorrectly by `spawnSync`.
 2016-08-16 12:43:49 +02:00
Antonio Scandurra
d7f7f3527e Extract a spawnSync helper that throws on command errors 2016-08-16 12:29:42 +02:00
Antonio Scandurra
afb57711d0 🎨 2016-08-16 12:00:20 +02:00
Antonio Scandurra
8dddbab344 Recreate symlinks when calling copySync 2016-08-16 11:24:17 +02:00
Max Brunsfeld
2fa48a13e4 Merge pull request #12434 from atom/mb-atom-home-from-shell-child-process 
Allow ATOM_HOME to be reassigned if the new value is valid
 2016-08-15 17:50:19 -07:00
Max Brunsfeld
8702b4ca47 Remove 'Some textSome textSome textSome text' 2016-08-15 17:12:40 -07:00
Max Brunsfeld
8018dc9d57 Allow ATOM_HOME to be reassigned if the new value is valid 2016-08-15 17:05:18 -07:00
Max Brunsfeld
4b0183d074 Remove extraneous TextEditor setter methods 2016-08-15 16:45:10 -07:00
Max Brunsfeld
0d099d2fd5 Serialize all TextEditor parameters needed for the DisplayLayer 2016-08-15 15:51:22 -07:00
Max Brunsfeld
4bcdbf4d2f Don't have registry update any editors before initial packages are loaded 2016-08-15 15:29:27 -07:00
Max Brunsfeld
1c99c399d1 Merge branch 'master' into ns-mb-detangle-editor 2016-08-15 11:17:07 -07:00
Nathan Sobo
923e5ace0b Create Windows installer on AppVeyor 
Signed-off-by: Antonio Scandurra <as-cii@github.com>
 2016-08-15 08:06:13 -06:00
Nathan Sobo
c9de91dc09 Rename create-installer option to create-windows-installer to match help 
Signed-off-by: Antonio Scandurra <as-cii@github.com>
 2016-08-15 08:05:57 -06:00
Antonio Scandurra
c7ab2570c9 Use --create-rpm-package flag on Travis 2016-08-15 16:01:07 +02:00
Antonio Scandurra
91732ce753 🎨 2016-08-15 16:00:44 +02:00
Antonio Scandurra
08dcb39f87 Start on RPM package creation 2016-08-15 16:00:33 +02:00
Antonio Scandurra
d97edcb8aa 📝 2016-08-15 14:41:49 +02:00