github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-12 15:45:23 -05:00
Code Issues Packages Projects Releases Wiki Activity
36,023 Commits 140 Branches 571 Tags
5e3f12857f36684cc98eb2353f9b030f6914e0fb
Commit Graph

54 Commits

Author SHA1 Message Date
Nikolay Karev
5e3f12857f Shorter conditionals 2019-02-07 11:46:11 -08:00
Nikolay Karev
bed9c6966e File -> Open works without open windows 2019-02-07 11:46:11 -08:00
David Wilson
2a97673781 Fix restart behavior for "Restart and Install Update" on macOS 2019-02-01 15:51:02 -08:00
Ash Wilson
f68a511a90 pathsToOpen and foldersToOpen may be undefined 2019-01-24 15:17:26 -05:00
Ash Wilson
1ecff536c7 Pass persisted window sessions as foldersToOpen 2019-01-24 11:07:00 -05:00
Ash Wilson
2ab0e8db24 --new-window locks shouldReopenPreviousWindows to false 2019-01-14 11:46:18 -05:00
Ash Wilson
d3671f7055 Require --add to open locations in existing windows 2019-01-04 11:06:17 -05:00
Ash Wilson
f1de652bac ... Right. Joanna can't handle spread properties in objects 2019-01-04 09:06:19 -05:00
Ash Wilson
15594dd8c2 AtomApplication launch behavior shuffle 2019-01-03 16:41:17 -05:00
Ash Wilson
e31a142a92 Remove unused initialPaths 2019-01-03 11:28:49 -05:00
Jordan Eldredge
878629dd0a Avoid sending async updates on config update 
In
7a5d727e22
the 'set-user-settings' callback was changed so that it nolonger
returned the promise created by `ConfigFile.update()`. This meant that
the logic in
[`ApplicateDelegate.onDidChangeUserSetting()`](https://github.com/atom/atom/blob/5f0231b/src/application-delegate.js#L193-L206) which uses
`.pendingSettingUpdateCount` to avoid triggering in response to calls to
ApplicationDelegate.setUserSettings` was no longer effective.

I noticed this when updating settings via the setting view. If you type
at just the right (wrong?) cadence, you'll notice that your input can
get updated with stale values.

Something like this:

```
You type            "a"      "b"            "c"
config.set          "a"      "ab"           "ac"
config.observe                        "a"         "ab"    "ac"
Input value         "a"      "ab"     "a"   "ac"  "ab"    "ac"
```

It's possible that is the same as https://github.com/atom/settings-view/issues/1062

After this change typing in settings input seems to behave as expected.
 2018-12-05 14:34:30 -08:00
Stepan Hruda
069d3ec91a Merge pull request #17873 from atom/fb-sh-close-on-unload 
During quit, close unloaded windows
 2018-08-27 20:32:26 -04:00
Stepan Hruda
12c4e596b9 During quit, close unloaded windows 
Released under CC0.
 2018-08-27 19:06:36 -04:00
Max Brunsfeld
467415af19 Merge branch 'master' into wl-rm-safe-clipboard 2018-08-24 11:57:36 -07:00
Ash Wilson
dbb3947250 Pass the environment to the window if one is present 2018-08-22 13:22:08 -04:00
Ash Wilson
e1015103c8 Use Object.assign() instead of spread so we don't confuse Joanna 2018-08-22 13:21:44 -04:00
Ash Wilson
528346040c Pass additional options to the test runner window 2018-08-22 10:28:41 -04:00
David Wilson
ba9616506f Merge pull request #17464 from atom/extended-color-profile-bits 
Extend the color profile PR (#17380)
 2018-06-04 14:22:25 -07:00
Max Brunsfeld
3f8b463b15 Move auto update initialization back to AtomApplication.initialize 
This fixes some CI problems introduced in #17216
 2018-05-01 11:01:18 -07:00
Max Brunsfeld
1ad9715e9d Wait to initialize auto update manager until config is loaded 2018-04-25 09:33:53 -07:00
Max Brunsfeld
85d745cbec Remove 'project' command line flag 
From what I can tell, this flag never worked correctly. Instead of
opening the paths specified in the project file, the directory
containing the project file itself would always be opened.
 2018-04-25 07:45:58 -07:00
Max Brunsfeld
7a5d727e22 Avoid writing to config file while quitting 2018-04-18 10:46:38 -07:00
Ash Wilson
ad8392b2f5 Accept a filePath in the set-user-settings IPC call 2018-03-27 08:55:07 -04:00
Philip Weiss
e14ffb9420 set default path inside of project.replace 2018-03-09 14:04:21 -08:00
Philip Weiss
062dfdea80 address PR comments 2018-03-06 11:06:22 -08:00
Philip Weiss
7ce5b000e4 address more of max's comments 2018-03-01 19:35:59 -08:00
Philip Weiss
8f672b2e5f Merge branch 'master' into fb-pw-simple-project-config 2018-02-26 17:13:58 -08:00
Philip Weiss
1483c0c96d add more data passed through with projectSettings 2018-02-24 17:50:18 -08:00
Philip Weiss
e2c480847c atom project open in their own windows and behave more sanely 2018-02-23 17:38:36 -08:00
Landon Abney
138115f2a8 🐛 Handle empty username 
If Atom is launched in a shell that is missing the `USER`/`USERNAME`
environment variable it locks up due to an unhandled error from
`crypto.update`. This switches to using Node.js's built in
`os.userInfo()` method to retrieve the current user name,
allowing Atom to complete initialization in this scenario.

Fixes #16821.
 2018-02-22 13:18:56 -08:00
Max Brunsfeld
e638100158 Merge pull request #16810 from atom/mb-dont-write-config-when-quitting 
Don't try to write config file while quitting
 2018-02-21 10:44:56 -08:00
Max Brunsfeld
fb85656d8f Don't try to write config file while quitting 2018-02-21 09:29:02 -08:00
Max Brunsfeld
6b9e87ecd6 Serialize settings as JSON when sending them to the main process 2018-02-21 09:18:15 -08:00
Philip Weiss
bf6a4e3db4 add .atomProject files 2018-02-18 15:03:00 -08:00
Max Brunsfeld
e3135f1938 Continue to normalize any non-URL path command line arg 
Also, remove duplicate file stat'ing in AtomWindow
 2018-02-15 10:40:31 -08:00
Max Brunsfeld
98070275b5 Normalize command line paths with windows drive letters 2018-02-14 17:22:36 -08:00
Antonio Scandurra
49e704291d Register for core.titleBar changes after the initial load of config 
This prevents the change handler for `core.titleBar` from being
triggered every time a new instance of the main process is created. This
fixes a regression that was causing users to be prompted for a restart
every time they opened Atom.

Co-authored-by: Max Brunsfeld <maxbrunsfeld@github.com>
Co-authored-by: Nathan Sobo <nathan@github.com>
 2018-01-31 09:24:15 -07:00
Max Brunsfeld
1d20b8ee1d Start work on routing all config file IO through main process 2018-01-25 20:35:00 -08:00
Bryant Ung
c100ad0108 Merge pull request #16525 from atom/wl-async-message-box 
Use async dialog.showMessageBox
 2018-01-21 13:39:48 -08:00
Wliu
056c825d18 Merge branch 'master' into wl-async-message-box 2018-01-19 16:12:37 -05:00
Max Brunsfeld
9f35de4413 Always return an array from AtomApplication.launch 2018-01-19 13:08:49 -08:00
Max Brunsfeld
f7aba5a132 Replace loadState with side-effect-free loadPreviousWindowOptions 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2018-01-19 13:08:49 -08:00
Max Brunsfeld
61e53834e6 Make StorageFolder.load, AtomApplication.launch async 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2018-01-19 11:52:25 -08:00
Max Brunsfeld
e2ad4e6a8b Make StorageFolder.store async 
Signed-off-by: Nathan Sobo <nathan@github.com>
 2018-01-19 11:37:07 -08:00
Max Brunsfeld
0390548e2c Make FileRecoveryService async 2018-01-18 11:27:27 -08:00
Wliu
cd84216f11 Merge branch 'master' into wl-rm-safe-clipboard 2018-01-09 21:39:04 -05:00
Wliu
f922727644 Use async dialog.showMessageBox 2018-01-09 21:17:17 -05:00
Max Brunsfeld
6f50f32116 Rename pathsToNotifyWhenClosed -> pathsWithWaitSessions 2018-01-05 17:50:11 -08:00
Max Brunsfeld
386b786d93 Let 'atom --wait -a folder' exit due to removing the project folder 2018-01-05 17:50:11 -08:00
Max Brunsfeld
1f4ccf3024 Allow existing windows to be reused when running --wait 2018-01-05 17:50:11 -08:00