Commit Graph

13162 Commits

Author SHA1 Message Date
Nathan Sobo
5f2b5a16df Use WebContents.prototype.isLoading instead of defunct .loaded
Fixes cmd-o interaction.
2015-10-16 11:08:51 -06:00
Cheng Zhao
a5c9fcec2c Disable pinch-to-zoom, fixes #8850 2015-10-16 11:08:51 -06:00
Cheng Zhao
70fc6dd524 registerProtocol has been deprecated 2015-10-16 11:08:51 -06:00
Antonio Scandurra
05c6c9f9be Soft wrap only when we know lineMaxWidth 2015-10-16 11:14:20 +02:00
Antonio Scandurra
e843c2f058 🐎 Fetch scopes only if required 2015-10-16 11:03:15 +02:00
Antonio Scandurra
3f53a72620 🐎 Cache text in TokenIterator 2015-10-16 10:48:55 +02:00
Antonio Scandurra
b03aa4bf40 Merge branch 'master' into as-cjk-soft-wrap
# Conflicts:
#	spec/display-buffer-spec.coffee
2015-10-16 10:23:44 +02:00
Max Brunsfeld
27526f492c Fix fall-back to dev resource path in main 2015-10-15 18:01:20 -07:00
Max Brunsfeld
93fe0208a5 Make atom.setSize() synchronous again, for now
This method is public, and a spec for TextEditorComponent dependend on it
staying synchronous
2015-10-15 15:12:57 -07:00
Nathan Sobo
28ed6f3d9f Restore async window method calls
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-10-15 13:26:30 -06:00
Antonio Scandurra
4766c98bbe Treat Korean characters as different kinds of chars 2015-10-15 21:02:21 +02:00
Antonio Scandurra
7394cc531c Measure half width characters 2015-10-15 20:06:38 +02:00
Antonio Scandurra
c616e86a00 Take into account half width chars as well 2015-10-15 19:24:00 +02:00
Antonio Scandurra
91e9f16ff6 💚 2015-10-15 19:22:12 +02:00
Antonio Scandurra
8f7b303fc5 Recognize half width symbols 2015-10-15 19:01:23 +02:00
Antonio Scandurra
a3c3b48caa Recognize full width symbols 2015-10-15 18:59:12 +02:00
Antonio Scandurra
1fc9a25b5c Recognize half width characters 2015-10-15 18:57:11 +02:00
Antonio Scandurra
abf306943a 🐛 Measure latin chars with subpixel font scaling 2015-10-15 18:49:54 +02:00
Antonio Scandurra
43229a1b9e 🎨 2015-10-15 18:35:49 +02:00
Antonio Scandurra
4818d47980 Update wrapped screen lines when default width changes 2015-10-15 18:10:26 +02:00
Antonio Scandurra
4c66341624 Measure double width char widths 2015-10-15 18:08:35 +02:00
Antonio Scandurra
27dc3da9e5 🎨 Conflate setting default and double-width chars width
Because they will always change together, and having two different setters seems
highly error-prone.
2015-10-15 17:53:37 +02:00
Antonio Scandurra
c2ee942df1 Take double width chars into account when soft wrapping 2015-10-15 16:24:08 +02:00
Antonio Scandurra
b2a7f4a28e Create utility function to recognize double width characters 2015-10-15 16:02:08 +02:00
Antonio Scandurra
3c33a7ba9f Soft wrap based on default character width 2015-10-15 15:22:18 +02:00
Antonio Scandurra
c38cd48555 Bring back failure reports when running grunt run-specs
Log output to stderr as we did before, so that grunt can, in turn, output it to
console when specs fail.

Welcome back build failures! 🎉

/cc: @nathansobo @maxbrunsfeld
2015-10-15 09:56:13 +02:00
Antonio Scandurra
edddb6516e Remove shim to remote.process
This doesn't seem to work as expected. I think it's just better to encourage
emitting an event like 'write-to-stdout' or using directly `remote.process`.

/cc: @nathansobo
2015-10-15 09:55:28 +02:00
Nathan Sobo
b58b3504f4 Only load/save AtomEnvironment state if persistence is enabled 2015-10-14 22:10:51 -06:00
Nathan Sobo
dc44d11a2c Don’t load/save config if enablePersistence option is false 2015-10-14 20:05:06 -06:00
Nathan Sobo
9df40b4f4e Remove unnecessary fat arrow 2015-10-14 19:53:16 -06:00
Nathan Sobo
a6a175c4a6 Don’t hide window when reloading specs 2015-10-14 16:40:40 -06:00
Nathan Sobo
a85a8d20de Don’t register defaultTarget for keymaps in constructor after all
We’re clearing the views on reset, so this view will end up being
different between test runs. Also, we didn’t previously always create
the workspace view in many cases, and it makes sense to apply that here.

We may want to get the default target for the keymap via a function so
we can defer view creation until one is needed.
2015-10-14 15:57:45 -06:00
Nathan Sobo
82cbf01c5b Set useCapture to true when handling keydown events in test windows
Prevents these events from getting intercepted by other handlers.
2015-10-14 15:57:45 -06:00
Nathan Sobo
c1d5cdcd64 Group requires at the top of atom-environment.coffee 2015-10-14 15:57:45 -06:00
Nathan Sobo
df66ca8d73 Remove unused params 2015-10-14 15:57:45 -06:00
Max Brunsfeld
32780e2823 Merge branch 'master' into ns-alternative-test-env
Conflicts:
	package.json
2015-10-14 14:12:42 -07:00
Max Brunsfeld
395ffde7a1 Merge pull request #9131 from atom/mb-fix-config-unset
Fix setting default values in config
2015-10-14 09:51:53 -07:00
Ivan Žužak
6a0daebede Merge pull request #9096 from atom/iz-config-settings-descriptions
Add descriptions for config settings
2015-10-14 18:36:08 +02:00
Antonio Scandurra
f2a32eb1dc Return empty string unless configDirPath is passed 2015-10-14 18:25:25 +02:00
Ivan Zuzak
b3a7fe3fc9 Clarify how auto-detection works 2015-10-14 18:01:43 +02:00
Antonio Scandurra
6a53034a12 Move GrammarRegistry reset after Workspace
...as some elements could still use grammars upon Workspace destruction.
2015-10-14 17:48:47 +02:00
Antonio Scandurra
6b01811d20 Avoid stack overflow when scrolling with non-integer values
We were mistakenly using the rounded scroll top to guard against such cases.
This fixes it by using `@realScrollTop` instead.
2015-10-14 16:10:12 +02:00
Antonio Scandurra
789af9fc69 Use params instead of loadSettings 2015-10-14 13:01:54 +02:00
Antonio Scandurra
c5860ce6b6 🐛 Fix typo 2015-10-14 12:59:22 +02:00
Antonio Scandurra
b25d3e944b Parameterize configDirPath and move config.load in ctor 2015-10-14 12:41:36 +02:00
Antonio Scandurra
ed201d41cd 💚 Clear CommandRegistry on AtomEnvironment destruction 2015-10-14 10:11:53 +02:00
Antonio Scandurra
57f6fc5772 Observe core.autoHideMenuBar in AtomEnvironment ctor 2015-10-14 09:56:46 +02:00
Antonio Scandurra
f5f2d5dcd6 Remove remaining references to window global 2015-10-14 09:50:50 +02:00
Antonio Scandurra
0ea84ab192 Register default target for keymaps in ctor 2015-10-14 09:31:50 +02:00
Antonio Scandurra
a3190e4551 Use @window when (un)installing uncaught error handler 2015-10-14 09:18:54 +02:00