github/atom
1
1
Fork 0
mirror of https://github.com/atom/atom.git synced 2026-02-12 15:45:23 -05:00
Code Issues Packages Projects Releases Wiki Activity
36,342 Commits 140 Branches 571 Tags
631743f5f4170d580b953b79ddf1a2b20c9dc59c
Commit Graph

375 Commits

Author SHA1 Message Date
Ash Wilson
631743f5f4 Rename setRepresentedDirectoryPaths() to setProjectRoots() 
Let's keep the naming consistent the whole way up the call chain.
 2019-04-18 16:17:53 -04:00
Ash Wilson
495f493c44 Rename hasProjectPath to hasProjectPaths 
Likely a relic of the days when there was only one project.
 2019-04-18 16:17:07 -04:00
Ash Wilson
a0be3e735f Use containsLocations() for AtomApplication window location 2019-04-18 16:16:17 -04:00
Ash Wilson
952c42c0de Rename initialPaths and representedDirectoryPaths 
They're now called initialProjectRoots and projectRoots, which is closer 
to what they actually are.
 2019-04-18 16:15:07 -04:00
Ash Wilson
b095482071 Replace containsPath(s) with containsLocation(s) 
This lets us use existing stat data.
 2019-04-18 16:12:51 -04:00
Ash Wilson
efeb2cdb0a stat locations in parsePathToOpen() 2019-04-18 16:11:02 -04:00
Ash Wilson
41eacf7af7 Move AtomWindow creation into a dedicated, stubbable method 2019-04-18 10:51:02 -04:00
Ash Wilson
f7fd560ca0 :doc: comment reflow 2019-04-17 15:56:59 -04:00
Ash Wilson
87a4213b6a Rewrite AtomApplication::openPaths() logic to find existing windows 2019-04-17 15:56:49 -04:00
Ash Wilson
bd788b1cbd 📝 a/an 2019-04-17 15:13:17 -04:00
Ash Wilson
9409ba821c Account for a window being destroyed before an IPC message is delivered 2019-04-17 15:13:02 -04:00
Ash Wilson
a48dd69232 Getter for AtomWindow's loadedPromise 2019-04-17 14:10:14 -04:00
Ash Wilson
ffb295d5d6 Conditionally include {window} in getLoadSettings() 2019-04-10 16:50:21 -04:00
Ash Wilson
866447934e promptForPathToOpen() uses an existing window when only files are chosen 2019-04-10 16:15:39 -04:00
Ash Wilson
03908ddfab Pass along the source window of an open-command IPC event 2019-04-10 16:09:32 -04:00
Ash Wilson
e39b12b165 Prefer a {window} explicitly provided to openPaths() 2019-04-10 16:08:59 -04:00
Rafael Oleza
31d7dd6bb9 Add explicit handle for errors when decrypting 2019-04-05 17:13:53 +02:00
Rafael Oleza
bca056d956 Remove the handling logic for the --socket-path arg 2019-04-05 17:13:53 +02:00
Rafael Oleza
d40ca4b675 Implement authentication and encryption of the client 2019-04-05 17:13:53 +02:00
Rafael Oleza
5e124f437e Implement server-side authentication on pipes 
This is done by using a secret as the name of the pipe
 2019-04-05 17:13:53 +02:00
Rafael Oleza
a7d1e682e6 Extract logic to get the socket name to a function 2019-04-05 17:13:53 +02:00
Rafael Oleza
f04a00ac2d Remove --socket-path CLI argument 2019-04-04 17:55:58 +02:00
Rafael Oleza
2656d4a846 Merge pull request #19058 from rafeca/fix-reopen-project 
Fix reopen project when there are no open windows
 2019-03-27 16:21:45 +01:00
Rafael Oleza
9f453e64fe Fix reopen project when there are no open windows 2019-03-26 17:01:38 +01:00
Ash Wilson
2526e69e28 Exit with 1 and a message when -a and -n are both provided 2019-03-22 11:29:21 -04:00
Ash Wilson
372652915e 👕 Add missing newWindow parameter 2019-03-21 19:53:06 -04:00
Ash Wilson
2546170c0b Revert changes to help text 2019-03-21 19:09:19 -04:00
Ash Wilson
18847f79d1 Restore the newWindow option to force a path to open in a new window 2019-03-21 19:09:02 -04:00
Ash Wilson
4af379ae8e Re-use an existing window if one is available that contains all paths 2019-03-21 18:15:38 -04:00
David Wilson
bf3502c4db Fix "Open Folder" menu item on Windows 2019-02-15 09:54:44 -08:00
Nikolay Karev
5e3f12857f Shorter conditionals 2019-02-07 11:46:11 -08:00
Nikolay Karev
bed9c6966e File -> Open works without open windows 2019-02-07 11:46:11 -08:00
David Wilson
2a97673781 Fix restart behavior for "Restart and Install Update" on macOS 2019-02-01 15:51:02 -08:00
Ash Wilson
039aea4150 Restore missing return statement 2019-01-25 09:20:51 -05:00
Ash Wilson
f68a511a90 pathsToOpen and foldersToOpen may be undefined 2019-01-24 15:17:26 -05:00
Ash Wilson
1ecff536c7 Pass persisted window sessions as foldersToOpen 2019-01-24 11:07:00 -05:00
Ash Wilson
2ab0e8db24 --new-window locks shouldReopenPreviousWindows to false 2019-01-14 11:46:18 -05:00
Ash Wilson
cc0b982c5a Re-word help text 2019-01-14 10:49:21 -05:00
Ash Wilson
d3671f7055 Require --add to open locations in existing windows 2019-01-04 11:06:17 -05:00
Ash Wilson
f1de652bac ... Right. Joanna can't handle spread properties in objects 2019-01-04 09:06:19 -05:00
Ash Wilson
15594dd8c2 AtomApplication launch behavior shuffle 2019-01-03 16:41:17 -05:00
Ash Wilson
e570f72d86 Remove path normalization responsibilities from AtomWindow 2019-01-03 16:40:35 -05:00
Ash Wilson
e31a142a92 Remove unused initialPaths 2019-01-03 11:28:49 -05:00
Jordan Eldredge
878629dd0a Avoid sending async updates on config update 
In
7a5d727e22
the 'set-user-settings' callback was changed so that it nolonger
returned the promise created by `ConfigFile.update()`. This meant that
the logic in
[`ApplicateDelegate.onDidChangeUserSetting()`](https://github.com/atom/atom/blob/5f0231b/src/application-delegate.js#L193-L206) which uses
`.pendingSettingUpdateCount` to avoid triggering in response to calls to
ApplicationDelegate.setUserSettings` was no longer effective.

I noticed this when updating settings via the setting view. If you type
at just the right (wrong?) cadence, you'll notice that your input can
get updated with stale values.

Something like this:

```
You type            "a"      "b"            "c"
config.set          "a"      "ab"           "ac"
config.observe                        "a"         "ab"    "ac"
Input value         "a"      "ab"     "a"   "ac"  "ab"    "ac"
```

It's possible that is the same as https://github.com/atom/settings-view/issues/1062

After this change typing in settings input seems to behave as expected.
 2018-12-05 14:34:30 -08:00
David Wilson
b35778b686 Catch exceptions for bad package.json when looking for Atom repo in pwd 2018-09-15 06:30:49 -07:00
Stepan Hruda
069d3ec91a Merge pull request #17873 from atom/fb-sh-close-on-unload 
During quit, close unloaded windows
 2018-08-27 20:32:26 -04:00
Stepan Hruda
12c4e596b9 During quit, close unloaded windows 
Released under CC0.
 2018-08-27 19:06:36 -04:00
Max Brunsfeld
d875a0db89 Don't require compile cache in main process 2018-08-24 12:01:09 -07:00
Max Brunsfeld
ce18e1b7d6 Convert remaining coffee-script code in main process code to javascript 2018-08-24 12:01:09 -07:00
Max Brunsfeld
467415af19 Merge branch 'master' into wl-rm-safe-clipboard 2018-08-24 11:57:36 -07:00