Nathan Sobo
32a1854b7c
Use TextEditorPresenter::state.content.indentGuidesVisible
2015-02-03 15:05:16 -07:00
Nathan Sobo
590391a0ce
Update .content.indentGuidesVisible when editor’s grammar changes
2015-02-03 15:05:15 -07:00
Nathan Sobo
d0b52538b2
Add content.indentGuidesVisible to TextEditorPresenter::state
2015-02-03 15:05:15 -07:00
Nathan Sobo
0a9f7586ae
Add top-level .content object to presenter state
...
It contains the .scrollWidth and then all the lines in a nested .lines
object. The .width has been removed from each line and replaced with
.content.scrollWidth.
2015-02-03 15:05:15 -07:00
Nathan Sobo
115d764725
Handle scoped character widths in TextEditorPresenter
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com >
2015-02-03 15:05:14 -07:00
Nathan Sobo
a3fb8b3aaa
Disable spec until presenter approach stabilizes
2015-02-03 15:05:14 -07:00
Nathan Sobo
e2693da225
Fix endRow calculation
2015-02-03 15:05:14 -07:00
Nathan Sobo
9a070e7f6d
Include endOfLineInvisibles in presenter state
2015-02-03 15:05:14 -07:00
Nathan Sobo
7095ccd32b
Make all lines visible if no external client height is assigned
2015-02-03 15:05:13 -07:00
Nathan Sobo
ac463143dd
Add 1 pixel to scrollWidth to account for cursor if not soft-wrapped
2015-02-03 15:05:13 -07:00
Nathan Sobo
2296d2d378
Account for overdrawMargin of startRow when computing the endRow
2015-02-03 15:05:13 -07:00
Nathan Sobo
0f4bcac8d4
Add 1 to the last row to ensure it’s visible
2015-02-03 15:05:12 -07:00
Nathan Sobo
b09b54800f
Include line text in presenter state
2015-02-03 15:05:12 -07:00
Nathan Sobo
f4d8ef8315
Add width to lines state based on the computed scrollWidth
...
This is based on the ::baseCharacterWidth property for now. To be fully
correct, we need to base the scrollWidth on the actual width of
individual characters.
2015-02-03 15:05:12 -07:00
Nathan Sobo
a1c2e1bb66
Update TextEditorPresenter when the editor’s content changes
2015-02-03 15:05:12 -07:00
Nathan Sobo
5a2bbc945b
Handle changing ::lineHeight in TextEditorPresenter
2015-02-03 15:05:12 -07:00
Nathan Sobo
9c2ed478cd
Handle changing ::clientHeight in TextEditorPresenter
2015-02-03 15:05:11 -07:00
Nathan Sobo
880e1ce1f0
Handle changing ::scrollTop in TextEditorPresenter
2015-02-03 15:05:11 -07:00
Nathan Sobo
f0920bf63b
Start on TextEditorPresenter with lines state
2015-02-03 15:05:11 -07:00
Kevin Sawicki
853ad9cee3
Re-throw stylesheet compile errors
...
This makes it consistent with other read errors. Previously a Notification
was returned in the error case causing errors downstream where the package's
stylesheets array was assumed to be a path/content tuple.
Closes atom/deprecation-cop#22
2015-02-02 17:55:36 -08:00
Max Brunsfeld
3739995ddb
Merge pull request #5277 from atom/mb-package-json-services
...
Allow packages to specify services in their package.json files
2015-02-02 17:07:41 -08:00
Kevin Sawicki
f9f7cf6d34
Add more 6to5 specs
2015-02-02 13:29:20 -08:00
Kevin Sawicki
3b8b569d0c
🎨
2015-02-02 13:13:39 -08:00
Kevin Sawicki
8365ccb064
Merge pull request #5299 from bolinfest/6to5
...
Transpile all .js files beginning with the "use 6to5"; pragma with 6to5.
2015-02-02 13:11:33 -08:00
Max Brunsfeld
14969c0522
Avoid using private serviceHub in package manager test
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-02-02 10:01:56 -08:00
Max Brunsfeld
65f2ffa55e
Rename service keys in package.json
...
* serviceProvisions -> providedServices
* serviceDependencies -> consumedServices
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-02-02 10:01:50 -08:00
Max Brunsfeld
5638c7fb6a
Remove atom.services global
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-02-02 10:01:34 -08:00
Max Brunsfeld
cb8b254502
Use version-ranges in fixture package with service deps
2015-02-02 10:00:53 -08:00
Max Brunsfeld
027ebc78c4
Respect service{Provisions,Dependencies} in packages' metadata
2015-02-02 10:00:53 -08:00
Max Brunsfeld
d9fb54ad6f
Reset atom.services between specs
2015-02-02 10:00:53 -08:00
Ben Ogle
7263ca8faa
🎨 Fix spec title
2015-01-29 17:54:41 -08:00
Ben Ogle
083bafdb33
Handle unschema’d items in objects.
...
This is required for packages that still use configDefaults
2015-01-29 17:54:41 -08:00
Ben Ogle
26b450fe49
🎨 Clean up spec naming
2015-01-29 17:54:41 -08:00
Ben Ogle
5d273d0ee6
Add a bit more coverage to the specs
2015-01-29 17:54:41 -08:00
Ben Ogle
b9b2b4bca2
Adhere to the schemas when loading the user’s config
2015-01-29 17:54:41 -08:00
Ben Ogle
79094ee889
Reset all user config values when the schema changes.
2015-01-29 17:54:40 -08:00
Michael Bolin
52f2c0ec69
rename esnext to 6to5
2015-01-29 17:29:02 -08:00
Michael Bolin
32b3c4076f
More fixes for @kevinsawicki
2015-01-29 12:15:10 -08:00
Michael Bolin
242fce3d79
Transpile all .js files with 6to5.
...
In the spirit of supporting JavaScript development for Atom packages,
this adds default support for es.next transpilation support in the way
that Atom already has default support for CoffeeScript transpilation.
There are many new features in ES6+ that make JavaScript development
easier and more enjoyable, particularly in terms of support for async code.
For reference, this was a much faster way to iterate on this than running `./script/build`
each time:
```
cp /Users/mbolin/src/atom/static/index.js /Applications/Atom.app/Contents/Resources/app/static/index.js
coffee --output /Applications/Atom.app/Contents/Resources/app/src --compile /Users/mbolin/src/atom/src/esnext.coffee
```
Run the following in the console to see how warm the cache was after startup:
```
global.require('../src/esnext/').getCacheHits()
global.require('../src/esnext/').getCacheMisses()
```
2015-01-29 11:56:32 -08:00
Ben Ogle
db41b022c2
Merge pull request #5228 from atom/bo-fix-wait-promise
...
Make waitsForPromise() work with es6 promises as well as Q promises
2015-01-23 10:33:20 -08:00
Max Brunsfeld
d4cc549a01
Add jasmine.useRealClock
...
This is the only way to unmock the _.now function uses
by _.debounce and _.throttle, since package specs don't
necessarily have access to core's copy of underscore-plus
Signed-off-by: Nathan Sobo <nathan@github.com >
2015-01-22 17:59:18 -08:00
Ben Ogle
76a5da8be8
Make waitsForPromise() work with es6 promises as well as Q promises.
2015-01-22 17:26:15 -08:00
Kevin Sawicki
63335f6b60
Return Color object when in cloned objects
...
This adds a custom deepClone that clones any Color objects
correctly.
2015-01-22 10:48:07 -08:00
Max Brunsfeld
528267b7d7
Preserve relative indentation of pasted lines when auto-indenting
2015-01-22 08:34:20 -08:00
Kevin Sawicki
c378ef0649
Merge pull request #5044 from russlescai/rl-scoped-file-encoding
...
Allow scoped default File Encoding
2015-01-21 11:22:17 -08:00
postcasio
867f920329
Handle EROFS errors when saving
2015-01-20 09:56:00 +00:00
Ben Ogle
bac10d60c4
Merge pull request #5114 from atom/bo-readonly
...
Allow opening of readonly files
2015-01-16 11:41:30 -08:00
Ben Ogle
11bda1b47a
Add error handling for EBUSY as well
2015-01-16 11:07:32 -08:00
Ben Ogle
93f109fbba
Add a better message for EPERM errors.
2015-01-16 10:45:48 -08:00
Max Brunsfeld
0a59d13d56
Fix Config::unset with no scope-selector
...
Closes #5095
2015-01-16 10:23:12 -08:00