Nathan Sobo
661607857f
Fix spec failures due to slight changes in DOM positioning
2015-10-16 11:08:52 -06:00
Antonio Scandurra
23d5dc8726
Change invalid.js fixture for babel transpilation
...
The previous file was considered invalid on the earlier version of electron, but
it now compiles correctly because of the updated ES6 support.
2015-10-16 11:08:51 -06:00
Antonio Scandurra
224f2e973f
Adhere to CoffeeScript.compile contract
...
...which always returns the source map as a string. This is needed because
`Buffer` now requires to be initialized with either a number, a buffer, an array
or a string.
2015-10-16 11:08:51 -06:00
Antonio Scandurra
cd47c7be02
Fix leftover spec
2015-10-16 11:22:03 +02:00
Antonio Scandurra
eb3133b7e7
💚
2015-10-16 10:30:45 +02:00
Antonio Scandurra
b03aa4bf40
Merge branch 'master' into as-cjk-soft-wrap
...
# Conflicts:
# spec/display-buffer-spec.coffee
2015-10-16 10:23:44 +02:00
Antonio Scandurra
4766c98bbe
Treat Korean characters as different kinds of chars
2015-10-15 21:02:21 +02:00
Nathan Sobo
52946db179
Ensure windows/workspace present before proceeding in integration specs
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-10-15 12:54:33 -06:00
Antonio Scandurra
c9eb75cbe1
📝 Better wording on specs
2015-10-15 20:14:38 +02:00
Nathan Sobo
be1b2e6122
Increase timeout when waiting for atom-workspace to exist
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-10-15 12:08:07 -06:00
Antonio Scandurra
7394cc531c
Measure half width characters
2015-10-15 20:06:38 +02:00
Antonio Scandurra
c616e86a00
Take into account half width chars as well
2015-10-15 19:24:00 +02:00
Antonio Scandurra
8f7b303fc5
Recognize half width symbols
2015-10-15 19:01:23 +02:00
Antonio Scandurra
a3c3b48caa
Recognize full width symbols
2015-10-15 18:59:12 +02:00
Antonio Scandurra
1fc9a25b5c
Recognize half width characters
2015-10-15 18:57:11 +02:00
Antonio Scandurra
abf306943a
🐛 Measure latin chars with subpixel font scaling
2015-10-15 18:49:54 +02:00
Antonio Scandurra
4818d47980
Update wrapped screen lines when default width changes
2015-10-15 18:10:26 +02:00
Antonio Scandurra
4c66341624
Measure double width char widths
2015-10-15 18:08:35 +02:00
Antonio Scandurra
27dc3da9e5
🎨 Conflate setting default and double-width chars width
...
Because they will always change together, and having two different setters seems
highly error-prone.
2015-10-15 17:53:37 +02:00
Antonio Scandurra
20b0523833
💚
2015-10-15 16:41:27 +02:00
Antonio Scandurra
c2ee942df1
Take double width chars into account when soft wrapping
2015-10-15 16:24:08 +02:00
Antonio Scandurra
b2a7f4a28e
Create utility function to recognize double width characters
2015-10-15 16:02:08 +02:00
Antonio Scandurra
3c33a7ba9f
Soft wrap based on default character width
2015-10-15 15:22:18 +02:00
Antonio Scandurra
c38cd48555
Bring back failure reports when running grunt run-specs
...
Log output to stderr as we did before, so that grunt can, in turn, output it to
console when specs fail.
Welcome back build failures! 🎉
/cc: @nathansobo @maxbrunsfeld
2015-10-15 09:56:13 +02:00
Nathan Sobo
b58b3504f4
Only load/save AtomEnvironment state if persistence is enabled
2015-10-14 22:10:51 -06:00
Nathan Sobo
dc44d11a2c
Don’t load/save config if enablePersistence option is false
2015-10-14 20:05:06 -06:00
Nathan Sobo
95dd628d42
Fix for packages with no spec/fixtures directory
2015-10-14 17:10:30 -06:00
Nathan Sobo
f0da8f6324
Resolve package names to package currently being tested
...
This logic existed previously, but I accidentally removed it.
2015-10-14 16:35:00 -06:00
Max Brunsfeld
32780e2823
Merge branch 'master' into ns-alternative-test-env
...
Conflicts:
package.json
2015-10-14 14:12:42 -07:00
Max Brunsfeld
395ffde7a1
Merge pull request #9131 from atom/mb-fix-config-unset
...
Fix setting default values in config
2015-10-14 09:51:53 -07:00
Antonio Scandurra
582fa571b8
📝 Better spec description
2015-10-14 16:20:42 +02:00
Antonio Scandurra
6b01811d20
Avoid stack overflow when scrolling with non-integer values
...
We were mistakenly using the rounded scroll top to guard against such cases.
This fixes it by using `@realScrollTop` instead.
2015-10-14 16:10:12 +02:00
Antonio Scandurra
4b10f8a2b0
🔥 Avoid mocking atom.config in spec-helper
2015-10-14 12:47:33 +02:00
Antonio Scandurra
b25d3e944b
Parameterize configDirPath and move config.load in ctor
2015-10-14 12:41:36 +02:00
Antonio Scandurra
d9af8686ed
🔥 Avoid attaching CommandRegistry to window twice
2015-10-14 10:29:56 +02:00
Nathan Sobo
74d644ac73
Clear GrammarRegistry in AtomEnvironment::reset
2015-10-13 20:09:56 -06:00
Nathan Sobo
3ef6a9b63b
Remove workspaceParentSelector and always attach to document body
...
Tests never call startEditorWindow anyway.
2015-10-13 19:54:29 -06:00
Nathan Sobo
903ecca1f7
Parameterize document on AtomEnvironment
2015-10-13 19:48:56 -06:00
Nathan Sobo
65ae175e72
Pass explicit window global into AtomEnvironment on construction
2015-10-13 19:35:51 -06:00
Nathan Sobo
84aa8471b4
Pass AppDelegate to Workspace, Pane instead of bound functions
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-10-13 18:54:48 -06:00
Nathan Sobo
432a59b8e5
Move tests from window-event-handler-spec for moved functionality
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-10-13 17:53:01 -06:00
Nathan Sobo
919571f328
Use ApplicationDelegate in WindowEventHandler
...
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com >
2015-10-13 17:29:41 -06:00
Nathan Sobo
e92cb86335
Introduce ApplicationDelegate to AtomEnvironment
...
All external actions are performed via this delegate for test-isolation
purposes.
2015-10-13 15:42:57 -06:00
Nathan Sobo
a8ca3165a0
Remove dead code
2015-10-13 14:46:28 -06:00
Max Brunsfeld
47961a8e6b
Fix setting default values in config
2015-10-13 11:00:53 -07:00
Antonio Scandurra
6459891c89
💚 Make sure to destroy AtomEnvironment in specs
2015-10-13 15:30:45 +02:00
Antonio Scandurra
e51bad5618
🐛 Install WindowEventHandler in ctor
2015-10-13 12:38:45 +02:00
Antonio Scandurra
cf5d94f084
Return a promise in test runners
2015-10-13 09:02:37 +02:00
Nathan Sobo
f7a3e6c425
Don’t load base style sheets until config is loaded
...
We need to know what themes are active in order to load the correct LESS
variables.
2015-10-12 16:12:46 -06:00
Nathan Sobo
d4c88cc7fd
Merge branch 'master' into ns-alternative-test-env
2015-10-12 15:55:28 -06:00