Jason Rudolph
3d855b494d
Merge pull request #15981 from atom/decaf-tooltip-manager-spec
...
☠☕ ️ Decaffeinate `spec/tooltip-manager-spec.coffee`
2017-10-26 08:48:55 -04:00
Nathan Sobo
6e55b29331
Merge pull request #15993 from atom/dont-destroy-contained-folds
...
Preserve folds that are fully contained by the selection when changing selection ranges
2017-10-25 16:36:37 -06:00
Nathan Sobo
d44d6abe53
Merge pull request #15990 from atom/non-asar-legacy-spec-project-path
...
Don't assign a default project path for package specs that
2017-10-25 12:57:16 -06:00
Nathan Sobo
00242541ae
Don't destroy folds that are completely contained within a selection
2017-10-25 12:25:04 -06:00
Nathan Sobo
364964ea0a
Always assign a project path outside of bundle for legacy package specs
...
This prevents package specs that don't have a fixtures directory from
attempting to read files out of a non-existent directory inside the ASAR
bundle, which causes ENOTDIR errors in superstring.
If the spec does not have a parent folder containing a fixtures
directory, we now set the default project path to `os.tmpdir()`.
2017-10-25 10:34:43 -06:00
Wliu
2bf9e4b0c7
Use scope names rather than names
...
Some languages are not guaranteed to have names
2017-10-25 17:36:21 +02:00
Max Brunsfeld
9a95372613
Merge pull request #15977 from atom/mb-use-language-modes
...
Move `toggleLineComments` method from TokenizedBuffer to TextEditor
2017-10-24 16:03:21 -07:00
Jason Rudolph
fc620b9e80
🎨 Move helper functions outside of describe block
2017-10-24 09:06:50 -04:00
Jason Rudolph
aa69409b1b
🎨 Prefer arrow function syntax
2017-10-24 09:04:11 -04:00
Jason Rudolph
706f7e3d44
🎨 DS102 Remove unnecessary code created because of implicit returns
2017-10-24 08:58:59 -04:00
Jason Rudolph
76eb993e7e
🎨 DS101 Remove unnecessary use of Array.from
2017-10-24 08:56:20 -04:00
Jason Rudolph
90cfb69c7c
👕 Fix "'tooltipElement' is assigned a value but never used"
2017-10-24 08:53:24 -04:00
Jason Rudolph
f976c93d5a
👕 Fix "'disposable' is assigned a value but never used"
2017-10-24 08:51:40 -04:00
Jason Rudolph
7f75a46b97
👕 Fix "Return statement should not contain assignment"
2017-10-24 08:51:15 -04:00
Jason Rudolph
f771cf9d1a
☠ ☕ Decaffeinate spec/tooltip-manager-spec.coffee
...
Apply results of running:
$ decaffeinate --keep-commonjs --prefer-const --loose-default-params --loose-for-expressions --loose-for-of --loose-includes spec/tooltip-manager-spec.coffee
$ standard --fix spec/tooltip-manager-spec.js
2017-10-24 08:47:44 -04:00
Jason Rudolph
622589f4f7
Merge pull request #15958 from atom/decaf-view-registry
...
☠☕ Decaffeinate `ViewRegistry`
2017-10-24 08:41:32 -04:00
Nathan Sobo
84f6f3e525
Merge pull request #15976 from atom/paste-without-reformatting
...
Add command to paste without reformatting
2017-10-23 20:21:38 -06:00
Max Brunsfeld
079f4d901c
Move all .toggleLineComments tests to text-editor-spec.js
2017-10-23 17:00:05 -07:00
Max Brunsfeld
311567ecec
Simplify .toggleLineComments method to avoid using oniguruma
2017-10-23 16:45:12 -07:00
leroix
c2662761f0
Merge pull request #15954 from atom/faster-overlay-resizing
...
Only update overlay instead of text editor when resize occurs
2017-10-23 17:05:57 -06:00
Nathan Sobo
6701644bbd
Respect format-preserving options in TextEditor.pasteText
2017-10-23 17:02:41 -06:00
Nathan Sobo
bbbf09ecf2
Add preserveTrailingLineIndentation option to Selection.insertText
...
We can use this to support a new command that preserves all formatting
when pasting.
2017-10-23 16:46:38 -06:00
Justin Ratner
ed94726fab
fix overlayComponent access syntax in test
2017-10-23 14:32:34 -06:00
Max Brunsfeld
49a2d0eeeb
Merge pull request #15974 from atom/mb-fix-fold-current-row-error
...
Fix exception when trying to fold non-foldable row
2017-10-23 11:12:52 -07:00
Max Brunsfeld
8d532e7780
Fix exception when trying to fold non-foldable row
2017-10-23 10:20:45 -07:00
Jason Rudolph
db960763cf
Merge pull request #15947 from atom/decaf-window-event-handler-spec
...
☠☕ ️ Decaffeinate `spec/window-event-handler-spec.coffee`
2017-10-23 08:39:31 -04:00
Jason Rudolph
01e7faa988
👔 Fix "Arrow function should not return assignment"
2017-10-21 10:10:06 -04:00
Jason Rudolph
33aea76058
👔 Fix "The object literal notation {} is preferrable"
2017-10-21 10:07:13 -04:00
Jason Rudolph
9a6f4b1647
👔 Fix "'model' is assigned a value but never used"
2017-10-21 10:05:57 -04:00
Jason Rudolph
c6d438c509
☠ ☕ Decaffeinate spec/view-registry-spec.coffee
2017-10-21 10:05:22 -04:00
Justin Ratner
089717cbd3
fix failing test
2017-10-20 15:46:27 -06:00
Wliu
1975e37e31
Merge pull request #13597 from Ingramz/rework-grammar-scores
...
Prioritize first line matches over bundled/non bundled cirteria in grammar scoring
2017-10-20 22:30:51 +02:00
Jason Rudolph
d23510fce9
☠ ☕ ️ Decaffeinate spec/window-event-handler-spec.coffee
2017-10-20 08:36:20 -04:00
Indrek Ardel
0f89211d55
Prioritize first line matches over bundled/non bundled cirteria
2017-10-20 13:34:15 +03:00
Jason Rudolph
4db60e34b8
👔 Fix linter error: "Arrow function should not return assignment."
2017-10-18 20:13:55 -04:00
Jason Rudolph
49655a97c8
🎨
2017-10-18 20:10:24 -04:00
Jason Rudolph
6e78281a73
🎨 Prefer fat arrow function syntax
2017-10-18 19:54:51 -04:00
Jason Rudolph
498d7c90eb
Rewrite code to no longer use __guard__
2017-10-18 19:54:51 -04:00
Jason Rudolph
db115d3ab8
Remove unnecessary code created because of implicit returns
2017-10-18 19:54:51 -04:00
Jason Rudolph
61b228d8a0
Remove unnecessary use of Array.from
2017-10-18 19:54:51 -04:00
Jason Rudolph
c632e6ca58
☠ ☕ Decaffeinate spec/project-spec.coffee
...
Apply results of running:
```
$ decaffeinate --keep-commonjs --prefer-const --loose-default-params --loose-for-expressions --loose-for-of --loose-includes spec/project-spec.js
$ standard --fix spec/project-spec.js
```
2017-10-18 19:54:51 -04:00
Antonio Scandurra
280253fdfa
Merge pull request #15916 from atom/as-jr-stop-dragging-when-interacting-with-keyboard
...
Stop dragging only when user interacts with keyboard
2017-10-18 11:38:52 +02:00
Michelle Tilley
5e43084cd3
url -> URI
2017-10-17 15:23:10 -07:00
Michelle Tilley
5e96429c9e
Merge remote-tracking branch 'origin/master' into mkt-url-based-command-dispatch
2017-10-17 11:18:02 -07:00
Antonio Scandurra
65af9e953b
Stop dragging only when user interacts with keyboard
...
Previously, we used to prevent the user from dragging the selection
further when the buffer was about to change. This was problematic
because any change in the buffer, even one that was performed
"automatically" by a package, would cancel the dragging action and
result in a confusing experience for the user.
On the other hand, we want to prevent users from accidentally selecting
text when they perform an edit (see #15217 , #15405 ).
This commit addresses both concerns by canceling the dragging as soon as
the user interacts with the keyboard, instead of canceling the dragging
when the buffer is about to change.
One downside of this approach is that it changes the behavior of
pressing a keystroke that does not result in a buffer change, e.g.
Shift, Arrow Keys, etc.
Signed-off-by: Jason Rudolph <jasonrudolph@github.com >
2017-10-17 18:50:20 +02:00
Antonio Scandurra
7853e3cd8c
Don't throw when destroying block decorations inside marker change event
2017-10-11 09:42:53 +02:00
Jason Rudolph
7463925e94
Merge pull request #15834 from atom/jr-decaf-gutter-container
...
Decaffeinate `GutterContainer`
2017-10-07 15:12:38 -04:00
Jason Rudolph
f79708a74a
Merge pull request #15823 from atom/jr-decaf-gutter
...
Decaffeinate `Gutter`
2017-10-06 09:35:11 -04:00
Jason Rudolph
d546037863
☠ ☕ Decaffeinate spec/gutter-container-spec.coffee
2017-10-06 09:33:43 -04:00
Antonio Scandurra
d83304cbdd
Exercise more features in the randomized test
...
Signed-off-by: Nathan Sobo <nathan@github.com >
2017-10-05 19:41:28 +02:00
