Commit Graph

16671 Commits

Author SHA1 Message Date
Antonio Scandurra
49e704291d Register for core.titleBar changes after the initial load of config
This prevents the change handler for `core.titleBar` from being
triggered every time a new instance of the main process is created. This
fixes a regression that was causing users to be prompted for a restart
every time they opened Atom.

Co-authored-by: Max Brunsfeld <maxbrunsfeld@github.com>
Co-authored-by: Nathan Sobo <nathan@github.com>
2018-01-31 09:24:15 -07:00
Max Brunsfeld
669b22ce1e Merge pull request #16544 from rosston/fix-cursor-movement
Fix includeNonWordCharacters regression in Cursor
2018-01-29 09:55:26 -08:00
Wliu
46d9d190c2 Merge pull request #16627 from atom/wl-revert-right-click-move
Revert change to move mouse cursor on right-click
2018-01-26 23:52:59 -05:00
Wliu
7e0635d2c0 Fix spec 2018-01-26 18:41:57 -05:00
Max Brunsfeld
02d61c1b28 Add the word Experimental to the tree-sitter setting description 2018-01-26 14:11:47 -08:00
Max Brunsfeld
8f5cecbacd Use a queue to prevent concurrent async writeFile calls 2018-01-26 11:15:35 -08:00
Max Brunsfeld
1d20b8ee1d Start work on routing all config file IO through main process 2018-01-25 20:35:00 -08:00
Max Brunsfeld
14c41e25d9 🎨 Config 2018-01-25 14:13:38 -08:00
Max Brunsfeld
5b776f7334 Merge pull request #16633 from atom/mb-fix-tree-sitter-highlight-updates
Fix typo in TreeSitterLanguageMode.onDidChangeHighlighting
2018-01-25 14:06:39 -08:00
Max Brunsfeld
34e2d354c2 Fix typo in TreeSitterLanguageMode.onDidChangeHighlighting 2018-01-25 14:02:31 -08:00
Max Brunsfeld
6715ade98f Merge pull request #16620 from captbaritone/decaf-menu-helpers
Decaffeinate menu-helpers.coffee
2018-01-25 11:01:14 -08:00
Jordan Eldredge
a924dafc7d Handle case where itemSpecificity is passed but falsy 2018-01-25 09:25:06 -08:00
Wliu
be24e6edf7 Revert change to move mouse cursor on right-click 2018-01-24 11:22:41 -05:00
Max Brunsfeld
8ba04f0f0c Merge pull request #16593 from atom/fb-pw-decaffeinate-config
decaffeinate config.coffee and config-spec.coffee
2018-01-23 22:52:43 -08:00
Jordan Eldredge
6c848239f4 Decaffeinate menu-helpers.coffee 2018-01-23 11:20:28 -08:00
David Wilson
6d09a5257a Fix #16538: Middle-click pastes into read only editor on Linux
This change fixes an issue where users on Linux are able to paste into
read only TextEditors by clicking the middle mouse button.  The fix is
to check for whether the TextEditorComponent's isInputEnabled method
returns true before pasting with middle click on Linux.
2018-01-22 18:50:07 -08:00
David Wilson
da22ea8f80 Decaffeinate src/item-registry.coffee 2018-01-22 16:14:25 -08:00
David Wilson
4a151ac210 Fix #14716: Error when deserializing TreeView for project
This change fixes an issue that appears when the user removes the last
project from the workspace and then re-adds it.  At this time an error
is thrown from within ItemRegistry because the PaneContainer that
holds the TreeView in the left-most dock does not clear out its
existing ItemRegistry before deserializing the old TreeView state.

The fix is to create a new ItemRegistry when a PaneContainer is
deserialized so that the previous Pane's items are not retained.
2018-01-22 15:13:37 -08:00
Philip Weiss
429d3cd898 Merge branch 'master' of github.com:atom/atom into fb-pw-decaffeinate-config 2018-01-22 09:57:57 -08:00
Bryant Ung
c100ad0108 Merge pull request #16525 from atom/wl-async-message-box
Use async dialog.showMessageBox
2018-01-21 13:39:48 -08:00
Antonio Scandurra
ef96cc770e Merge pull request #16595 from atom/as-fix-subpixel-aa
Don't break subpixel AA when cursor is at the end of longest line
2018-01-20 17:00:49 +01:00
Antonio Scandurra
ff6dc42fcd Merge pull request #16594 from atom/as-stop-transpiling-core-js-paths
Stop using Babel in Atom Core (benchmarks, exports, src)
2018-01-20 10:30:56 +01:00
Philip Weiss
9bc43bda9b fix small indentation errors 2018-01-19 17:11:16 -08:00
Wliu
056c825d18 Merge branch 'master' into wl-async-message-box 2018-01-19 16:12:37 -05:00
Max Brunsfeld
9f35de4413 Always return an array from AtomApplication.launch 2018-01-19 13:08:49 -08:00
Max Brunsfeld
f7aba5a132 Replace loadState with side-effect-free loadPreviousWindowOptions
Signed-off-by: Nathan Sobo <nathan@github.com>
2018-01-19 13:08:49 -08:00
Max Brunsfeld
744ae36f31 🔥 dead code
Signed-off-by: Nathan Sobo <nathan@github.com>
2018-01-19 11:56:25 -08:00
Max Brunsfeld
fd5f8af292 Fix typo in StorageFolder.clear 2018-01-19 11:52:34 -08:00
Max Brunsfeld
61e53834e6 Make StorageFolder.load, AtomApplication.launch async
Signed-off-by: Nathan Sobo <nathan@github.com>
2018-01-19 11:52:25 -08:00
Max Brunsfeld
e2ad4e6a8b Make StorageFolder.store async
Signed-off-by: Nathan Sobo <nathan@github.com>
2018-01-19 11:37:07 -08:00
Philip Weiss
fc07ad2cd5 Merge branch 'master' of github.com:atom/atom into fb-pw-decaffeinate-config 2018-01-19 11:26:53 -08:00
Philip Weiss
657ef0f16e fix linting issues and remove decaffeinate suggestions 2018-01-19 11:05:43 -08:00
Philip Weiss
43a07bb8b8 remove Array.from(s) and add consts 2018-01-19 11:01:32 -08:00
Philip Weiss
2a54dda3e9 remove Array.from(s) and remove IIFEs 2018-01-19 10:56:23 -08:00
Philip Weiss
86ba6cbfe4 update arguments object to rest args and remove array.from(s) 2018-01-19 10:31:10 -08:00
Philip Weiss
a18200d675 update arguments object to rest args and remove array.from(s) 2018-01-19 10:18:28 -08:00
Antonio Scandurra
3fbfadde5a Don't break subpixel AA when cursor is at the end of longest line
With the Electron upgrade, something changed in the way characters are
rendered/measured, and that was causing subpixel anti-aliasing to stop
working when cursors were at the end of the longest line.

Every cursor has a width that is calculated in the following way:

* If there's a character after the cursor, the width corresponds to
width of such character.
* Otherwise, the width equals to the "base character width" measured on
a dummy line.

In the latter case, even if we were setting the width of the content
container to account for the width of such cursor, some rounding problem
was causing the cursor to be able to escape the container and thus break
subpixel anti-aliasing.

With this commit, instead of rounding the value we assign to the
container width, we will always ceil it. This ensures that cursors are
always strictly contained within the parent element and resolves the
subpixel anti-aliasing issue.
2018-01-19 11:20:53 +01:00
Antonio Scandurra
e68a2b1eb9 Replace import and export keywords with require and module.exports 2018-01-19 09:43:55 +01:00
Philip Weiss
cb77a4801c add default param to options 2018-01-18 16:51:40 -08:00
Philip Weiss
952052d2e5 update comment spacing issues and add default param 2018-01-18 16:46:00 -08:00
Max Brunsfeld
7c8f73b2d8 Make StorageFolder.clear async 2018-01-18 15:14:35 -08:00
Philip Weiss
1a99a4848c replace function(...) with arrow funcs 2018-01-18 14:52:47 -08:00
Philip Weiss
98dace3372 remove some unnecessary returns 2018-01-18 14:37:51 -08:00
Philip Weiss
e9a4d3ca2a remove guard func and comment 2018-01-18 14:33:48 -08:00
Philip Weiss
acaf8a0316 remove first guards 2018-01-18 14:32:01 -08:00
Philip Weiss
b638562e0c remove call() and var 2018-01-18 13:46:38 -08:00
Philip Weiss
5589b11e92 fix linting rules except for .call() 2018-01-18 13:31:28 -08:00
Max Brunsfeld
400abcba34 Decaffeinate StorageFolder 2018-01-18 12:02:43 -08:00
Max Brunsfeld
9694448f9d Handle concurrent calls to the same channel in ipc helpers 2018-01-18 11:27:27 -08:00
Max Brunsfeld
0390548e2c Make FileRecoveryService async 2018-01-18 11:27:27 -08:00