Commit Graph

14093 Commits

Author SHA1 Message Date
probablycorey
dadb0d5427 Update feedback package 2013-12-16 14:32:58 -08:00
Kevin Sawicki
9cdc15b161 Guard against no other focusable elements
This previously occurred in areas we all the elements had a -1 tabindex
 or were disabled.
2013-12-16 13:54:59 -08:00
Kevin Sawicki
7c27cbd9f5 Merge pull request #1320 from atom/ks-native-commands
Handle native commands in render process
2013-12-16 13:46:18 -08:00
Kevin Sawicki
010931391e Use event.target 2013-12-16 12:14:41 -08:00
Kevin Sawicki
eaf6aba943 Return true from event handler 2013-12-16 12:12:14 -08:00
Kevin Sawicki
d60d710325 Inline sendActionToFirstResponder 2013-12-16 12:11:19 -08:00
Kevin Sawicki
bb1bcc233a Handle native commands in render process
This fixes copy, paste, undo, redo for elements with a native-key-bindings
class by forwarding to the menu's first responder from the render process.
2013-12-16 12:06:43 -08:00
Ben Ogle
f0813dbca8 Upgrade to find-and-replace@0.60.0 2013-12-16 11:35:20 -08:00
Matt Colyer
9bded1cd19 Upgrade metrics@0.19.0 2013-12-16 11:32:08 -08:00
Ben Ogle
c6e96a6188 Merge pull request #1308 from atom/bo-common-functions-up-a-level
Common core commands to workspaceView
2013-12-16 11:12:44 -08:00
probablycorey
09ff90bfc4 Update tabs package 2013-12-16 08:54:54 -08:00
Kevin Sawicki
2bf9036578 Upgrade to to-the-hubs@0.16.0 for menu tweak 2013-12-13 15:36:39 -08:00
Kevin Sawicki
6a7e4c30fb 🐎 Memoize version to prevent future IPC calls 2013-12-13 14:49:23 -08:00
Nathan Sobo
ed41cc3cad Restore comment 2013-12-13 14:07:30 -08:00
Kevin Sawicki
9aee5adeb6 Upgrade to metrics@0.18.0 to report shell load time 2013-12-13 12:26:37 -08:00
Kevin Sawicki
70f3527123 Expose shell load time render process for metrics 2013-12-13 12:15:45 -08:00
Nathan Sobo
e67e8ff0f5 Restore Atom::getLoadSettings and spy on it in window spec
I initially ripped out Atom::getLoadSettings in favor of a mutable
property because window spec was making an assumption that such a
property existed anyway. Since load settings need to be available from
class methods, the instance method just delegates to the class method.
But that means there's no ::loadSettings property to mutate in that
spec. I replaced the former approach with a spy which has the added
advantage of not polluting windowSettings for subsequent specs.
2013-12-13 12:02:48 -08:00
Kevin Sawicki
4448a7419c Upgrade to tree-view@0.50.0 2013-12-13 11:16:25 -08:00
Nathan Sobo
e18a0f045a Upgrade to telepath 0.74.0 to avoid shredding of orphaned object graphs
We call atom.destroyOrphans after each spec now to clean up any orphaned
objects. Previously, we we destroying any object not reachable from the
root document. This was causing children of orphaned objects to be
removed from their parent, which caused null pointer exceptions when
running the destroy handlers for the orphans. Now we only destroy the
roots of orphaned object graphs.
2013-12-13 11:02:03 -08:00
Ben Ogle
e8e84cbd2f Upgrade to tree-view@0.49.0 2013-12-13 10:38:39 -08:00
Ben Ogle
e8c5027026 💄 Update specs to use ::function() format 2013-12-13 10:28:38 -08:00
Nathan Sobo
da964a8f15 Fix comment 2013-12-13 09:55:45 -08:00
Nathan Sobo
2c4aee1181 Restore cloning of ::loadSettings in ::getLoadSettings
It's a deprecated method, but if you call it you'll get a clone.
2013-12-13 09:55:13 -08:00
Nathan Sobo
24d3f1daeb Reduce diff size by restoring old method order where possible 2013-12-13 09:50:57 -08:00
Nathan Sobo
beb2fb08ea Merge branch 'master' into ns-telepathic-atom-global
Conflicts:
	package.json
2013-12-13 09:32:13 -08:00
Kevin Sawicki
7b86891642 Upgrade to tree-view@0.48.0 for scroll left fixes 2013-12-12 18:24:54 -08:00
Kevin Sawicki
87e325dce1 Set body's visibility to hidden when unloading
Previously the display was changed to none via $.hide() which accidentally
affected the ability of package's to serialize DOM properties such as
scrollTop since the value would always be zero when the display was none.

The goal here is to just prevent a flicker when refreshing the
editor window and setting visibility to hidden still accomplishes this.
2013-12-12 18:05:36 -08:00
Kevin Sawicki
ee87c757ed Upgrade to tree-view@0.47.0 for arrow fix 2013-12-12 18:04:25 -08:00
Ben Ogle
a25812dca7 Move cmd-s and cmd-S to workspaceView 2013-12-12 17:50:15 -08:00
Ben Ogle
1f9a7599b7 cmd-w works anywhere in the editor 2013-12-12 17:50:15 -08:00
Kevin Sawicki
07dee8838c Upgrade to tree-view@0.46.0 2013-12-12 17:46:09 -08:00
Kevin Sawicki
8367b020ec Upgrade to editor-stats@0.9.0 for bug fix 2013-12-12 17:41:50 -08:00
Nathan Sobo
9fce6a2f1c Merge branch 'ns-guard-dead-editors' 2013-12-12 17:11:20 -08:00
Nathan Sobo
165a417a9d Upgrade to telepath 0.73.0 for Document::create default values 2013-12-12 16:59:41 -08:00
Nathan Sobo
39fe0c418b Add back deprecated Atom::getLoadSettings method for packages 2013-12-12 16:49:00 -08:00
Nathan Sobo
75cee638bc Protect from exceptions when attaching editor views w/ dead editors
Addresses #1306

We still need to know why this is happening, so I left an exception in
non-release builds. Since the pane system is about to change a lot I
think this is good enough for now.
2013-12-12 16:41:35 -08:00
Matt Colyer
ae72d4ad56 Upgrade exception-reporting@0.9.0 2013-12-12 16:41:09 -08:00
Nathan Sobo
bfcb24f517 Fix pesky workspace view serialization spec
This isn't beautiful, but this whole approach is slated to be replaced
in the recent future.
2013-12-12 16:36:34 -08:00
Nathan Sobo
208ed09109 Use atom.state instead of defunct windowState in spec 2013-12-12 16:35:56 -08:00
Nathan Sobo
0b7f291e17 Remove reference to workspaceView in Atom::unloadEditorWindow 2013-12-12 16:35:26 -08:00
Nathan Sobo
a61b057aea Eliminate exceptions in Editor::inspect 2013-12-12 16:34:48 -08:00
Nathan Sobo
4c817baf4c Don't destroy project when WorkspaceView is removed
Whenever we're removing the workspaceView, we're usually destroying
the project anyway.
2013-12-12 16:34:10 -08:00
Nathan Sobo
a564cc66f6 Replace Atom::getLoadSettings with a ::loadSettings property
We assign a value into ::loadSettings anyway in a spec, so there's not
much point leaving it a method. Eventually I'd like to pass all these
settings in when constructing the Atom object and eliminate awareness
of the loadSettings altogether from the Atom global.
2013-12-12 16:33:30 -08:00
Nathan Sobo
14c58c4517 Set up window event handler for all windows 2013-12-12 15:45:25 -08:00
Nathan Sobo
ebe77065cc Destroy orphans after each spec 2013-12-12 15:45:16 -08:00
Ben Ogle
e1d35ed90f Upgrade dev-live-reload@0.20.0
Fix issue with reloading on changes to variable files
2013-12-12 15:45:00 -08:00
Corey Johnson
5d23a8fceb Merge pull request #1271 from atom/cj-deleted-files-not-modified
Handle deleted files correctly
2013-12-12 15:15:47 -08:00
Nathan Sobo
30b0fed60f Remove packageStates from atom state after specs just in case 2013-12-12 15:11:59 -08:00
probablycorey
90f3726c5c Fix window specs 2013-12-12 15:10:01 -08:00
Nathan Sobo
5f10c48219 Kill double project assignment 2013-12-12 14:40:12 -08:00