Antonio Scandurra
708da39355
Avoid using tokenizedLineForScreenRow in TextEditorPresenter specs
2016-03-17 10:35:54 +01:00
joshaber
98c8a08ac3
s/ignoreScrollPastEnd/scrollPastEnd
2016-03-03 10:06:15 -05:00
joshaber
4cd7cbda02
Test ignoreScrollPastEnd.
2016-03-01 10:53:31 -05:00
Max Brunsfeld
98559f5d34
Add missing
2016-02-22 16:31:17 -08:00
Max Brunsfeld
ea5500a124
Print line number of wait timeout in presenter spec
2016-02-22 16:31:06 -08:00
joshaber
f0a179fdb5
Add the decoration after subscribing to state updates
...
Same fixe as #10792 .
2016-02-15 17:19:32 -05:00
joshaber
cc3f6b888f
Don't need to duplicate this line.
2016-02-12 16:35:16 -05:00
joshaber
82860a12a0
Fix waitsForStateToUpdate proper like.
2016-02-12 16:35:10 -05:00
joshaber
9fa766e01a
Don't use synchronous updates anymore.
2016-02-12 15:13:10 -05:00
joshaber
6813bf50a0
Use waitsForStateToUpdateAsync in a bunch of places.
2016-02-12 14:00:47 -05:00
joshaber
272ff19d7b
Decrease the timeout interval.
2016-02-12 13:58:54 -05:00
joshaber
8b14f5afdc
Let's get some deterministic failures.
2016-02-12 13:58:38 -05:00
joshaber
319043c93d
Update this test too.
2016-02-12 12:11:52 -05:00
joshaber
07d35245e0
Move it around again.
2016-02-12 11:51:48 -05:00
joshaber
a3ec51f492
Let's try rearranging this.
2016-02-12 11:46:43 -05:00
joshaber
dd6a6be8b1
Once more, with feeling.
2016-02-12 10:56:36 -05:00
joshaber
3e7de73580
Bump the timeout.
2016-02-12 09:58:37 -05:00
Wliu
8ca1071168
Update presenter specs
2016-02-08 16:52:47 -05:00
Antonio Scandurra
1f0e6a0902
Don't calculate height for following decorations at beginning of tiles
2016-01-13 09:21:31 -07:00
Antonio Scandurra
4499fa8d6f
Split following and preceding block decorations
...
In TextEditorPresenter's state for lines.
2016-01-12 12:04:12 -07:00
Antonio Scandurra
63220f7ead
Add presenter specs for block decorations *after* a row
2016-01-12 10:54:56 -07:00
Antonio Scandurra
8603ceb7e8
Make spec more comprehensive
2016-01-06 11:12:21 +01:00
Antonio Scandurra
1376afe17e
🎨
2016-01-05 10:57:32 +01:00
Antonio Scandurra
c7a7f0c6dd
🐛 Ignore setting dimensions for destroyed decorations
2016-01-05 10:56:29 +01:00
Antonio Scandurra
eab70d9a95
Invalidate spliced block decorations' dimensions
2015-12-19 15:38:34 +01:00
Antonio Scandurra
dfb095b754
🔥 Remove TextEditor.prototype.addBlockDecorationForScreenRow
2015-12-19 13:00:47 +01:00
Antonio Scandurra
07234c5109
Resize all block decorations when width changes
2015-12-19 12:50:58 +01:00
Antonio Scandurra
5e0863c119
✅ Write specs for moving markers manually
2015-12-19 12:02:49 +01:00
Antonio Scandurra
5fa9d3bc40
Splice LineTopIndex when DisplayBuffer changes
...
We invalidate whole screen lines accordingly to `DisplayBuffer`, so that we can
catch if there was any screen-only transformation and move block decorations
accordingly.
2015-12-19 11:21:50 +01:00
Antonio Scandurra
db9f67b9a5
🔥 Remove maxRow parameter
2015-12-18 15:41:46 +01:00
Antonio Scandurra
087dc3b4fd
Back to green specs 🤘
2015-12-18 15:18:04 +01:00
Antonio Scandurra
877eea3bd0
Finish integrating LineTopIndex
2015-12-18 11:07:10 +01:00
Antonio Scandurra
6a403e441e
Start integrating tree-based LineTopIndex
2015-12-18 10:41:21 +01:00
Antonio Scandurra
8c1f0b0e21
Merge branch 'master' into as-block-decorations
...
# Conflicts:
# spec/fake-lines-yardstick.coffee
# spec/lines-yardstick-spec.coffee
# spec/text-editor-presenter-spec.coffee
# src/lines-yardstick.coffee
# src/text-editor-component.coffee
# src/text-editor-presenter.coffee
2015-12-18 09:59:12 +01:00
Max Brunsfeld
a16b99fa58
Merge pull request #10062 from atom/mb-emit-state-update-on-model-scroll
...
Emit state update when model's scroll position is changed
2015-12-14 17:38:36 -08:00
Max Brunsfeld
02ab7179ce
Emit state update when model's scroll position is changed
2015-12-14 16:56:53 -08:00
Antonio Scandurra
4b6a218bb9
Start to move stuff back into TextEditorPresenter
2015-12-14 15:53:01 +01:00
Antonio Scandurra
cfb30c795d
Use an updated version of LineTopIndex
2015-12-14 15:04:54 +01:00
Antonio Scandurra
2e7048d8c6
Merge pull request #10028 from atom/ns-remove-presenter-flags
...
Remove non-essential update guard flags from TextEditorPresenter
2015-12-14 11:43:19 +01:00
Nathan Sobo
3d8058a9a4
Remove failing redundant assertions
...
The expectNoStateUpdate is sufficient to test the issue in question. Now
that most flags are removed, we can’t count on this part of the state
not being updated when we request a state recompilation.
2015-12-11 14:02:57 -07:00
Nathan Sobo
5cfd3423bf
Use internal scroll assignment methods when committing logical positions
...
This prevents an addition pending assignment and cuts directly to
adjusting the positions.
2015-12-11 13:34:46 -07:00
Nathan Sobo
85c6139579
Don’t force DOM updates in LinesYardstick
...
Instead, determine the need for a DOM update in the component before
measuring with the lines yardstick, and break `updateSync` into two
explicit pre- and post-measurement phases.
2015-12-10 14:47:05 -07:00
Antonio Scandurra
b77c45859c
Merge branch 'master' into as-block-decorations
...
# Conflicts:
# spec/text-editor-presenter-spec.coffee
2015-12-04 14:44:19 +01:00
Antonio Scandurra
16525047f1
💚 Fix component and presenter specs
2015-12-04 12:49:59 +01:00
Antonio Scandurra
f2a0221519
Make sure block decorations are always in the right spot
2015-12-03 18:16:10 +01:00
Antonio Scandurra
555d77afa6
Do not remove invisible decorations on ::mouseWheelScreenRow
2015-12-03 15:45:47 +01:00
Antonio Scandurra
e4655c62e4
💚 Fix false negative
2015-12-03 15:07:54 +01:00
Antonio Scandurra
5f6f99259e
Ensure custom gutters work properly
2015-12-03 15:05:14 +01:00
Antonio Scandurra
f22bd5d0ae
🐎 Use ids instead of classes
2015-12-03 11:52:10 +01:00
Antonio Scandurra
937116a280
Render only visible and yet-to-be-measured block decorations
2015-12-03 11:26:45 +01:00
