Commit Graph

6847 Commits

Author SHA1 Message Date
joshaber
9da71cf7c0 Wait for the first refresh to complete. 2015-11-09 12:14:50 -05:00
joshaber
4b8bad2b0b Focus async its. 2015-11-09 12:10:49 -05:00
Daniel Hengeveld
371c68e65e Revert "await getCachedPathStatus in specs"
This reverts commit d8985c8175.
2015-11-09 16:57:08 +01:00
joshaber
cbc3dfb555 🔥 terribleWait. 2015-11-09 10:51:31 -05:00
joshaber
8f59693d83 Use asyncIt here too. 2015-11-09 10:51:31 -05:00
Daniel Hengeveld
d8985c8175 await getCachedPathStatus in specs 2015-11-09 16:51:02 +01:00
Daniel Hengeveld
60c6dc4da3 Merge branch 'dh-async-repo' of github.com:atom/atom into dh-async-repo 2015-11-09 16:48:16 +01:00
Daniel Hengeveld
e3af723c9b Copy relativize and getPathStatus from #9469 2015-11-09 16:40:44 +01:00
joshaber
a9dae48ac4 It's better if we actually run the tests. 2015-11-09 10:39:02 -05:00
Daniel Hengeveld
bdc8a38045 add final buffer event spec 2015-11-09 16:15:55 +01:00
Daniel Hengeveld
14d470a5e5 unforce spec 2015-11-09 16:01:35 +01:00
Daniel Hengeveld
ff4f26e1ec coffeelint fix 2015-11-09 15:38:24 +01:00
Daniel Hengeveld
e2a1337b84 Merge branch 'master' into dh-async-repo 2015-11-09 13:08:23 +01:00
Nathan Sobo
5587bad758 Add description to waitsFor 2015-11-09 00:35:34 -07:00
Nathan Sobo
a35e24658d Increase timeouts 2015-11-09 00:35:34 -07:00
Nathan Sobo
6dd18b348b Include more debug info when nextViewUpdatePromise times out 2015-11-09 00:35:34 -07:00
Nathan Sobo
98c420a408 Wait for nextTick after presenter updates
This gives any nextTick callbacks in the model a chance to complete
before proceeding with tests.
2015-11-09 00:35:34 -07:00
Nathan Sobo
21f8ad6958 Bump timeouts 2015-11-09 00:35:34 -07:00
Nathan Sobo
1a8adbb4e1 🎨 2015-11-09 00:35:33 -07:00
Nathan Sobo
ff681752f7 Add a nextViewUpdatePromise helper so we get stack traces from timeouts 2015-11-09 00:35:33 -07:00
Nathan Sobo
e9dfc080a3 Convert text-editor-component-spec to Babel for async/await
It's much easier to reason about async/await than Jasmine's
built-in queuing system, and using them made it easier to
debug flaky async tests.
2015-11-09 00:35:32 -07:00
Nathan Sobo
9ee3d53975 Destroy the selections marker layer when editors are destroyed 2015-11-09 00:35:31 -07:00
Nathan Sobo
2f81e5faac Store folds in their own marker layer 2015-11-09 00:35:31 -07:00
Nathan Sobo
29bb1bb31b Add TextEditor-level marker layers and use them for selections 2015-11-09 00:35:31 -07:00
Nathan Sobo
b508cc6d9f Fix linter error 2015-11-09 00:35:30 -07:00
Nathan Sobo
a3ff0ad75a 🎨 Rename method 2015-11-09 00:35:28 -07:00
Nathan Sobo
75d0a0820c Allow properties to be overridden for a single marker in LayerDecoration 2015-11-09 00:35:28 -07:00
Nathan Sobo
acf142863c Add TextEditor::decorateMarkerLayer 2015-11-09 00:35:27 -07:00
Nathan Sobo
20f4c61325 Drop stray sample.js file 2015-11-09 00:35:27 -07:00
Nathan Sobo
3a25fe4975 Remove id from decoration properties
It doesn’t make sense to include this when we’ll reuse the same
properties for multiple decoration instances when decorating marker
layers.
2015-11-09 00:35:27 -07:00
Nathan Sobo
7d22ed788c Test decorateMarker + decorationStateForScreenRowRange 2015-11-09 00:35:27 -07:00
Nathan Sobo
9d6168aac8 Fix gutter spec indentation 2015-11-09 00:35:27 -07:00
Nathan Sobo
3c98c30b43 Wait for animation frames synchronously after actions
This avoids test flakiness, presumably due to an animation frame firing
before we have a chance to wait due to jasmine’s queueing.
2015-11-09 00:35:26 -07:00
Nathan Sobo
2af010e729 Remove dead test
It tests functionality that no longer matters since we don’t subscribe
to decorations being destroyed in DisplayBuffer
2015-11-09 00:35:26 -07:00
Nathan Sobo
0169c1160e Wait for next DOM update synchronously after change to avoid flakiness 2015-11-09 00:35:26 -07:00
Nathan Sobo
0ac42a12f3 Add waitsForNextDOMUpdate helper function 2015-11-09 00:35:18 -07:00
Nathan Sobo
4b5e4d02eb Use real clock in text-editor-component-spec
This will make it much easier to test asynchronous update logic.
2015-11-09 00:35:18 -07:00
Nathan Sobo
1aefb22789 Add ViewRegistry.prototype.getNextUpdatePromise
Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
2015-11-09 00:35:18 -07:00
Max Brunsfeld
cdaac9dfcc wip 2015-11-09 00:35:18 -07:00
Nathan Sobo
1fd2ba084c Merge pull request #8232 from lpommers/move-lines-up-and-down-with-multiple-selections
Move lines up and down with multiple selections
2015-11-07 14:40:58 -07:00
joshaber
87da3579e8 Cite it. 2015-11-07 01:35:57 -05:00
joshaber
247d4d4785 Merge branch 'master' into dh-async-repo 2015-11-07 01:35:48 -05:00
joshaber
c076a047e4 Async harder. 2015-11-07 01:31:04 -05:00
joshaber
d5181361a0 Async/await a lot of things. 2015-11-06 21:39:23 -05:00
joshaber
009951e757 Get these tests going. 2015-11-06 14:18:59 -05:00
Max Brunsfeld
b58752da38 Keep model's logical scroll position up to date
* Remove scrollRow and scrollColumn properties from the presenter
* Assign presenter's scrollTop and scrollLeft based on model's first visible
  screen row and column, once the presenter has the required measurements.
2015-11-06 11:16:56 -08:00
Max Brunsfeld
4d40e28c6b Remove presenter constructor parameters that aren't used in production 2015-11-06 09:56:58 -08:00
joshaber
a8da39b90c Merge branch 'master' into dh-async-repo 2015-11-06 11:43:37 -05:00
Wliu
7db555c96b Fix core specs 2015-11-06 10:26:36 -05:00
Wliu
eafb6697ac Revert "Fix core specs"
This reverts commit 7a4921fe48.
2015-11-05 18:55:15 -05:00