Commit Graph

57 Commits

Author SHA1 Message Date
Ben Ogle
70e1d14f96 Add KeymapManager::onDidLoadBundledKeymaps 2014-09-10 17:28:47 -07:00
Ben Ogle
229277f764 Add PackageManager::onDidActivateAll() 2014-09-09 15:03:45 -07:00
Ben Ogle
a296364e53 Fixup doc strings that don’t parse correctly
We can’t have a huge indent on the second line of a list item. Markdown
parses it as a code block. :(
2014-08-26 10:47:36 -07:00
Kevin Sawicki
0bca0810b9 📝 Convert MenuManager docs 2014-08-25 15:08:45 -07:00
Kevin Sawicki
a2eb4d9303 Keep Packages submenu sorted
This ensures packages are in a predictable order regardless of whether
they are bundled or installed to ~/.atom/packages

Closes #3155
2014-08-12 18:16:00 -07:00
Kevin Sawicki
628ea72943 Check if selector matches parents of test element
Previously a menu for a keybinding with a .workspace selector would not
display the shortcut because the selector wasn't matching the test editor
element directly.

Now the parent elements of the test editor are checked as well.

Closes #2089
2014-05-16 11:57:04 -07:00
Kevin Sawicki
fc2830bacb Use div for test workspace element 2014-05-16 11:53:40 -07:00
Cheng Zhao
f48241bc5e Use new IPC API of atom-shell. 2014-04-29 15:16:27 +08:00
Corey Johnson
a407b0107a Remove deprecated call to keystroke 2014-04-18 10:43:27 -07:00
Kevin Sawicki
b328a69f50 Check that label exists when comparing to other items
Previously separators would be removed when merging menus that
contained multiple separators.

Refs atom/find-and-replace#159
2014-04-09 11:39:38 -07:00
Kevin Sawicki
b173fcdd59 Default workspace classes when array is empty 2014-04-02 16:42:25 -07:00
Cheng Zhao
271b104120 🐧 Fix normalized menu item label. 2014-04-02 14:26:10 +08:00
Nathan Sobo
65564e2012 Rename atom.keymap to atom.keymaps 2014-03-31 16:28:55 -06:00
Nathan Sobo
61e9befbe7 Favor the most recent matching binding when selecting app menu shortcuts
We sending every binding matching the `body` selector to the browser
process, but it only selects the first. Since we scan the bindings in
chronological order, we need to unshift bindings to the front of the
array so the most recently defined bindings are loaded first.
2014-03-21 10:42:04 -06:00
Kevin Sawicki
eb58ce7736 Return false on invalid selectors 2014-02-20 11:49:13 -08:00
Kevin Sawicki
fb73240654 Guard against non-existent .workspace element 2014-02-11 17:13:37 -08:00
Kevin Sawicki
29cbea4d50 📝 optional not option 2014-02-11 16:53:36 -08:00
Kevin Sawicki
8b1b3d237d Init pendingUpdateOperation in ctor 2014-02-11 16:53:00 -08:00
Kevin Sawicki
7d7f208fc5 Add missing keybidings to menu
This was caused by the test element not simulating a div element
with the .workspace class.
2014-02-11 16:48:32 -08:00
Kevin Sawicki
f24389a45b 📝 doc parameters in menu-manager.coffee 2014-02-06 16:51:39 -08:00
Kevin Sawicki
967db1f7b8 Remove more empty Private: comment blocks 2014-02-06 11:21:03 -08:00
Kevin Sawicki
932a792289 Remove Private: prefix 2014-02-06 10:02:53 -08:00
Kevin Sawicki
ece269f158 📝 Consistently mention what classes have global instances 2014-02-04 10:06:37 -08:00
Cheng Zhao
5912ac1d1b Merge multiple updates of menu into one update. 2014-02-03 17:02:11 +08:00
Kevin Sawicki
03eac362f6 📝 Add missing colon to Private 2013-11-22 13:39:24 -08:00
Kevin Sawicki
7d9d0c715c 📝 Mention what testEditor simulates 2013-11-21 16:01:55 -08:00
Kevin Sawicki
a9887b5007 Remove logging 2013-11-21 16:01:55 -08:00
Kevin Sawicki
c4dec72dcd Return early when document.body matches selector 2013-11-21 16:01:55 -08:00
Kevin Sawicki
d093d5cc06 Check selectors using webkitMatchesSelector 2013-11-21 16:01:55 -08:00
Kevin Sawicki
21560df2f0 Add platform class to selectors array 2013-11-21 09:19:33 -08:00
Matt Colyer
82e3935ae3 Guard against undefined labels 2013-11-19 11:57:59 -08:00
Matt Colyer
2b234545b5 Merge pull request #1116 from atom/windows-menus
Make Windows menus more Native(tm), fixes #1085
2013-11-18 11:08:04 -08:00
probablycorey
cb8e378af6 Use keyBinding in place of binding in method names 2013-11-15 13:49:17 -08:00
probablycorey
2fb00af255 Rename keyMapping to keyBinding 2013-11-14 16:20:35 -08:00
probablycorey
dd0938dca6 Merge remote-tracking branch 'origin/master' into cj-keymap-cleanup 2013-11-14 14:43:37 -08:00
probablycorey
e90f19da97 Rename keystrokeByCommmand to keystrokesByCommmand 2013-11-14 14:26:25 -08:00
probablycorey
c3aea1d149 Remove keymap.keystrokeByCommmandForSelector 2013-11-14 14:18:54 -08:00
Matt Colyer
cfab5c619d Use fat arrow when necessary 2013-11-14 10:39:09 -08:00
Matt Colyer
b6afc415f8 Merge menu items without regard to platform decorations 2013-11-14 10:31:20 -08:00
Matt Colyer
5454e93168 Make base menus platform dependent
This fixes the most egrerious errors on Windows but there's still room
for improvement.

Refs #1085
2013-11-14 10:15:23 -08:00
probablycorey
d71e58ec33 Use keystroke even when referring to multiKeystrokes
The use of keystroke and keystrokes was becoming confusing. When I 
started thinking of a keystroke as a set of keys that trigger a
command it became easier to think about.
2013-11-11 14:05:48 -08:00
Kevin Sawicki
0db23c3e96 🔥 config.bundledMenusDirPath 2013-11-11 10:33:09 -08:00
Kevin Sawicki
83dcf79bcf Use fs-plus 2013-11-01 08:46:02 -07:00
Matt Colyer
2ddcfb60cf Allow f2 and tab keybindings
This is possible now that we're on atom-shell@0.6.4
2013-10-22 15:17:12 -07:00
Matt Colyer
5e253378e2 Update restricted key bindings for atom-shell@0.6.3 2013-10-22 15:17:11 -07:00
Matt Colyer
1f86c62dc9 Remove accidental logging 2013-10-22 15:17:11 -07:00
Matt Colyer
74cb91a6a1 Add Edit > Lines submenu 2013-10-22 15:17:11 -07:00
Matt Colyer
5541875965 Don't append duplicate menu items
Fixes #995
2013-10-18 10:20:03 -07:00
Kevin Sawicki
ccdd17c0d8 Don't modify passed in item
Perform a deep clone before iterating over to add items and submenus.
2013-10-17 16:57:49 -07:00
Kevin Sawicki
e2ecff22c2 Use underscore-plus instead of underscore 2013-10-15 13:57:34 -07:00