Commit Graph

145 Commits

Author SHA1 Message Date
Jason Rudolph
f3f32c45cc Merge pull request #19176 from atom/respect-package-lock-on-ci
Teach CI to use versions specified in package-lock.json
2019-04-19 17:13:38 -04:00
Nathan Sobo
406e033323 Merge pull request #19183 from atom/ns/upload-windows-crashes-on-release-branches
On Azure DevOps, upload Windows crash dumps to S3 on release branches
2019-04-19 13:52:47 -06:00
Nathan Sobo
4bc43eb358 On Azure DevOps, upload Windows crash dumps to S3 on release branches
On release branches, we can't upload crash dumps because they will leak
secret environment variables. So instead we will upload them to our S3
bucket with 'private' ACL. They can then be manually retrieved via the
AWS CLI with our private credentials.
2019-04-18 17:04:49 -06:00
Nathan Sobo
7ef8f06cd2 Only upload Windows crash reports if the S3 key environment var is null
This seems like a more robust test than the isRelease variable I was
testing previously. Our goal is to not leak secrets such as the S3 key,
so this is a more direct test of that.
2019-04-18 15:15:31 -06:00
Nathan Sobo
b03d49973e On Azure DevOps, publish crash reports on non-release Windows branches
Since we don't expose sensitive information on these branches, we can
use the regular artifact publishing mechanism
2019-04-18 10:49:14 -06:00
Jason Rudolph
fce5a8974f Fix issue upgrading npm & use upgraded version 2019-04-18 10:59:33 -04:00
Jason Rudolph
cb3f24fc5c Use env var to specify path to npm binary 2019-04-18 09:53:40 -04:00
Jason Rudolph
680e48485a Set PATH so that Azure DevOps macOS builds use correct npm
Before we run script/bootstrap on the macOS build, the preceding build
step installs npm 6.2.0 as the global npm version. It installs npm at
`/usr/local/bin/npm`. However, a _different_ version of npm appears
earlier in the PATH. The PATH looks like this:

```
/Users/vsts/hostedtoolcache/node/8.9.3/x64/bin:
/usr/local/lib/ruby/gems/2.6.0/bin:
/usr/local/opt/ruby/bin:
/usr/local/opt/curl/bin:
/usr/local/bin:
/usr/local/sbin:
/Users/vsts/bin:
/Users/vsts/.yarn/bin:
/usr/local/go/bin:
/Users/vsts/Library/Android/sdk/tools:
/Users/vsts/Library/Android/sdk/platform-tools:
/Users/vsts/Library/Android/sdk/ndk-bundle:
/Library/Frameworks/Mono.framework/Versions/Current/Commands:
/usr/bin:
/bin:
/usr/sbin:
/sbin:
/Users/vsts/.azcopy
```

There's an npm executable at
/Users/vsts/hostedtoolcache/node/8.9.3/x64/bin/npm.

To get the build to use the global version of npm, this commit puts
/usr/local/bin at the beginning of the PATH.
2019-04-17 17:27:32 -04:00
Jason Rudolph
ce94241bde Configure Azure DevOps bootstrapping step to run with CI env vars 2019-04-17 12:23:05 -04:00
David Wilson
9ef6477b92 Temporarily disable draft release creation on release branches 2019-04-05 15:01:28 -07:00
Jason Rudolph
9e03795c20 Provide the BUILD_ARCH env var for bootstrapping Windows env on VSTS
`script/vsts/windows-run.js` checks the BUILD_ARCH env var, so let's 
make sure it's populated.
2019-04-03 13:11:24 -04:00
Jason Rudolph
166658f588 Add back bootstrapping to script/build on Windows
Hopefully this will resolve the error we're seeing here:

https://github.visualstudio.com/Atom/_build/results?buildId=37021&view=logs&jobId=97a617bf-bcbd-5dfa-bba2-cfba2747b693&taskId=1e1369e9-1c56-59b0-830c-f1606a680c8a&lineStart=13&lineEnd=19&colStart=1&colEnd=1

🤞
2019-04-02 19:43:45 -04:00
Jason Rudolph
5f52a8e0b0 Lint earlier in the build process 2019-04-02 19:43:44 -04:00
Rafael Oleza
874016b785 Add GITHUB_TOKEN env var to the npm install step (take 2)
This will prevent issues when installing the `vscode-ripgrep` package
2019-03-20 14:41:22 +01:00
David Wilson
ccc7233e51 Add GITHUB_TOKEN env var to the npm install step
This will prevent issues when installing the `vscode-ripgrep` package
2019-03-19 11:50:26 -07:00
Jason Rudolph
3b195122c4 Tell VSTS to build electron-* branches 2019-02-25 15:17:09 -05:00
David Wilson
ce4180e9f1 Upload Windows delta nupkg artifacts in release builds 2019-02-17 15:12:07 -08:00
Ash Wilson
402fa903fd Merge pull request #18802 from atom/aw/jasmine-junit-xml
Report test result metadata to Azure DevOps
2019-02-16 11:02:20 -05:00
Ash Wilson
06a1a38d25 Oh. Right. That's interpreted as a .bat file 2019-02-15 14:56:39 -05:00
Ash Wilson
60aaca8ecc Er, maybe no separator at all? 2019-02-15 13:02:25 -05:00
Ash Wilson
a645a8e638 Windows path separator maybe 2019-02-15 11:16:33 -05:00
Ash Wilson
536c582e2b Respect Atom.SkipTests 2019-02-15 11:16:19 -05:00
Ash Wilson
57ff580d66 Invoke the postprocessing script from CI 2019-02-15 10:09:36 -05:00
Ash Wilson
8c8fb426fc Merge pull request #18832 from atom/aw/report-crashes
Report macOS renderer crashes in CI
2019-02-12 12:23:40 -05:00
Ash Wilson
4d090b8f1e Set test run titles in PublishTestResults tasks 2019-02-12 11:59:38 -05:00
David Wilson
363741a88f Fix artifact upload of OLD_RELEASE_NOTES.md 2019-02-11 11:42:07 -08:00
David Wilson
2ac4beea63 Update release notes when creating another draft for same version 2019-02-11 11:42:07 -08:00
David Wilson
1571175eea Minor fixes to draft release creation
- Don't upload artifacts for a release that is already published
- Fix release notes on draft releases
- Fix Linux package uploading for draft releases
2019-02-11 11:42:07 -08:00
Ash Wilson
e1be511851 Unconditionally dump results 2019-02-11 13:33:35 -05:00
Ash Wilson
3b7ac36bec Azure doesn't like trailing whitespace 2019-02-11 13:31:59 -05:00
Ash Wilson
6e69bc0d7d Upload crash reports on macOS 2019-02-11 10:44:51 -05:00
Ash Wilson
da891bd120 Use spaces in TEST_JUNIT_XML_RUN 2019-02-11 10:13:31 -05:00
David Wilson
9264a6606a Remove unnecessary clause in release notes upload task 2019-02-08 14:00:43 -08:00
David Wilson
7c08366bac 👕 2019-02-08 13:33:31 -08:00
David Wilson
120a2b3771 Finish automated release notes generation 2019-02-08 13:33:31 -08:00
David Wilson
cdc8a23bc3 Remove shebang from upload-artifacts.js 2019-02-08 13:33:31 -08:00
David Wilson
3d85d5e5e2 Bump pr-changelog 2019-02-08 13:33:31 -08:00
David Wilson
025c56f3c1 🔒 Update package-lock.json 2019-02-08 13:33:31 -08:00
David Wilson
83b90df5fe Slight cleanup after rebase 2019-02-08 13:33:31 -08:00
David Wilson
0fc3b34292 Move upload-linux-package.js to script/vsts/lib 2019-02-08 13:33:31 -08:00
David Wilson
944a017f70 WIP: Generate changelog 2019-02-08 13:33:31 -08:00
David Wilson
053955165d Allow release build version to be overridden by ATOM_RELEASE_VERSION 2019-02-08 13:33:31 -08:00
David Wilson
3d532e6b68 Use Build.BuildId for more useful build versions 2019-02-08 13:33:31 -08:00
David Wilson
1b3ad8ecbb Create draft releases on successful release builds 2019-02-08 13:33:30 -08:00
David Wilson
7c56ae28a7 Move release publishing script and deps under script/vsts 2019-02-08 13:33:30 -08:00
Ash Wilson
65661ba8a3 Report test suites individually 2019-02-07 08:49:42 -05:00
Ash Wilson
4f575e0340 Does that expect a forward slash? 2019-02-06 21:14:40 -05:00
Ash Wilson
7361720363 Quoting is a thing 2019-02-06 20:20:13 -05:00
Ash Wilson
c11442df5e Explicit test-results.xml glob 2019-02-06 19:45:41 -05:00
Ash Wilson
f42de37cbc Set ROOT instead of PATH 2019-02-06 14:23:54 -05:00