Previously on zero length matches the last two rules were compared
and if they had the same scope name then the last rule was popped
and the remaining line was tokenized using the current scope stack
to prevent infinite parsing loops.
This caused nested method calls in Java to not tokenize correctly
since method rules were sequential in the stack but did not constitute
an infinite loop of zero matches since the stack was currently decreasing.
Now the last two rules are only compared when the stack size is increasing
to prevent this false positive.
Closes#587
Use a subtler error message that displays in the same place as the
loading message but does not change the entire background of the
view.
Also, extending classes can now customize the message displayed
when there are no items and also no filtered items to allow for
different messages for these two cases.
This removes the ugliness of having project.coffee require
image-edit-session at the end since the image-edit-session can
now register itself in an @activate callback and as a deferred
deserializer in the package.cson file.
Previously these values were only saved on the edit session when
is became inactive causing the scroll position to not always
persist between refreshes.
Closes#474
Previously only the first row was checked for a comment. Now all
rows are checked and the rows are only uncommented when they all
start with a comment.
This only impacts languages that do not specify a command end pattern.
Closes#554
Previously if the last 2 rules in the stack had no scope
name and the position wasn't advancing then the last rule
would be popped.
This caused Java single line comments to not parse properly
since the push rules for comment blocks have no scope name.
The main purpose of this spec is to test whether the simulation of modal
dialogs works, since the dialogs of atom-shell are real blocking modal
dialogs, there is no need to check whether the dialogs are presented as
modal dialogs correctly any more.
/cc @zcbenz since we don't use sendMessageToBrowserProcess anymore
these specs aren't mocked correctly. Is there a method that we can
mock when calling remote objects?
