Will Binns-Smith
0916b4c4f0
Manage focus for modal panels
...
This implements automatic focus management for modal panels using the
excellent focus-trap module.
Upon being shown, modals will have their first tabbable element
automatically focused, and shifting focus with the tab key (or more
correctly the core:focus-next command) will be limited to the contents
of the modal. If the modal does not have any tabbable elements, focus()
will be sent to the panel's root element (if it implements it).
I'm happy to update this to *always* calls focus on the panel's root
element, but then modal implementers would need to handle that and
focus things on their own. I'd argue the tabbable element behavior
is more accessible though :)
This has the effect of not automatically closing most of Atom's own
modals whenever the tab key is pressed, which was an odd nonstandard
behavior, IMO.
This also automates returning focus to the element that had focus before
the modal was shown, something up until now had to be implemented in
every modal in Atom.
This likely breaks a few contracts for existing Atom packages that
create modals, but I've found this doesn't conflict behaviorally with
well-behaved modals like the command palette which implement their own
focus management (which can be removed if this lands).
Released under CC0.
2017-08-22 23:09:44 -07:00
Nathan Sobo
4968a21b82
⬆️ etch
2017-08-22 18:09:26 -06:00
Max Brunsfeld
c62d7dcee5
⬆️ text-buffer
2017-08-22 16:57:13 -07:00
Damien Guard
abba8bff68
Include new language-typescript grammar
2017-08-22 09:47:02 -07:00
Max Brunsfeld
411d878b36
⬆️ fs-admin
2017-08-21 22:47:07 -07:00
Max Brunsfeld
337b7da4fe
⬆️ text-buffer
2017-08-21 22:27:14 -07:00
Max Brunsfeld
d3a8fe693b
⬆️ text-buffer
2017-08-21 15:58:54 -07:00
Max Brunsfeld
c823a5c6b5
⬆️ text-buffer
2017-08-21 14:57:08 -07:00
Max Brunsfeld
3d8f0e2406
⬆️ text-buffer
2017-08-21 14:30:02 -07:00
Nathan Sobo
5eae5ed5eb
Merge pull request #15392 from atom/fb-wb-standard-env
...
Use standard (eslint's) 'env' field over globals
2017-08-21 09:38:34 -06:00
Antonio Scandurra
bda74623ec
⬆️ tabs
2017-08-21 10:46:30 +02:00
Will Binns-Smith
bf00166d0e
Use standard (eslint's) 'env' field over globals
...
Test Plan: ensure every removed global is a part of an added `env` from https://github.com/sindresorhus/globals/blob/master/globals.json
run `./script/lint`
2017-08-20 19:29:10 -07:00
Nathan Sobo
0bfa019b2d
Merge pull request #15329 from atom/bu-arrow-up-ac-plus
...
⬆️ autocomplete-plus
2017-08-19 12:38:21 -06:00
Nathan Sobo
6c4e284c2c
⬆️ autocomplete-snippets
2017-08-19 12:00:02 -06:00
Nathan Sobo
16bb2ab8a8
⬆️ find-and-replace
2017-08-18 21:33:07 -06:00
Max Brunsfeld
d7d3f5976c
⬆️ text-buffer
2017-08-18 14:15:46 -07:00
Max Brunsfeld
78cd383e95
⬆️ pathwatcher and dependent packages
2017-08-18 12:57:03 -07:00
Ash Wilson
4c2d44059c
⬆️ github
2017-08-18 15:01:21 -04:00
Max Brunsfeld
15f7fe9f22
⬆️ text-buffer
2017-08-17 10:14:00 -07:00
simurai
e9e63a5f90
⬆️ one-dark/light-ui@v1.10.7
2017-08-17 20:48:27 +09:00
Katrina Uychaco
d2a266e369
⬆️ text-buffer@13.0.10
2017-08-16 14:21:57 -07:00
Bryant Ung
f47cf5b545
⬆️ autocomplete-plus
2017-08-15 20:52:17 -07:00
Bryant Ung
da2c3fb56b
Revert " ⬆️ autocomplete-plus@v2.35.8"
...
This reverts commit 3c2f257155
2017-08-15 20:47:32 -07:00
Wliu
aac5458f3c
⬆️ settings-view@0.251.5
2017-08-15 22:01:26 -04:00
simurai
3c2f257155
⬆️ autocomplete-plus@v2.35.8
2017-08-16 10:17:19 +09:00
Antonio Scandurra
756dad67d8
⬆️ symbols-view
2017-08-15 11:25:23 +02:00
Nathan Sobo
708c9b4e22
⬆️ text-buffer
...
Fixes #15190
2017-08-14 15:36:03 -06:00
Nathan Sobo
f82ff9c0d1
⬆️ language-css
2017-08-12 18:09:22 -06:00
Linus Eriksson
b14c4a32c9
⬆️ bracket-matcher@0.87.3
2017-08-11 21:26:31 +02:00
Wliu
fbd4b688dd
⬆️ language-javascript@0.127.2
2017-08-09 11:17:48 -04:00
Wliu
98296bf950
⬆️ language-java@0.27.3
2017-08-08 21:29:22 -04:00
Ash Wilson
1b22c59c0c
Merge pull request #15191 from smashwilson/aw-upgrade-github
...
Update github to 0.4.2
2017-08-08 19:43:14 -04:00
Ash Wilson
35a7ae6d2e
⬆️ github
2017-08-08 17:36:23 -04:00
Bryant Ung
87edc89815
Merge pull request #15186 from atom/b3-caps-lock-issues
...
Upgrade atom-keymap to fix caps lock issues on Windows
2017-08-08 13:43:24 -07:00
Ash Wilson
ff608ab524
⬆️ github
2017-08-08 15:32:24 -04:00
Ash Wilson
20fa0714b3
Revert " ⬆️ github"
...
This reverts commit 2bb7746d3e
2017-08-08 15:31:39 -04:00
Ash Wilson
2bb7746d3e
⬆️ github
2017-08-08 14:42:41 -04:00
Ash Wilson
fb0e29cf07
Merge pull request #14853 from atom/aw-filewatcher
...
Filesystem watcher API
2017-08-08 14:04:39 -04:00
bene
7b70b177fa
⬆️ atom-keymap@8.2.3
2017-08-07 22:05:12 +02:00
Ian Olsen
6fb6ac70a2
1.21.0-dev
2017-08-07 10:21:20 -07:00
Wliu
b4125022b6
⬆️ settings-view@0.251.4
...
To fix a flaky test
2017-08-06 20:47:31 -04:00
Wliu
224af13e64
⬆️ language-sass@0.61.0
2017-08-06 18:38:09 -04:00
Wliu
ee0e5cc6eb
⬆️ language-ruby@0.71.3
2017-08-06 18:37:15 -04:00
Wliu
8f01eeb7af
⬆️ language-todo@0.29.2
2017-08-06 18:36:37 -04:00
Wliu
ca6ab3fae0
⬆️ settings-view@0.251.3
2017-08-06 18:35:25 -04:00
Ash Wilson
6c608e88bc
Merge remote-tracking branch 'origin/master' into aw-filewatcher
2017-08-05 10:14:32 -04:00
Michelle Tilley
77b0cac28b
⬆️ github@0.4.0
2017-08-04 10:11:48 -07:00
Ash Wilson
4cf519f2d7
Merge branch 'master' into aw-filewatcher
2017-08-03 08:37:40 -04:00
Ash Wilson
fc53b21857
Merge pull request #15124 from smashwilson/aw-spec-reporters
...
Use spec reporters in CI
2017-08-03 06:54:54 -04:00
Jason Rudolph
03b631a1da
Merge pull request #15145 from atom/jr-tree-view-0-217-6
...
⬆️ Upgrade tree-view to 0.217.6 to fix intermittent CI failures
2017-08-02 18:30:44 -04:00
