Commit Graph

14260 Commits

Author SHA1 Message Date
joshaber
7ed4d60967 Don't need to pass Project around anymore. 2016-04-25 17:03:26 -04:00
joshaber
9fa669b293 Set the initial path after saving in Project. 2016-04-25 17:02:51 -04:00
joshaber
5cf532ebe8 Move checkoutHeadRevision to Workspace. 2016-04-25 17:02:36 -04:00
joshaber
856697e55f Uh we seriously don't need package manager.
Not sure how that slipped back in there.
2016-04-25 16:31:28 -04:00
joshaber
8d7f1b8fba Don't need to pass view registry through anymore. 2016-04-25 16:26:28 -04:00
joshaber
32a53e392c Merge branch 'remove-packagemanager-dependency' into remove-view-registry-dependency 2016-04-25 16:26:04 -04:00
joshaber
1c6d9728c4 Don't need to pass packageManager in anymore. 2016-04-25 16:25:36 -04:00
joshaber
3a63f90ab2 We just say getElement now. 2016-04-25 16:24:27 -04:00
joshaber
58d8e6bca8 Typo 2016-04-25 16:11:38 -04:00
joshaber
cf1b4e2217 Another new name. 2016-04-25 15:34:44 -04:00
joshaber
eaf6036a2c Wait a tick before sending the event. 2016-04-25 15:34:37 -04:00
joshaber
2266f1e3b6 Revert "Just use the already existing change grammar event."
This reverts commit 9014634b3a.
2016-04-25 15:15:31 -04:00
joshaber
9014634b3a Just use the already existing change grammar event. 2016-04-25 15:09:03 -04:00
joshaber
02bbb14052 Better method name 2016-04-25 15:02:16 -04:00
joshaber
b1301a5f74 Trigger the activation hook outside the text editor. 2016-04-25 14:50:34 -04:00
joshaber
e8a4f38c69 Don't need to pass the package manager through anymore. 2016-04-25 14:50:14 -04:00
joshaber
6b309be6da Propagate a did-use-grammar event out of the tokenized buffer. 2016-04-25 14:49:43 -04:00
joshaber
694af93009 Implement the show cursor scope functionality in the default commands. 2016-04-25 14:12:38 -04:00
joshaber
48e49061e6 Don't need to pass in the notification manager anymore. 2016-04-25 14:12:20 -04:00
joshaber
8bf34d45d7 Don't require notification manager in TextEditor
Instead expose getCursorScope and let users outside the text editor
show the notification.
2016-04-25 14:12:07 -04:00
joshaber
3574613fa3 Don't need resource pool anymore. 2016-04-21 14:19:24 -04:00
joshaber
c0eb8baae0 Provide _refreshingPromise. 2016-04-21 13:55:43 -04:00
joshaber
809d194f31 Update the tests 2016-04-21 13:17:35 -04:00
joshaber
aa96d47160 First pass 2016-04-21 12:36:45 -04:00
Nathan Sobo
48d4285dde Merge pull request #11420 from wvanlint/visible_overlay
Fixed positioning for overlay
2016-04-19 15:47:21 -06:00
Lee Dohm
d25347d78f Merge pull request #11463 from alazaro/skip-env-patching-fish
Fixes #11190
2016-04-18 13:32:49 -07:00
Michelle Tilley
b2aad098e1 Correctly autoindent \r\n in Selection#insertText 2016-04-18 11:06:51 -07:00
Michelle Tilley
e41b9f00fb Correctly autoindent single newline in Selection#insertText 2016-04-15 21:23:28 -07:00
Lee Dohm
6d80dfe228 Make the clone function more generic 2016-04-15 12:59:57 -07:00
Lee Dohm
9b8cb23757 Preserve the process.env magic for Windows 2016-04-15 10:49:30 -07:00
Michelle Tilley
c95412b451 Add ELECTRON_NO_ATTACH_CONSOLE in BufferedNodeProcess
(cherry picked from commit 5f0ad9e015)
2016-04-14 14:42:50 -07:00
Álvaro Lázaro Gallego
04ff6e4611 Fixes #4126 for fish-shell 2016-04-14 16:23:18 +02:00
Katrina Uychaco
49fb287592 Don't load packages starting with dot. Fixes #9805 2016-04-12 20:35:30 -07:00
Damien Guard
db31d795e8 Merge pull request #11437 from atom/dg-command-autorun-ignore
Ignore autorun on our buffered process commands. Fixes #10082
2016-04-12 12:04:25 -07:00
Damien Guard
2d173911b2 Ignore autorun on our buffered process commands. Fixes #10082 2016-04-12 12:02:20 -07:00
Joe Fitzgerald
82fa61e54d Allow Multiple Launches Of Atom To Result In An Updated Environment 2016-04-12 11:29:33 -06:00
joshaber
041906cdae Update nodegit API usage.
This changed in https://github.com/nodegit/nodegit/pull/968.
2016-04-11 11:42:21 -04:00
Willem Van Lint
8cd48004dd Fixed positioning for overlay 2016-04-09 18:42:18 -07:00
Cole R Lawrence
7decbf0d06 📝 Fix linking the decorateMarker
Error happens at this place in the docs
https://atom.io/docs/api/v1.6.2/TextEditor#instance-decorateMarkerLayer
2016-04-09 14:07:37 -05:00
joshaber
14afb49676 Use #index instead of #openIndex.
#openIndex is going away: https://github.com/nodegit/nodegit/pull/989
2016-04-08 15:58:23 -04:00
joshaber
991e4e396a Merge branch 'master' into fix-reading-cached-status-from-within-callback 2016-04-07 11:34:12 -04:00
joshaber
130c400758 Remove unnecessary fat arrow.
Looks like this was introduced in https://github.com/atom/atom/pull/11369. 
🙈
2016-04-07 11:25:00 -04:00
joshaber
db8e62315c Defer the callback to the next tick.
This gives GitRepository the chance to clear its path cache before the callback 
is invoked. Otherwise reads from the cached status state within the callback 
would be wrong.
2016-04-07 11:19:27 -04:00
Nathan Sobo
9833e54ec3 Fix typo 2016-04-04 19:22:44 -06:00
Nathan Sobo
f638bcbb6d Don’t assume the accented character menu on every IME event 2016-04-04 18:56:08 -06:00
Nathan Sobo
a99ee14ac0 Make accented character menu detection work with left/right arrow keys 2016-04-04 17:47:36 -06:00
Isaac Salier-Hellendag
2a7344091d Avoid setting hidden input value on textInput
Atom currently sets the `value` of the input on every `textInput` event, in an effort to appropriately handle changes made via the OSX diacritic menu (for accents, umlauts, etc).

The drawback of this is approach is that updating the value of the input will trigger layout and a subsequent layer tree update.

To resolve this, here is my proposal:

  - Track a flag for `keypress` events. When the diacritic menu is used, there are two `textInput` events, with no `keypress` in between. Therefore, when no `keypress` has occurred just prior to a `textInput`, the editor model can select the previous character to be replaced by the new accented character.
  - Track a flag for `compositionstart` events. When a user is in IME mode, the diacritic menu cannot be used, so the editor can skip the backward selection.

Test Plan:

Tested in a plaintext file.

  - Type Latin characters, verify proper character insertion.
  - Press and hold <kbd>a</kbd>. Diacritic menu appears. Select an option using the keyboard or mouse. Verify that the `a` is replaced by an accented `a`, with no extra characters.
  - Type test strings in Katakana, 2-Set Korean, Telex (Vietnamese), Simplified Pinyin. Verify that characters are inserted correctly while composing, and after committing strings.
2016-04-04 13:33:43 -07:00
Michelle Tilley
8575b38c7b Pending pane items shouldn't be made permanent before being replaced
Previously, when a Pane would replace a pending item with
another pending item, it would emit
`onItemDidTerminatePendingState` for that item, which was
not true because the item was actually being destroyed.
2016-04-02 17:48:24 -07:00
Antonio Scandurra
793f5f9692 Disable zoom every time a display gets added or removed 2016-04-01 16:04:01 +02:00
Antonio Scandurra
158d019371 Use application-level events to control updates in the browser process 2016-04-01 10:56:30 +02:00